Menu

#14 embedded metadata ICMT contains quotes around ArchiveSignature

2.0
closed
Peter B.
2025-01-30
2025-01-21
Peter B.
No

The archive signature in the comment field is enclosed by single quotes:
<ICMT>'v-00815', local; LIST-INFO metadata=https://mediaarea.net/AVIMetaEdit/listinfo</ICMT>

This is undesired, as it breaks FADGI convention.
The single-quotes are inserted (currently automatically) by the placeholder replacement library functions.

Discussion

  • Peter B.

    Peter B. - 2025-01-30

    Fixed in revision 542:

    Added new $quote parameter to ArchiveStructure::resolve_command() to make surrounding single-quotes (introduced by escapeshellarg()) optional.

    NOTE: Currently this is /only/ applied to MthkMovie::create_export_copy() to keep the affected lines in this change low. If the patch works and is stable, this shall be applied to all other calls of resolve_command() - and hand-quote their command strings once, too.

     
  • Peter B.

    Peter B. - 2025-01-30
    • labels: --> metadata, escaping
    • status: open --> closed
    • assigned_to: Peter B.
     
  • Peter B.

    Peter B. - 2025-01-30
    • Milestone: 1.0 --> 2.0
     

Log in to post a comment.

MongoDB Logo MongoDB