From: Ralf G. <Ral...@gm...> - 2008-05-26 05:08:57
|
Hi Kris, Kris Golko schrieb: > Ralf, > > I commited the code you provided to the repository. > I'd like to suggest a small change tough; > CaptureStackFrame should have parameters to pass > values like thrownException and Addr, so > thrownException.StackTrace can be moved into > CaptureStackFrame, where it belongs. > Yes, that is very good! As I wrote "It is not the most elegant solution I know" - but I feared to change more code than necessary (A bad approach I know). > Regarding compiler messages > > W1005 - it's a valid messages, the units are specific > to the platform; we don't care about other platform - > I concur with Jud that we should disable the warning > Just in case you are searching for the correct compiler directive, here it is: {$WARN UNIT_PLATFORM OFF} so my uses clause look like this: uses {$WARN UNIT_PLATFORM OFF} {$IFDEF CLR} System.Reflection, System.Diagnostics, {$ENDIF} SysUtils, Classes, IniFiles; {$WARN UNIT_PLATFORM ON} > Regarding hint H2443 - I added System.IO to the uses > clause, so ExpandFileName is now inlined > > Regarding hing H2369 - by convension .Net expects > property getters and setters to have names like > get_xxx, set_xxx. Basically it's just the convention - > do we want it chnaged so the hint doesn't appear? What > do you think? > The cleanest solution seems to me to change that, because the other solution I see (add another compiler directive) is not a good one! Because the methods are not virtual I guess we won´t break any code. What do you think? > Cheers > Kris > > |