Re: [Dump-devel] restore segfault

[Stelian P. <st...@po...>]

On Wed, Jan 21, 2004 at 05:20:32PM -0700, Patrick Higgins wrote:

> I'm trying to restore a dump created on Solaris 7 with ufsdump. I have
> been able to get partial filesystem dumps to restore correctly, but full
> filesystem dumps cause a crash.
> 
> I've used gdb to track the crash down, and is included at the bottom. I
> don't know what the fix should be, yet.
[...]

A genuine bug, here's the fix:

diff -uNr --exclude=CVS dump.orig/restore/tape.c dump/restore/tape.c
--- dump.orig/restore/tape.c    2003-11-22 17:52:16.000000000 +0100
+++ dump/restore/tape.c 2004-01-22 10:35:55.000000000 +0100
@@ -413,6 +413,7 @@
                dump_ino_t oldmaxino = maxino;
                maxino += (spcl.c_count * TP_BSIZE * NBBY) + 1;
                resizemaps(oldmaxino, maxino);
+               map = usedinomap;
 
                spcl.c_dinode.di_size = spcl.c_count * TP_BSIZE;
                getfile(xtrmap, xtrmapskip);

This will fix the segfault, but it still doesn't work on the
incremental you posted, which seems to be incorrect (no TS_BITS
header...). Maybe it will work on the full dump ?

Stelian.
-- 
Stelian Pop <st...@po...>