Re: [Dump-devel] Feature Creature -- Exclusion List

[Stelian P. <ste...@fr...>]

On Tue, Jan 14, 2003 at 07:23:15AM -0500, PeterKorman wrote:

> > Please generate the diffs in unified diff format:
> > 	diff -uNr dump.orig/ dump.modified/
> 
> I wasn't adding files, so I was doing:
> 
> for i in $(find old -print | sed -e 's=old/==')
> do
>   diff -C6 $old/$i $new/$i
> done
> 
> But the -r option looks like it could be
> less work, the -Ux option is easier to read,
> and if you dont want extra context lines, the 
> -u option is easier to type;-)

-u is enough.
> 
> > Please use <TAB> characters instead of spaces. And let it be
> > 8 characters wide.
> 
> Do you run an entab program? Which one?

I don't. I just use one true editor (vi) and it works pretty well :)

> How bout GNU indent? It usually sucks for
> comments but otherwise itz pretty good.

I suppose that, once configured to fit the existent style it could
work, yes.

> Itz ez for me to do it by hand for a small
> change, but when I've had to maintain a project
> bigger than 1 file with more than 1 person making
> changes, indent is nearly as good as prozac.

I agree. However, dump is a small project and coding style is not that
important. The rule is: do in the same way as it's already done, and 
since I'm the only one with write access to the repository, if I don't
like your code I'll complain or fix it myself.

Stelian.
-- 
Stelian Pop <ste...@fr...>
Alcove - http://www.alcove.com