Re: [Dump-devel] Feature Creature -- Exclusion List

[PeterKorman <cal...@ei...>]

On Tue, Jan 14, 2003 at 09:50:00AM +0100, Stelian Pop wrote:
> On Mon, Jan 13, 2003 at 11:27:39PM -0500, PeterKorman wrote:
> 
> > 
> > I have a patch for the current version, but until I'm running it for at least a week
> > I'm not comfortable with posting it.
> 
> Please use the latest CVS version, it will be easier for me to
> integrate your changes.

U got it.

> CVS access instructions are on http://dump.sourceforge.net, then
> follow the links.
> 
> Please generate the diffs in unified diff format:
> 	diff -uNr dump.orig/ dump.modified/

I wasn't adding files, so I was doing:

for i in $(find old -print | sed -e 's=old/==')
do
  diff -C6 $old/$i $new/$i
done

But the -r option looks like it could be
less work, the -Ux option is easier to read,
and if you dont want extra context lines, the 
-u option is easier to type;-)

I didn't see your patch format till I realized 
I patched the wrong version. I was hoping to
see no changes to main.c in 31->32. Not only
were there changes, there were changes in the
same routines. I hate it when that happenz.

> Please use <TAB> characters instead of spaces. And let it be
> 8 characters wide.

Do you run an entab program? Which one?
How bout GNU indent? It usually sucks for
comments but otherwise itz pretty good.
Itz ez for me to do it by hand for a small
change, but when I've had to maintain a project
bigger than 1 file with more than 1 person making
changes, indent is nearly as good as prozac.

Cheers,

JPK