Re: [Dump-devel] dump and largefiles

[Andrea A. <an...@su...>]

On Tue, Dec 19, 2000 at 02:19:19PM -0800, ty...@va... wrote:
> At least at the source level, I can easily hide the need for O_LARGEFILE
> and lseek64 in specific library routines, and it's easy enough to have
> autoconf macros that only use O_LARGEFILE and use lseek64 if present
> (and even then, I only use it when necessary).

Using O_LARGEFILE and lseek64 only if present is necessary for supporting
systems without those implemented, but it's not the way to cleanup
the sourcecode.

> The problem with using the #define method is that it changes the size of
> off_t.  So libraries built with and without -D_LARGE_FILE_SIZE=64 
> have ABI changes if any of their function prototypes or structures
> contain off_t.  This is bad, bad, bad, bad, bad.  *Especially* for
> shared libraries.  

I see, off_t redefined will definitely break the interface. I agree that for
libs explicit LFS coding is necessary.

Andrea