Re: [Dump-devel] dump and largefiles

[Stelian P. <ste...@al...>]

On Tue, Dec 19, 2000 at 12:34:13PM +0100, Andrea Arcangeli wrote:

> > Does it hurt to use this patch on a non-LFS system ? Even with
> > this patch, it will continue to run correctly on a non-LFS system
> > I suppose...
> 
> Strictly speaking there's the case of a non-LFS system with a largefile into
> it. restore won't work (think the truncate for the filesize). I think the
> `dump` stage could even work for a non-LFS system as e2fsprogs probably only
> accesses the blockdevice via read/write/lseek64.
> 
> But you can't do much about that case (other than maybe print a warning
> and I was too lazy to care about that ;).
> 
> So I'd say yes.

Anyway, I'll apply your patch, and I'll make an option to the 
configure (--enable-largefile) which will trigger the addition
of -D_FILE_OFFSET_BITS=64 to the compile line.

This configure flag will default to no for now. It will be up to 
each distribution to enable or disable it depending on whether they
build a LFS system or not.

Sometimes in the future, when all distributions will be 2.4 based,
and all systems will have LFS features by default, I'll transform
the flag to default to yes.

> Stelian, do you have a regression test suite for dump? 

I should have, but... I don't. Generally I do several dump/restore -C
in order to test but it isn't an automatic process...

> Does my patch works
> flawlessy for you too? 

It works for me, but I don't have a LFS system, so I didn't really
test the new features, just non regression for 'small' files.

> I tested it on a 5G largefile without holes and a 8G
> largefile with holes and a few small files.  It worked fine for me but as said
> I haven't tested it very extensively (nor I tested e2fsck keeps working,
> but that should really keep working ;). If you run a regression test suite
> against it please keep me posted (I need some extensive testing on it). Thanks!

As far as I can tell, your changes are valid and are exactly what
I had planned to do some time ago but never had the time to. But
of course, this is only a source code test level, not a executable
test level :)

Stelian.
-- 
Stelian Pop <ste...@al...>
|------------- Ingénieur Informatique Libre -------------|
| Alcôve - http://www.alcove.fr - Tel: +33 1 49 22 68 00 |
|----------- Alcôve, l'informatique est libre -----------|