From: Kenneth P. <sh...@se...> - 2008-06-27 21:06:19
|
On Friday, June 27, 2008 11:47 AM +0200 Stelian Pop <st...@po...> wrote: > This would work if the target file exists, but how to deal with a > missing target file ? (for example, supposed that you dumped /dev/hda, > but when comparing you don't found this file). > > What we need when comparing is to find out if a whole path is masked my > a mount point and then stop comparing all the leafs of this path. But > since the comparing is done in the inode number order (not in the > directory / contents order), it's not that simple. Good point. I don't tend to see a lot of missing files as my dumps and verifies are done in the middle of the night when the system is quiet, and I haven't masked any large hierarchies with a mount point. Legitimate missing files in my verifies tend to be a result of a tmpwatch sweep. The missing file case would need to walk up the path to the mountpoint of the filesystem being verified, looking for a node that exists, and either report the current message if the node is in the right filesystem, or the "masked by mountpoint" message if not. Is the runtime cost of doing that prohibitive? If not, I can look into constructing a patch to do this. |