#168 Problem with dump/restore xattrs

[Josef Ridky]

On ext3/4 volumes with inode size more than 128b, directories lose some of it's xattr's after restore.

Version-Release number of selected component (if applicable):
dump-0.4b45

How reproducible:
Need ext3/4 volume with inode size 256b and extended attributes user namespace support.

Steps to Reproduce:
In some directory:
1. mkdir -p test/dir
2. for (( i = 0; i < 6; i++ )); do setfattr -n user.$i -v $i dir done
3. dump -0 -f test.dump test
4. restore -r -f test.dump
5. In restored test directory: getfattr -d dir

Actual results:
user.1="1"
user.2="2"
user.3="3"
user.4="4"
user.5="5"

Expected results:
user.0="0"
user.1="1"
user.2="2"
user.3="3"
user.4="4"
user.5="5"

[Tim Woodall]

Attached is a fix. There was a fix in debian for a very long time for the same underlying issue for files. the difference was that for files, restore worked but a restore -C failed. That half fix meant that restore -C worked for directories even though the restore didn't.

This patch combines the existing patch in debian with the fix for the xattr for dirs such that restore and restore -C both work correctly.