[Dspam-devel] [ dspam-Feature Requests-2845110 ] Disallowed preferences should be greyed out in the
Brought to you by:
paulcockings,
sbajic
From: SourceForge.net <no...@so...> - 2009-08-30 23:07:07
|
Feature Requests item #2845110, was opened at 2009-08-26 20:34 Message generated for change (Comment added) made by sbajic You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126468&aid=2845110&group_id=250683 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: webui Group: None Status: Open Priority: 5 Private: No Submitted By: Julien Valroff (valroff) Assigned to: Nobody/Anonymous (nobody) Summary: Disallowed preferences should be greyed out in the WebUI Initial Comment: Hi, It seems quite misleading for the user that a disallowed preference is accessible from the WebUI. It should better be greyed out. Cheers, Julien ---------------------------------------------------------------------- >Comment By: Stevan Bajic (sbajic) Date: 2009-08-31 01:07 Message: You are right. As soon syslog is enabled the disallowed preferences are printed there and not to stdout. I should probably add two additional options to dspam_admin: allowed preference [user] disallowed preference [user] Kind Regards, Stevan Bajic ---------------------------------------------------------------------- Comment By: Julien Valroff (valroff) Date: 2009-08-27 08:29 Message: Hi Steve, I guess (not tried without) because syslog support is enabled (and is now the default). I have obviously tried running the code used in dspam_notifiy.pl, and I get no "Ignoring disallowed preference..." output on stdout, just an entry in syslog (mail facility), eg: Aug 26 20:02:03 nix dspam[3919]: Ignoring disallowed preference 'dailyQuarantineSummary' Cheers, Julien ---------------------------------------------------------------------- Comment By: Stevan Bajic (sbajic) Date: 2009-08-27 01:08 Message: And why do you think that it is redirecting stdout to syslog? ---------------------------------------------------------------------- Comment By: Julien Valroff (valroff) Date: 2009-08-27 00:44 Message: I see dspam_notify.pl uses the following code to detect an AllowOverride: chomp($ALLOW_OVERRIDE = `dspam_admin agg pref 'default' 2>&1 | grep -i -c "Ignoring disallowed preference 'dailyQuarantineSummary'"`); This code cannot work as the error is sent to syslog and not to stdout/stderr. Would it be possible to add a --list-allowed-overrides option to dspam_admin (read-only of course)? This would simply list allowed overrides values (one on each line, to be easy to parse), eg: trainingMode spamAction spamSubject dailyQuarantineSummary Cheers, Julien Cheers, Julien ---------------------------------------------------------------------- Comment By: Julien Valroff (valroff) Date: 2009-08-26 21:48 Message: I will be able to provide a patch implementing this, but would like to know if there is a better way to get AllowOverride entries than parsing the config file from the CGI's? This way works, but we are not sure these are the current parameters (they can have been changed but daemon not reloaded). Cheers, Julien ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1126468&aid=2845110&group_id=250683 |