Menu

#8 Path for plugins are hardcoded

1.x
accepted
None
5
2018-11-25
2018-10-10
No

Hi,

In library/rt/backendmanager.cpp line 142 path for libdrumstick-rt-*.so file are harcoded
to 'apppath' ../lib ../lib32 ../lib64

This is annoying because these path doesn't follow triplet path installation as used now in Debian/Ubuntu and probably other. For example for amd64 the triplet is 'x86_64-linux-gnu'

The best would be to use the cmake variable LIB_SUFFIX as search path.

Discussion

  • Pedro Lopez-Cabanillas

    And where is the patch you propose?

     
  • Debian Package

    Debian Package - 2018-10-10

    I don't have a patch, because I don't know how to use LIB_SUFFIX in Qt
    After some search I see QCoreApplication::libraryPaths()

    http://doc.qt.io/qt-5/qcoreapplication.html#libraryPaths

     
  • Pedro Lopez-Cabanillas

    If there is no patch you should have created this ticket in "feature requests" or "bugs", not in patches.

    The contents of QCoreApplication::libraryPaths() is already returned by BackendManager::defaultPaths(), along with many other elements.The environment variable $DRUMSTICKRT may contain a path for drumstick plugins as well, and $HOME/drumstick, etc. It is a list of paths to search for plugins. Applications may add paths as well.

    Anyway if you want to make available LIB_SUFFIX from the CMake build system to the compiler, the way to go is to include in CMakeLists.txt a line like this one:
    add_definitions(-DLIBSUFFIX=${LIB_SUFFIX})
    see for instance https://sourceforge.net/p/drumstick/code/HEAD/tree/trunk/CMakeLists.txt#l61
    And then, use the externally defined symbol LIBSUFFIX in the code (example: utils/common/cmdversion.h)

     
  • Pedro Lopez-Cabanillas

    • status: open --> accepted
    • assigned_to: Pedro Lopez-Cabanillas
     

Log in to post a comment.