Suggestions for SearchInFiles Plugin

[Franz Steinhaeusler]

Suggestions for SearchInFiles Plugin after consulting Daniel:

  - select file:
      Franz: if the file was already open, activate that tab and jump
        to the first occurence of the findstring
      Dan: "OnActivate should be enough" 
      Franz: If the file was not open, it opens it, and also jumps
        to first occurence of the findstring
 
  - to fix: add findstring to history (now: combobox stays empty)
 
  - Filepattern and directory should be changed from textcontrol to combobox
      (because of history entries)
 
  - able to save history entries for all three comboboxes   
 
  - if a file is already loaded, it could be marked with a '*' or so in the list
    Dan: "This effects how I launch each file, and I am not inclined to."
 
  - possibility like in pype to insert several directories or extensions
      divided by ';'
      example: pattern: "*.cpp;*.h"
      Dan: "Perhaps allow regular expressions?
        Or do you think parsing for ';' and manually spearating is best?"
      Franz: I think, the solution with separating is easier to understand
        also for the user
      Allow regular expressions could also be an option; But is this so
        useful for filenames and extensions (?) 
 
  - is the focus in the list: pressing return jumps to the marked file
      (same as doubleclik the list)
 
  - Statustext: display current searched file
      Dan: "Maybe.  The last time I tried this, it was a significant slowdown
        in the search process. It is a question of effieciency vs transparency. 
        I could go either way on this."
      Franz: Display only the current scanning directory. Statustext is only
        updated, if the directory changes. This should nothing slow down.
 
  - use better sizers; put buttons on the right side of the dialog(?)

  - Preset the directory control with the path of the current active tab.
      Implement as option?

  - Preset search string, with what was selected or word under cursor.
      Implement as option?

  - Size and Position: adjustable or memorize last used and use it then the next time.

Maybe:
  - use a listctrl for sorting after filenames, extension, paths, and "currenly open".
      (If it makes sense to anybody, the size, date and attributes could also be added)
 
  - show also lines, where the search string is in it, as a TreeList
      Make an option of this:

Dismissed:
  - Highlighting the search string in founded lines (colorize or show bold).
  - Integrate as panel like findall?

New:
  - Icon for SearchInFiles Frame (so on (windows) task list, it is easy to discern).

Any opinions, ideas?

[Franz Steinhaeusler]

  - Put extension to history
    I often use either (*.cpp;*.h) or (*.py) ord (*.txt;*.html) or (*.*)
    That would be convenient
    I would preset in the dialog the last used extensions of the former
      file search process
  - use a statusbar? (when the next file is selected,
      display current searching directory (and file) and a counter
      of already searched files
      (I think, this can't be a bigger performance obstacle)
  - Possibility to cancel the current search
  - Run the search as own thread
  - ??take care, if a file is in memory already: should it be only searched
      as file or search the according txtDocument?

[Franz Steinhaeusler]

Hi,

first prototype is ready at:

http://berg.heim.at/anden/421194/FranzSearchInFiles.zip

I post changelog tomorrow.
please only use the find, and not the replace feature.

There is a wxpython bug also:
please don't be irritated, that there are all three (or
four, if you want to call the replace) are selected.
I want to find a solution for this.

Franz

[Franz Steinhaeusler]

Changelog and todo:

http://berg.heim.at/anden/421194/FranzSearchInFiles_ChangeLog_Todo.zip

Any opinions, ideas?
Is the display of the Dialog on Linux (with sizers) ok?

[Franz Steinhaeusler]

Hello,
I've uploaded "FranzSearchInFiles".

Wouldn't it be convenient, to add in the files
a beta-plugins section?

[Daniel Pozmanter]

I've been playing around with the plugin, and I really like it.  Very slick.  To your knowledge, is there anything the original plugin can do that this can't, or any unresolved bugs?  If not, I'd like to make this the default, and deprecate SearchInFiles.

[Franz Steinhaeusler]

I'm pleased, that you like the plugin.

Nothing is removed from the original plugin.
I have tested it, I think, thoroughly (but only on
Windows XP).

Are there any functions missing, one would like to
see/have ?

[Daniel Pozmanter]

Nope, it looks good to me.

When you are ready to make your next release:

Name it Search In Files 1.1.0, and note somewhere that 1.0.0 was made by me, and that subsequent versions are authored by you (unless you want to keep it FranzSearchInFiles).

When I update the website (i still haven't gotten around to listing all the plugins with descriptions), I will deprecate 1.0.0, and point people to the new plugin.

Cheers,
Dan

[Franz Steinhaeusler]

Hi,

I uploaded the new SearchInFiles.
You can edit of course the source and changelog.txt again.

[Daniel Pozmanter]

Excellent, looks good.

There is an issue if there user doesn;t have a custom toolbar file, but I am not sure if that is a drpython issue, or a plugin issue.

I have updated the site.  Still not complete, but nicer.

[Franz Steinhaeusler]

Version 1.1.2
    (Changes by Franz Steinhaeusler)
  - restructured source (no globals anymore, wrapped functions into class drFindReplaceInFilesPanel)
  - bug in replacefiles fixed. (which i have built in in 1.1.0)
  - Single Instance option
  - Multiple Instances open: ther was a "PyDeadObject" bug. fixed.