Re: [DrJava] Bug in interactions pane

[Charles R. <cr...@ri...>]

  Ok, it's fixed now.  Kind of subtle, actually-- we used to use an
InteractionsEditorKit in the InteractionsPane, which would ensure that all
documents created in the pane were our InteractionsDocuments.  The
refactoring changed the contract a bit so that the kit had to be
"installed" after the pane was created.

  Well, apparently an undocumented side-effect of installing an EditorKit
is that a new document is immediately created.  Thus, the InteractionsPane
was displaying a different document than the one the model was using, so
nothing that was entered by the user was being sent to the interpreter.
Here's a good reason to avoid side-effects in your methods!  (And be aware
of them in the core Java libraries.)

  Anyway, I added a test to cover this scenario, and the
InteractionsEditorKit isn't currently being used.  (To tell the truth, I
don't see it's usefulness, since there's only ever one document per
InteractionsPane anway.)

Charlie


On Thu, 6 Feb 2003, Charles Reis wrote:

> Hey guys--
>   I appear to have inserted a pretty massive bug into the Interactions
> Pane yesterday as part of my refactoring effort.  If you hit Enter, it
> appears to lock up.  I'm amazed neither I nor the unit tests caught it
> before I committed, but I'll write a test to display it and fix it ASAP.
> (I'm on my way to get my oil changed at the moment, but I should have it
> fixed by noon or so.)
>
> Sorry about that,
> Charlie
>
>
>
> -------------------------------------------------------
> This SF.NET email is sponsored by:
> SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
> http://www.vasoftware.com
> _______________________________________________
> drjava-hackers mailing list
> drj...@li...
> https://lists.sourceforge.net/lists/listinfo/drjava-hackers
>