drjava-hackers

[DrJava] Undo/Redo of Deletes

[Peter C. <pe...@ce...>]

Hi guys,

Like Charlie, I'm loving the new changes, especially in the 
interactions pane.  The conditional return handling is a really nice 
use of the pre-processor.

I also like the changes to group text operations into single undo/redo 
blocks.  However, the current implementation ignores use of the delete 
key.  Although text additions are grouped, text deletes are not.  This 
makes for somewhat odd undo/redo behavior.  You may want to patch that 
before the stable, for consistency.

Hopefully I'll be contributing more actively soon.  (I'm trying to 
negotiate for an independent study course to work on UI issues in 
DrJava.)  Keep up the good work!

--
Peter Centgraf
Master of HCI Student (and DrJava Developer)
Carnegie Mellon University

Re: [DrJava] Undo/Redo of Deletes

[Charles R. <creis@u.washington.edu>]

> I also like the changes to group text operations into single undo/redo 
> blocks.  However, the current implementation ignores use of the delete 
> key.  Although text additions are grouped, text deletes are not.  This 
> makes for somewhat odd undo/redo behavior.  You may want to patch that 
> before the stable, for consistency.

I agree-- a deletion should end a block of consecutive additions, but 
several consecutive deletions should also be treated as a single block 
(eg. until the next addition, etc.).  Don't know if that's feasible 
before the stable, but hopefully with a unit test it shouldn't be too hard.

Charlie