From: Doug R. <df...@qu...> - 2000-08-16 10:38:12
|
On Tue, 15 Aug 2000, David Dawes wrote: > I've been looking into some build problems with the latest XFree86 CVS > on FreeBSD 5.0-current, and noticed that many of the drm files are > either identical for both of these platforms or extremely close. The > biggest difference (and the reason for the build problems) was some version > skew. I'm going to commit some changes to the XFree86 CVS that allow > the common files to be shared. In particular these files: > > os-support/<os>/drm/drmmodule.c > os-support/<os>/drm/xf86drmHash.c > os-support/<os>/drm/xf86drmI810.c > os-support/<os>/drm/xf86drmMga.c > os-support/<os>/drm/xf86drmR128.c > os-support/<os>/drm/xf86drmRandom.c > os-support/<os>/drm/xf86drmSL.c > os-support/<os>/drm/kernel/drm.h > os-support/<os>/drm/kernel/i810_drm.h > os-support/<os>/drm/kernel/mga_drm.h > os-support/<os>/drm/kernel/r128_drm.h > os-support/<os>/drm/kernel/sis_drm_public.h > > There are two other files that might potentially be shareable, but for > which I'd like some more advice on: > > os-support/<os>/drm/xf86drm.c > os-support/<os>/drm/kernel/drmP.h > > I'd appreciate some comments from those familiar with this stuff > (Rik, Doug?) on how appropriate this is, how OS-specific these > files should be expected to be, and if there are OS-specific parts > whether there could be a better way of splitting those out to make > maintaining them easier. I think that xf86drm.c would share pretty easily with a light sprinkling of ifdefs but drmP.h might be a bit uglier. A much bigger problem is to try and track changes to the chipset drivers. I've been thinking about this a lot and I think that with a modest amount of rewriting, we should be able share some of the driver code (probably all except foo_drv.c). > > Also, I'll be committing some changes to the XFree86 CVS that should > enable AGP support for FreeBSD 4.1 and 5.0-current (at least for the i810 > 2D driver), but I don't have the hardware to test these. Ruslan Ermilov <ru...@fr...> did the work to get the i810 AGP driver going on FreeBSD and I'm sure he would be happy to test any patches to XFree86. -- Doug Rabson Mail: df...@qu... Technical Director, Qube Software Ltd. Phone: +44 20 7431 9995 |