From: Ian R. <id...@fr...> - 2010-10-11 18:24:02
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Zhao, Jian J wrote: > Hi, > > Recently I have made a piglit case that can test the behaviors of > buffer swap, they are 1) test whether we can get swap events. 2) verify > whether the swap is asynchronous 3) verify the swap frequency of swap > interval being 0 is larger than interval being 1. Jesse has helped me > have brief look on it and give me some advice. I have modified it. Can > you help to add it into piglit tests? Thanks for help and comments! Please send tests as patches using git-send-email. This enables people to put review comments in-line. - Fix the comment and license at the top of the file. - Re-wrap lines to 80 columns. - Fix broken whitespace usage }else{ should be } else { and if(foo){ should be if (foo) { etc. - piglit_report_result already calls exit, so the calls to exit in the code after calls to piglit_report_result are not necessary. - Use the utility routines in piglit-glx-util.c instead of open-coding them. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkyzUcYACgkQX1gOwKyEAw+6zQCgkYPvU/Da9bzczyMxzl5EZx4y ougAoJtpcsfVsB7l3jM+HvA+0jeE4opn =EiQk -----END PGP SIGNATURE----- |