[Bug 25679] R600: Winding is inverted when rendering to FBO

[<bugzilla-daemon@fr...>]

http://bugs.freedesktop.org/show_bug.cgi?id=25679





--- Comment #1 from Alex Deucher <agd5f@...>  2009-12-16 12:56:30 PST ---
Created an attachment (id=32132)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=32132)
fix fbo winding

Does this patch work?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 25679] New: R600: Winding is inverted when rendering to FBO

[<bugzilla-daemon@fr...>]

http://bugs.freedesktop.org/show_bug.cgi?id=25679

           Summary: R600: Winding is inverted when rendering to FBO
           Product: Mesa
           Version: git
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/R600
        AssignedTo: dri-devel@...
        ReportedBy: monraaf@...


Winding is inverted when rendering to FBO. This breaks many games. You can test
it by running progs/demos/fbotexture and press 'c' tot toggle back-face culling
and compare the image with the output of the software renderer.

I found a relevant commit which fixes this bug on r300.

http://cgit.freedesktop.org/mesa/mesa/commit/?id=60e60bb3026a269fefe1cfd3312fdf3a7e4c595f


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 25679] R600: Winding is inverted when rendering to FBO

[<bugzilla-daemon@fr...>]

http://bugs.freedesktop.org/show_bug.cgi?id=25679





--- Comment #1 from Alex Deucher <agd5f@...>  2009-12-16 12:56:30 PST ---
Created an attachment (id=32132)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=32132)
fix fbo winding

Does this patch work?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 25679] R600: Winding is inverted when rendering to FBO

[<bugzilla-daemon@fr...>]

http://bugs.freedesktop.org/show_bug.cgi?id=25679





--- Comment #2 from monraaf <monraaf@...>  2009-12-16 13:11:21 PST ---
(In reply to comment #1)
> Created an attachment (id=32132)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=32132) [details]
> fix fbo winding
> 
> Does this patch work?
> 

Yes it does. thanks!


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 25679] R600: Winding is inverted when rendering to FBO

[<bugzilla-daemon@fr...>]

http://bugs.freedesktop.org/show_bug.cgi?id=25679





--- Comment #3 from Rafał Miłecki <zajec5@...>  2009-12-16 13:13:27 PST ---
It makes r600 render fbotexture same way as software does on my RV620.

In both renderers I see some difference when pressing "c". Inside of teapot
changes between black and transparent (blue in result, due to blue background).
Is that expected?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 25679] R600: Winding is inverted when rendering to FBO

[<bugzilla-daemon@fr...>]

http://bugs.freedesktop.org/show_bug.cgi?id=25679


Alex Deucher <agd5f@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Alex Deucher <agd5f@...>  2009-12-16 13:19:48 PST ---
Pushed:
20ee275974a58cd221031d522ad58a9548af2a31


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 25679] R600: Winding is inverted when rendering to FBO

[<bugzilla-daemon@fr...>]

http://bugs.freedesktop.org/show_bug.cgi?id=25679





--- Comment #5 from Andy Furniss <lists@...>  2009-12-17 03:51:43 PST ---
(In reply to comment #4)
> Pushed:
> 20ee275974a58cd221031d522ad58a9548af2a31
> 

Doesn't seem to fix progs/demos/fbotexture for me on RV670 AGP kms.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 25679] R600: Winding is inverted when rendering to FBO

[<bugzilla-daemon@fr...>]

http://bugs.freedesktop.org/show_bug.cgi?id=25679





--- Comment #6 from Alex Deucher <agd5f@...>  2009-12-17 07:52:29 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > Pushed:
> > 20ee275974a58cd221031d522ad58a9548af2a31
> > 
> 
> Doesn't seem to fix progs/demos/fbotexture for me on RV670 AGP kms.
> 

I applied to to the 7.6 branch, so if you tried master or 7.7 branch, it's not
there yet.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 25679] R600: Winding is inverted when rendering to FBO

[<bugzilla-daemon@fr...>]

http://bugs.freedesktop.org/show_bug.cgi?id=25679





--- Comment #7 from Andy Furniss <lists@...>  2009-12-17 08:05:32 PST ---
(In reply to comment #6)

> I applied to to the 7.6 branch, so if you tried master or 7.7 branch, it's not
> there yet.

Ahh, I am on master. 

I didn't realise that git show would show things from other branches.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.