[Bug 14313] [i915 PBO TTM] read pixels through PBO not working when pixel alignment is 1

[<bug...@fr...>]

http://bugs.freedesktop.org/show_bug.cgi?id=14313





--- Comment #1 from Shuang He <shu...@in...>  2008-02-03 00:17:43 PST ---
I missed something. Actually the original code is meant to blit copy vertically
in reverse direction. but that code seems not working. and following patch
change it to blit copy in normal direction. But it seems it's handling
differently when the area is exceed the screen size, compared with software
rendering. That's why glean case readpixPerf(read 1000x1000 area) failed when
screen resolution is 1024x768:

diff --git a/src/mesa/drivers/dri/i915/intel_pixel_read.c
b/src/mesa/drivers/dri/i915/intel_pixel_read.c
index 2e31656..4c6c3b4 100644
--- a/src/mesa/drivers/dri/i915/intel_pixel_read.c
+++ b/src/mesa/drivers/dri/i915/intel_pixel_read.c
@@ -222,9 +222,6 @@ do_blit_readpixels(GLcontext * ctx,
          _mesa_printf("%s: MESA_PACK_INVERT not done yet\n", __FUNCTION__);
       return GL_FALSE;
    }
-   else {
-      rowLength = -rowLength;
-   }

    /* XXX 64-bit cast? */
    dst_offset = (GLuint) _mesa_image_address(2, pack, pixels, width, height,
@@ -269,7 +266,7 @@ do_blit_readpixels(GLcontext * ctx,
                            rect.x1,
                            rect.y1,
                            rect.x1 - src_rect.x1,
-                           rect.y2 - src_rect.y2,
+                           rect.y1 - src_rect.y1,
                            rect.x2 - rect.x1, rect.y2 - rect.y1,
                           GL_COPY);
       }


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.