Re: [r300][PATCH] fix vertex attribs - Re: [r300] ARB vp attribs broken

[Rune P. <ru...@me...>]

f***** it up ....


Rune Petersen

Rune Petersen wrote:
> Brian Paul wrote:
>> Rune Petersen wrote:
>>> Tilman Sauerbeck wrote:
>>>
>>>> Rune Petersen [2006-06-25 16:31]:
>>>>
>>>>> I've been looking at vertex shaders this weekend.
>>>>>
>>>>> It would appear that attribs are broken. The most straight forward 
>>>>> way to test this it to compare progs/tests/arbvptest3 to 
>>>>> progs/tests/vptest3
>>>>>
>>>>> On my system I get different colors when I resize the window.
>>>>>
>>>>> Can someone confirm this? (it would explain why Doom 3 is broken)
>>>>
>>>> Yes, I have reported this some weeks ago:
>>>> http://marc.theaimsgroup.com/?l=dri-devel&m=114855685402158&w=2
>>>>
>>>
>>> Don't know how I fixed that...
>>>
>>> It would appear to be caused bu the reshuffling of the attribs.
>>>
>>> Any idea where the attribs are passed to the driver?
>>> and how to read the data in the attribs...
>>
>> I can't comment on the r300 driver, but the change in vertex aliasing 
>> in core Mesa is pretty simple.  It's really just a change of which 
>> index into the VB->Attribs[] array corresponds to 
>> glVertexAttribARB(index, ...).
> 
> I believe I have found the problem... the attributes weren't copied..
> 
> Patch attached.
> 
> 
> Rune Petersen