Re: [r300] r420 related changes

[Vladimir D. <vo...@mi...>]

On Fri, 4 Mar 2005, Michel [ISO-8859-1] D=E4nzer wrote:

> On Fri, 2005-03-04 at 01:50 +0100, Rune Petersen wrote:
>>
>>      if ( (info->ChipFamily =3D=3D CHIP_FAMILY_R300) ||
>>  =09 (info->ChipFamily =3D=3D CHIP_FAMILY_R350) ||
>> -=09 (info->ChipFamily =3D=3D CHIP_FAMILY_RV350) )
>> +=09 (info->ChipFamily =3D=3D CHIP_FAMILY_RV350) ||
>> +=09 (info->ChipFamily =3D=3D CHIP_FAMILY_R420) )
>>         drmInfo.func             =3D DRM_RADEON_INIT_R300_CP;
>>      else
>>      if ( info->ChipFamily >=3D CHIP_FAMILY_R200 )
>
> Why not just test for info->ChipFamily >=3D CHIP_FAMILY_R300 instead of
> for every R300 family explicitly? Otherwise, it looks like the R200
> microcode will be used, which is certainly wrong... Incidentally, I
> think the R300 check in RADEONDRIScreenInit() should be moved to the top
> as well, or the IGP and R200 checks will preempt it?

I was afraid that R300 microcode would not work for newer cards as my=20
understanding of it is somewhat limited. Do you think it would be safe to=
=20
load an older microcode to a newer card ?

Upon a closer look it appears that this part only affects the choice of=20
the microcode, so in a way, your suggestion would avoid loading the really=
=20
old Radeon microcode.

As for DRIScreenInit - I looked at the code again and its logic appears=20
correct to me, could you elaborate a bit where you would like the R300=20
check to appear ?

                      thank you !

                            Vladimir Dergachev

>
>
> --=20
> Earthling Michel D=C3=A4nzer      |     Debian (powerpc), X and DRI devel=
oper
> Libre software enthusiast    |   http://svcs.affero.net/rm.php?r=3Ddaenze=
r
>