From: Eaton, T. G <tho...@in...> - 2009-05-28 18:16:39
|
Added connector and encoder types for MIPI displays. Signed-off-by: Thomas G Eaton <tho...@in...> --- diff -uprN -X drm-2.6.orig/Documentation/dontdiff drm-2.6.orig/drivers/gpu/drm/drm_crtc.c drm-2.6/drivers/gpu/drm/drm_crtc.c --- drm-2.6.orig/drivers/gpu/drm/drm_crtc.c 2009-05-28 10:17:02.000000000 -0700 +++ drm-2.6/drivers/gpu/drm/drm_crtc.c 2009-05-28 10:24:49.000000000 -0700 @@ -146,6 +146,7 @@ static struct drm_conn_prop_enum_list dr { DRM_MODE_CONNECTOR_DisplayPort, "DisplayPort", 0 }, { DRM_MODE_CONNECTOR_HDMIA, "HDMI Type A", 0 }, { DRM_MODE_CONNECTOR_HDMIB, "HDMI Type B", 0 }, + { DRM_MODE_CONNECTOR_MIPI, "MIPI", 0 }, }; static struct drm_prop_enum_list drm_encoder_enum_list[] = @@ -154,6 +155,7 @@ static struct drm_prop_enum_list drm_enc { DRM_MODE_ENCODER_TMDS, "TMDS" }, { DRM_MODE_ENCODER_LVDS, "LVDS" }, { DRM_MODE_ENCODER_TVDAC, "TV" }, + { DRM_MODE_ENCODER_MIPI, "MIPI" }, }; char *drm_get_encoder_name(struct drm_encoder *encoder) diff -uprN -X drm-2.6.orig/Documentation/dontdiff drm-2.6.orig/include/drm/drm_mode.h drm-2.6/include/drm/drm_mode.h --- drm-2.6.orig/include/drm/drm_mode.h 2009-05-28 10:17:12.000000000 -0700 +++ drm-2.6/include/drm/drm_mode.h 2009-05-28 10:23:13.000000000 -0700 @@ -121,6 +121,7 @@ struct drm_mode_crtc { #define DRM_MODE_ENCODER_TMDS 2 #define DRM_MODE_ENCODER_LVDS 3 #define DRM_MODE_ENCODER_TVDAC 4 +#define DRM_MODE_ENCODER_MIPI 5 struct drm_mode_get_encoder { __u32 encoder_id; @@ -155,6 +156,7 @@ struct drm_mode_get_encoder { #define DRM_MODE_CONNECTOR_DisplayPort 10 #define DRM_MODE_CONNECTOR_HDMIA 11 #define DRM_MODE_CONNECTOR_HDMIB 12 +#define DRM_MODE_CONNECTOR_MIPI 13 struct drm_mode_get_connector { |
From: Daniel S. <da...@fo...> - 2009-05-29 01:30:46
|
On Thu, May 28, 2009 at 12:16:23PM -0600, Eaton, Thomas G wrote: > Added connector and encoder types for MIPI displays. > > Signed-off-by: Thomas G Eaton <tho...@in...> I wonder if this is all really necessary to present to userspace, or if MIPI/LVDS/et al should just fall under 'internally-connected panel'? Cheers, Daniel |
From: Eaton, T. G <tho...@in...> - 2009-05-29 15:25:13
|
Based on the descriptions of encoder and connector, MIPI has different hardware for both the encoder and the connector than LVDS. If it is unnecessary to present encoder and connector type information to userspace, then I agree that it could be simplified. However, with the current implementation, I think it would be misleading to refer to all internal panels as having the same encoder and connector types unless they did in fact share the same hardware encoders and connectors. Cheers, -Gideon -----Original Message----- From: Daniel Stone [mailto:da...@fo...] Sent: Thursday, May 28, 2009 6:25 PM To: Eaton, Thomas G Cc: dri...@li...; ai...@li...; lin...@vg... Subject: Re: [PATCH] drm: add connector and encoder types for MIPI displays On Thu, May 28, 2009 at 12:16:23PM -0600, Eaton, Thomas G wrote: > Added connector and encoder types for MIPI displays. > > Signed-off-by: Thomas G Eaton <tho...@in...> I wonder if this is all really necessary to present to userspace, or if MIPI/LVDS/et al should just fall under 'internally-connected panel'? Cheers, Daniel |