From: <bug...@fr...> - 2007-02-23 20:04:05
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #23 from ru...@me... 2007-02-23 12:03 ------- It looks pretty straight forward. in stead of doing the calculations in the vertex shader, pass the value straight to the fragment shader and calculate there. It will take some time, there isn't a framework for changes to the fragment program as there is for the vertex program. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-23 23:05:08
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #24 from z3r...@gm... 2007-02-23 15:05 ------- So the instructions that are added to the vertex program are correct, but because they are in the vertex program they generate some errors in the result? I guess the same kind of instruction insertion would work in the fragment program. There is already a mechanism to pass the number of the texcoord containing the data that's needed from the vertex program into the fragment program, so it shouldn't be too hard... I think. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-23 23:07:21
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #25 from z3r...@gm... 2007-02-23 15:07 ------- Oh, I see... The fragment program just sets the texcoord number for the vertex program to use. It doesn't really have the ability to insert instructions yet. Obviously that would have to be done first. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-24 17:38:59
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #26 from ru...@me... 2007-02-24 09:38 ------- Created an attachment (id=8837) --> (http://bugs.freedesktop.org/attachment.cgi?id=8837&action=view) wpos in FP hack I have managed to hack together a patch that works correctly for the test app I made. how does it look on your end? This is just a PoC. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-25 00:36:00
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #27 from z3r...@gm... 2007-02-24 16:35 ------- With that patch it seems that the fragment.position is just completely yellow when written to result.color, which isn't correct. It should be yellow fading into white. I guess this is a good start though, getting the position calculation into the fragprog. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-25 00:48:22
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #28 from ru...@me... 2007-02-24 16:48 ------- please attach a screenshot, I need to look at the RGB levels. if you could make it the same angle as in the blob rendering it would be easier. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-25 01:15:37
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #29 from z3r...@gm... 2007-02-24 17:15 ------- I think that first time when the fragment.position was completely yellow was just some freak R300 error, which does happen sometimes... I've seen a number of such errors on various things. Anyway, I've cleaned my Mesa tree and recompiled, and it does seem to get the white to yellow gradient now, however there are some problems. When looking from left to right you see the correct result (yellow to white), however when looking right to left you see the wrong result (yellow to white, too); it should be white to yellow. I'll attach some screenshots, that should make it clear. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-25 01:16:06
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #30 from z3r...@gm... 2007-02-24 17:16 ------- Created an attachment (id=8841) --> (http://bugs.freedesktop.org/attachment.cgi?id=8841&action=view) Looking from the left to the right -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-25 01:17:17
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #31 from z3r...@gm... 2007-02-24 17:17 ------- Created an attachment (id=8842) --> (http://bugs.freedesktop.org/attachment.cgi?id=8842&action=view) Looking from the right to the left -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-25 01:21:03
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #32 from z3r...@gm... 2007-02-24 17:20 ------- Created an attachment (id=8843) --> (http://bugs.freedesktop.org/attachment.cgi?id=8843&action=view) Rendering with R300 and the latest patch Here's a screenshot of the rendering with R300 and the latest patch. You can see it's not correct, but I think it's better than before. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-25 01:23:16
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #33 from z3r...@gm... 2007-02-24 17:23 ------- I found that tri-position does seem to generate completely yellow (no yellow to white gradient) though. If you like, I can make a screenshot of tri-position, too? -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-25 11:09:41
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #34 from ru...@me... 2007-02-25 03:09 ------- the gradients look right to me, fragment.position is camera. So Z should be the distance from the camera. and in your case should always result in yellow close to the camera, and white far from the camera. Of course I may be wrong again. Does the blob really render it differently? -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-25 14:19:27
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #35 from z3r...@gm... 2007-02-25 06:19 ------- You're correct about the left vs right color, I confirmed this with the blob, too. I'm not sure why this isn't rendering correctly with R300 then. It seems that it should be working... -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-26 19:50:13
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #37 from ru...@me... 2007-02-26 11:50 PST ------- I would still like you to confirm the X & Y values. Do something like: MUL result.color.xy, fragment.color.xy, {0.005}.x; If you could send me a screenshot from r300 & blog, so I can compare.... -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-27 03:35:24
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #38 from z3r...@gm... 2007-02-26 19:35 PST ------- I assume you mean "MUL result.color.xy, fragment.position.xy, {0.005}.x;" and not fragment.color. I'm testing with "MUL result.color.xy, fragment.position.xy, {0.005}.x;" now, and I'll post the attach the screenshots after I'm done. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-27 03:43:03
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #39 from z3r...@gm... 2007-02-26 19:42 PST ------- Created an attachment (id=8865) --> (http://bugs.freedesktop.org/attachment.cgi?id=8865&action=view) R300 fragment.position.xy I had to use "MUL result.color.xy, fragment.position, {0.005}.x;" for the program to successfully load (removed the .xy mask on fragment.position) but this shouldn't make a difference since result.color is masked for .xy anyway. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-27 03:53:51
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #40 from z3r...@gm... 2007-02-26 19:53 PST ------- Created an attachment (id=8866) --> (http://bugs.freedesktop.org/attachment.cgi?id=8866&action=view) Blob fragment.position.xy Ditto -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-27 03:59:53
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #41 from z3r...@gm... 2007-02-26 19:59 PST ------- I forgot to mention that the R300 screenshot is with your patch to calculate the WPOS in the fragment program. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-27 14:43:16
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #42 from ru...@me... 2007-02-27 06:43 PST ------- The transition is too narrow try: "MUL result.color.x, fragment.position, {0.0005}.x;" "MUL result.color.y, fragment.position, {0.001}.x;" Though I must say they look almost identical. Could it be that fragment.position is now correct, but there is a texturing bug? Is there a way for you to apply the texture in a similar way, but doesn't use fragment.position. It shouldn't look correct, I would just like to confirm if the texture is applied correctly. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-27 15:23:59
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #43 from z3r...@gm... 2007-02-27 07:23 PST ------- I'm also starting to think that fragment.position is now correct, but there is some other bug. I can get somewhat correct rendering with R300 now. It is not completely correct, there is some bug because it seems the mirror direction is reversed, or perhaps it's some other problem. I'll make a screenshot of the latest R300 rendering, and you can commit your latest patch. I think there might still be some work that needs to be done, but your patch certainly helps towards this goal -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-27 15:36:48
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #44 from z3r...@gm... 2007-02-27 07:36 PST ------- Created an attachment (id=8882) --> (http://bugs.freedesktop.org/attachment.cgi?id=8882&action=view) R300 fragment.position * 0.005 This is a screenshot of rendering with R300 with the following fragment program. Bugzilla will probably destroy up the formatting here, but it should still be readable. MUL tmp, fragment.position, {0.005}.x; TEX result.color, tmp, texture[0], 2D; Ignore the fact that this isn't scaled properly, that's not the point; the point is what you can see in the texture that is rendered. If you compare this to the blob screenshot which I will attach next, you can see the rendering is incorrect. I'm not exactly sure why yet. The blob screenshot is the correct one. Both screenshots are generated by exactly the same code. The only difference is the 3D driver. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-27 15:37:22
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #45 from z3r...@gm... 2007-02-27 07:37 PST ------- Created an attachment (id=8883) --> (http://bugs.freedesktop.org/attachment.cgi?id=8883&action=view) Blob fragment.position * 0.005 -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-27 15:39:36
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #46 from z3r...@gm... 2007-02-27 07:39 PST ------- Also, both screenshots have been taken from exactly the same position so that they can be compared easily. You can see that the R300 screenshot is very different when compared to the blob screenshot. I'm not sure what this means yet, but I suspect it's related to the incorrect rendering with R300. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-27 16:35:18
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #47 from ru...@me... 2007-02-27 08:35 PST ------- a hunch: in fragprog.c replace: fpi[i].SrcReg[1].File = PROGRAM_STATE_VAR; fpi[i].SrcReg[1].Index = window_index; fpi[i].SrcReg[1].Swizzle = MAKE_SWIZZLE4(SWIZZLE_X, SWIZZLE_Y, SWIZZLE_Z, SWIZZLE_ZERO); fpi[i].SrcReg[2].File = PROGRAM_STATE_VAR; fpi[i].SrcReg[2].Index = window_index; fpi[i].SrcReg[2].Swizzle = MAKE_SWIZZLE4(SWIZZLE_X, SWIZZLE_Y, SWIZZLE_Z, SWIZZLE_ZERO); with: fpi[i].SrcReg[1].File = PROGRAM_STATE_VAR; fpi[i].SrcReg[1].Index = window_index; fpi[i].SrcReg[1].Swizzle = MAKE_SWIZZLE4(SWIZZLE_Z, SWIZZLE_Z, SWIZZLE_Z, SWIZZLE_ZERO); fpi[i].SrcReg[2].File = PROGRAM_STATE_VAR; fpi[i].SrcReg[2].Index = window_index; fpi[i].SrcReg[2].Swizzle = MAKE_SWIZZLE4(SWIZZLE_Z, SWIZZLE_Z, SWIZZLE_Z, SWIZZLE_ZERO); A bit messy, I make a patch when I get home. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |
From: <bug...@fr...> - 2007-02-27 17:04:37
|
http://bugs.freedesktop.org/show_bug.cgi?id=10024 ------- Comment #48 from z3r...@gm... 2007-02-27 09:04 PST ------- I think that change made it worse; now it's mostly a grey blob, probably from the floor texture. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. |