From: <bla...@us...> - 2008-03-16 03:14:55
|
Revision: 7 http://drawbridge.svn.sourceforge.net/drawbridge/?rev=7&view=rev Author: blamonica Date: 2008-03-15 20:14:54 -0700 (Sat, 15 Mar 2008) Log Message: ----------- Completed unit test for the DatabaseDao. Completed unit test for the RunAsAccountDao. Removed db.properties and db.tmp artifacts from running an HSQLDB database (will add to svn:ignore with next commit) Modified Paths: -------------- trunk/drawbridge/src/java/net/sf/drawbridge/dao/drawbridge-dao-spring.xml trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/AbstractHibernateDao.java trunk/drawbridge/src/test/net/sf/drawbridge/dao/DatabaseDaoTest.java Added Paths: ----------- trunk/drawbridge/src/test/net/sf/drawbridge/dao/RunAsAccountDaoTest.java trunk/drawbridge/src/test/net/sf/drawbridge/test/ trunk/drawbridge/src/test/net/sf/drawbridge/test/TestBeanFactory.java Removed Paths: ------------- trunk/drawbridge/src/test/db.properties trunk/drawbridge/src/test/db.tmp/ Modified: trunk/drawbridge/src/java/net/sf/drawbridge/dao/drawbridge-dao-spring.xml =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/dao/drawbridge-dao-spring.xml 2008-03-15 02:43:02 UTC (rev 6) +++ trunk/drawbridge/src/java/net/sf/drawbridge/dao/drawbridge-dao-spring.xml 2008-03-16 03:14:54 UTC (rev 7) @@ -27,7 +27,12 @@ <property name="dataSource" ref="dataSource"/> </bean> - <bean id="DatabaseDao" class="net.sf.drawbridge.dao.hibernate.HibernateDatabaseDaoImpl"> + <bean id="AbstractDao" abstract="true"> <property name="sessionFactory" ref="SessionFactory"/> </bean> + + <bean id="DatabaseDao" parent="AbstractDao" class="net.sf.drawbridge.dao.hibernate.HibernateDatabaseDaoImpl"/> + + <bean id="RunAsAccountDao" parent="AbstractDao" class="net.sf.drawbridge.dao.hibernate.HibernateRunAsAccountDaoImpl"/> + </beans> Modified: trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/AbstractHibernateDao.java =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/AbstractHibernateDao.java 2008-03-15 02:43:02 UTC (rev 6) +++ trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/AbstractHibernateDao.java 2008-03-16 03:14:54 UTC (rev 7) @@ -36,7 +36,7 @@ public void update(T vo) { if (vo != null) { - getHibernateTemplate().save(vo); + getHibernateTemplate().update(vo); } } Deleted: trunk/drawbridge/src/test/db.properties =================================================================== --- trunk/drawbridge/src/test/db.properties 2008-03-15 02:43:02 UTC (rev 6) +++ trunk/drawbridge/src/test/db.properties 2008-03-16 03:14:54 UTC (rev 7) @@ -1,17 +0,0 @@ -#HSQL Database Engine 1.9.0.0 -#Thu Mar 13 21:44:50 CDT 2008 -hsqldb.script_format=0 -runtime.gc_interval=0 -sql.enforce_strict_size=false -hsqldb.cache_size_scale=8 -readonly=false -hsqldb.nio_data_file=true -hsqldb.cache_scale=15 -version=1.9.0 -hsqldb.default_table_type=memory -hsqldb.cache_file_scale=1 -hsqldb.log_size=200 -modified=yes -hsqldb.cache_version=1.7.0 -hsqldb.original_version=1.9.0 -hsqldb.compatible_version=1.9.0 Modified: trunk/drawbridge/src/test/net/sf/drawbridge/dao/DatabaseDaoTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/dao/DatabaseDaoTest.java 2008-03-15 02:43:02 UTC (rev 6) +++ trunk/drawbridge/src/test/net/sf/drawbridge/dao/DatabaseDaoTest.java 2008-03-16 03:14:54 UTC (rev 7) @@ -1,40 +1,26 @@ package net.sf.drawbridge.dao; -import javax.transaction.Transaction; +import java.util.List; import junit.framework.TestCase; -import net.sf.drawbridge.dao.DatabaseDao; +import net.sf.drawbridge.test.TestBeanFactory; import net.sf.drawbridge.vo.Database; -import org.springframework.beans.factory.BeanFactory; -import org.springframework.context.support.ClassPathXmlApplicationContext; -import org.springframework.jdbc.datasource.DataSourceTransactionManager; -import org.springframework.transaction.TransactionDefinition; import org.springframework.transaction.TransactionStatus; import org.springframework.transaction.support.AbstractPlatformTransactionManager; import org.springframework.transaction.support.DefaultTransactionDefinition; public class DatabaseDaoTest extends TestCase { - private static BeanFactory factory = new ClassPathXmlApplicationContext("drawbridge-test-spring.xml"); - private DatabaseDao target; private AbstractPlatformTransactionManager txManager; - private TransactionStatus tx = null; - protected void setUp() { - txManager = (AbstractPlatformTransactionManager) factory.getBean("TxManager"); - target = (DatabaseDao) factory.getBean("DatabaseDao"); + txManager = (AbstractPlatformTransactionManager) TestBeanFactory.getBean("TxManager"); + target = (DatabaseDao) TestBeanFactory.getBean("DatabaseDao"); } - protected void tearDown() { - if (tx != null) { - txManager.rollback(tx); - } - } - public void testShouldGetDatabaseObject() throws Exception { Database result = target.get(0); assertNotNull("result is null", result); @@ -56,4 +42,46 @@ txManager.rollback(tx); } } + + public void testShouldSaveChangesToDatabaseObject() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + Database existing = target.get(0); + existing.setName("a different name"); + target.update(existing); + + Database result = target.get(0); + assertEquals("a different name", result.getName()); + } finally { + txManager.rollback(tx); + } + } + + public void testShouldDeleteObjectFromDatabase() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + Database existing = target.get(0); + assertNotNull(existing); + target.delete(existing); + + assertNull("should be deleted", target.get(0)); + } finally { + txManager.rollback(tx); + } + } + + public void testShouldRetrieveAllObjectsFromDatabase() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + Database existing = target.get(0); + Database db = new Database(null, "temporary db", "jdbc:temp", existing.getDriver()); + target.create(db); + + List<Database> all = target.getAll(); + assertEquals(2, all.size()); + } finally { + txManager.rollback(tx); + } + + } } Added: trunk/drawbridge/src/test/net/sf/drawbridge/dao/RunAsAccountDaoTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/dao/RunAsAccountDaoTest.java (rev 0) +++ trunk/drawbridge/src/test/net/sf/drawbridge/dao/RunAsAccountDaoTest.java 2008-03-16 03:14:54 UTC (rev 7) @@ -0,0 +1,86 @@ +package net.sf.drawbridge.dao; + +import java.util.List; + +import junit.framework.TestCase; +import net.sf.drawbridge.test.TestBeanFactory; +import net.sf.drawbridge.vo.RunAsAccount; + +import org.springframework.transaction.TransactionStatus; +import org.springframework.transaction.support.AbstractPlatformTransactionManager; +import org.springframework.transaction.support.DefaultTransactionDefinition; + +public class RunAsAccountDaoTest extends TestCase { + + private RunAsAccountDao target; + + private AbstractPlatformTransactionManager txManager; + + protected void setUp() { + txManager = (AbstractPlatformTransactionManager) TestBeanFactory.getBean("TxManager"); + target = (RunAsAccountDao) TestBeanFactory.getBean("RunAsAccountDao"); + } + + public void testShouldGetRunAsAccountObject() throws Exception { + RunAsAccount result = target.get(0); + assertNotNull("result is null", result); + assertEquals("id", new Integer(0), result.getId()); + assertEquals("username", "sa", result.getUserName()); + assertEquals("password", "base64", result.getPassword()); + assertNotNull("database", result.getDatabase()); + } + + public void testShouldCreateNewRunAsAccountObject() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + RunAsAccount existing = target.get(0); + RunAsAccount db = new RunAsAccount(null, "temp_user", "temp_password", existing.getDatabase()); + target.create(db); + assertNotNull("id is still null", db.getId()); + } finally { + txManager.rollback(tx); + } + } + + public void testShouldSaveChangesToRunAsAccountObject() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + RunAsAccount existing = target.get(0); + existing.setUserName("a different username"); + target.update(existing); + + RunAsAccount result = target.get(0); + assertEquals("a different username", result.getUserName()); + } finally { + txManager.rollback(tx); + } + } + + public void testShouldDeleteObjectFromRunAsAccount() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + RunAsAccount existing = target.get(0); + assertNotNull(existing); + target.delete(existing); + + assertNull("should be deleted", target.get(0)); + } finally { + txManager.rollback(tx); + } + } + + public void testShouldRetrieveAllObjectsFromRunAsAccount() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + RunAsAccount existing = target.get(0); + RunAsAccount db = new RunAsAccount(null, "temp_user", "temp_password", existing.getDatabase()); + target.create(db); + + List<RunAsAccount> all = target.getAll(); + assertEquals(2, all.size()); + } finally { + txManager.rollback(tx); + } + + } +} Added: trunk/drawbridge/src/test/net/sf/drawbridge/test/TestBeanFactory.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/test/TestBeanFactory.java (rev 0) +++ trunk/drawbridge/src/test/net/sf/drawbridge/test/TestBeanFactory.java 2008-03-16 03:14:54 UTC (rev 7) @@ -0,0 +1,13 @@ +package net.sf.drawbridge.test; + +import org.springframework.beans.factory.BeanFactory; +import org.springframework.context.support.ClassPathXmlApplicationContext; + +public class TestBeanFactory { + + private static BeanFactory factory = new ClassPathXmlApplicationContext("drawbridge-test-spring.xml"); + + public static Object getBean(String beanName) { + return factory.getBean(beanName); + } +} This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <ac...@us...> - 2008-03-16 18:00:57
|
Revision: 10 http://drawbridge.svn.sourceforge.net/drawbridge/?rev=10&view=rev Author: acresse Date: 2008-03-16 11:00:51 -0700 (Sun, 16 Mar 2008) Log Message: ----------- remove unused maps from controllers and tests Modified Paths: -------------- trunk/drawbridge/src/java/net/sf/drawbridge/controller/MainMenuController.java trunk/drawbridge/src/java/net/sf/drawbridge/controller/database/ManageDatabasesController.java trunk/drawbridge/src/java/net/sf/drawbridge/controller/job/ManageJobsController.java trunk/drawbridge/src/java/net/sf/drawbridge/controller/runas/ManageRunAsController.java trunk/drawbridge/src/test/net/sf/drawbridge/controller/MainMenuControllerTest.java trunk/drawbridge/src/test/net/sf/drawbridge/controller/database/ManageDatabasesControllerTest.java trunk/drawbridge/src/test/net/sf/drawbridge/controller/job/ManagesJobControllerTest.java trunk/drawbridge/src/test/net/sf/drawbridge/controller/runas/ManageRunAsControllerTest.java Modified: trunk/drawbridge/src/java/net/sf/drawbridge/controller/MainMenuController.java =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/controller/MainMenuController.java 2008-03-16 17:05:12 UTC (rev 9) +++ trunk/drawbridge/src/java/net/sf/drawbridge/controller/MainMenuController.java 2008-03-16 18:00:51 UTC (rev 10) @@ -1,32 +1,16 @@ package net.sf.drawbridge.controller; -import java.util.HashMap; -import java.util.List; -import java.util.Map; - import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; -import net.sf.drawbridge.controller.AbstractDrawbridgeController; -import net.sf.drawbridge.vo.Driver; - import org.springframework.web.servlet.ModelAndView; public class MainMenuController extends AbstractDrawbridgeController { protected ModelAndView handleRequestInternal(HttpServletRequest request, HttpServletResponse response) throws Exception { ModelAndView mav = new ModelAndView("mainMenu"); - mav.addObject("driverMap", convertToMap(drawbridgeService.listDrivers())); mav.addObject("databaseList", drawbridgeService.listDatabases()); return mav; } - private Object convertToMap(List<Driver> drivers) { - Map<Integer, Driver> map=new HashMap<Integer, Driver>(); - for (Driver driver : drivers) { - map.put(driver.getId(), driver); - } - return map; - } - } Modified: trunk/drawbridge/src/java/net/sf/drawbridge/controller/database/ManageDatabasesController.java =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/controller/database/ManageDatabasesController.java 2008-03-16 17:05:12 UTC (rev 9) +++ trunk/drawbridge/src/java/net/sf/drawbridge/controller/database/ManageDatabasesController.java 2008-03-16 18:00:51 UTC (rev 10) @@ -1,14 +1,9 @@ package net.sf.drawbridge.controller.database; -import java.util.HashMap; -import java.util.List; -import java.util.Map; - import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import net.sf.drawbridge.controller.AbstractDrawbridgeController; -import net.sf.drawbridge.vo.Driver; import org.springframework.web.servlet.ModelAndView; @@ -16,17 +11,8 @@ protected ModelAndView handleRequestInternal(HttpServletRequest request, HttpServletResponse response) throws Exception { ModelAndView mav = new ModelAndView("database/manage"); - mav.addObject("driverMap", convertToMap(drawbridgeService.listDrivers())); mav.addObject("databaseList", drawbridgeService.listDatabases()); return mav; } - private Object convertToMap(List<Driver> drivers) { - Map<Integer, Driver> map=new HashMap<Integer, Driver>(); - for (Driver driver : drivers) { - map.put(driver.getId(), driver); - } - return map; - } - } Modified: trunk/drawbridge/src/java/net/sf/drawbridge/controller/job/ManageJobsController.java =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/controller/job/ManageJobsController.java 2008-03-16 17:05:12 UTC (rev 9) +++ trunk/drawbridge/src/java/net/sf/drawbridge/controller/job/ManageJobsController.java 2008-03-16 18:00:51 UTC (rev 10) @@ -1,14 +1,8 @@ package net.sf.drawbridge.controller.job; -import java.util.HashMap; -import java.util.List; -import java.util.Map; - import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; -import net.sf.drawbridge.vo.RunAsAccount; - import org.springframework.web.servlet.ModelAndView; public class ManageJobsController extends AbstractJobController { @@ -18,16 +12,8 @@ String databaseIdStr=getValueFromRequestOrSession("databaseId", request, false); Integer databaseId = new Integer(databaseIdStr); mav.addObject("databaseId",databaseIdStr); - mav.addObject("runAsMap", convertToMap(drawbridgeService.listRunAsAccounts(databaseId))); mav.addObject("jobList", drawbridgeService.listJobs(databaseId)); return mav; } - private Object convertToMap(List<RunAsAccount> runAsAccounts) { - Map<Integer, RunAsAccount> map=new HashMap<Integer, RunAsAccount>(); - for (RunAsAccount runAs : runAsAccounts) { - map.put(runAs.getId(), runAs); - } - return map; - } } Modified: trunk/drawbridge/src/java/net/sf/drawbridge/controller/runas/ManageRunAsController.java =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/controller/runas/ManageRunAsController.java 2008-03-16 17:05:12 UTC (rev 9) +++ trunk/drawbridge/src/java/net/sf/drawbridge/controller/runas/ManageRunAsController.java 2008-03-16 18:00:51 UTC (rev 10) @@ -1,14 +1,9 @@ package net.sf.drawbridge.controller.runas; -import java.util.HashMap; -import java.util.List; -import java.util.Map; - import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import net.sf.drawbridge.controller.AbstractDrawbridgeController; -import net.sf.drawbridge.vo.Database; import org.springframework.web.servlet.ModelAndView; @@ -17,16 +12,7 @@ protected ModelAndView handleRequestInternal(HttpServletRequest request, HttpServletResponse response) throws Exception { ModelAndView mav = new ModelAndView("runAs/manage"); mav.addObject("runAsList", drawbridgeService.listRunAsAccounts(null)); - mav.addObject("databaseMap", convertToMap(drawbridgeService.listDatabases())); return mav; } - private Object convertToMap(List<Database> databases) { - Map<Integer, Database> map=new HashMap<Integer, Database>(); - for (Database database : databases) { - map.put(database.getId(), database); - } - return map; - } - } Modified: trunk/drawbridge/src/test/net/sf/drawbridge/controller/MainMenuControllerTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/controller/MainMenuControllerTest.java 2008-03-16 17:05:12 UTC (rev 9) +++ trunk/drawbridge/src/test/net/sf/drawbridge/controller/MainMenuControllerTest.java 2008-03-16 18:00:51 UTC (rev 10) @@ -24,7 +24,7 @@ target.setDrawbridgeService((DrawbridgeService) mockDrawbridgeService.proxy()); } - public void testShouldReturnViewWithDatabasesAndDrivers() throws Exception{ + public void testShouldReturnViewWithDatabases() throws Exception{ List<Database> databaseList=new ArrayList<Database>(); Driver driver = new Driver(1,"name","class"); databaseList.add(new Database(1,"name","url",driver)); @@ -32,18 +32,13 @@ List<Driver> driverList=new ArrayList<Driver>(); driverList.add(driver); - Map<Integer, Driver> driverMap=new HashMap<Integer, Driver>(); - driverMap.put(1,driver); - mockDrawbridgeService.expects(once()).method("listDatabases").will(returnValue(databaseList)); - mockDrawbridgeService.expects(once()).method("listDrivers").will(returnValue(driverList)); ModelAndView mav=target.handleRequestInternal(null, null); assertEquals("mainMenu",mav.getViewName()); Map<String, Object> model=new HashMap<String, Object>(); model.put("databaseList", databaseList); - model.put("driverMap", driverMap); assertEquals(model,mav.getModel()); } Modified: trunk/drawbridge/src/test/net/sf/drawbridge/controller/database/ManageDatabasesControllerTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/controller/database/ManageDatabasesControllerTest.java 2008-03-16 17:05:12 UTC (rev 9) +++ trunk/drawbridge/src/test/net/sf/drawbridge/controller/database/ManageDatabasesControllerTest.java 2008-03-16 18:00:51 UTC (rev 10) @@ -24,7 +24,7 @@ target.setDrawbridgeService((DrawbridgeService) mockDrawbridgeService.proxy()); } - public void testShouldReturnViewWithDatabasesAndDrivers() throws Exception{ + public void testShouldReturnViewWithDatabases() throws Exception{ Driver driver = new Driver(1, "name", "class"); List<Database> databaseList=new ArrayList<Database>(); databaseList.add(new Database(1,"name","url",driver)); @@ -32,18 +32,13 @@ List<Driver> driverList=new ArrayList<Driver>(); driverList.add(driver); - Map<Integer, Driver> driverMap=new HashMap<Integer, Driver>(); - driverMap.put(1,driver); - mockDrawbridgeService.expects(once()).method("listDatabases").will(returnValue(databaseList)); - mockDrawbridgeService.expects(once()).method("listDrivers").will(returnValue(driverList)); ModelAndView mav=target.handleRequestInternal(null, null); assertEquals("database/manage",mav.getViewName()); Map<String,Object> model=new HashMap<String,Object>(); model.put("databaseList", databaseList); - model.put("driverMap", driverMap); assertEquals(model,mav.getModel()); } Modified: trunk/drawbridge/src/test/net/sf/drawbridge/controller/job/ManagesJobControllerTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/controller/job/ManagesJobControllerTest.java 2008-03-16 17:05:12 UTC (rev 9) +++ trunk/drawbridge/src/test/net/sf/drawbridge/controller/job/ManagesJobControllerTest.java 2008-03-16 18:00:51 UTC (rev 10) @@ -35,11 +35,7 @@ List<RunAsAccount> runAsList=new ArrayList<RunAsAccount>(); runAsList.add(runAsAccount); - Map<Integer, RunAsAccount> runAsMap=new HashMap<Integer, RunAsAccount>(); - runAsMap.put(1,runAsAccount); - mockDrawbridgeService.expects(once()).method("listJobs").will(returnValue(jobList)); - mockDrawbridgeService.expects(once()).method("listRunAsAccounts").will(returnValue(runAsList)); MockHttpServletRequest mockRequest=new MockHttpServletRequest(); mockRequest.setParameter("databaseId", "1"); @@ -50,7 +46,6 @@ Map<String,Object> model=new HashMap<String,Object>(); model.put("databaseId", "1"); model.put("jobList", jobList); - model.put("runAsMap", runAsMap); assertEquals(model,mav.getModel()); } Modified: trunk/drawbridge/src/test/net/sf/drawbridge/controller/runas/ManageRunAsControllerTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/controller/runas/ManageRunAsControllerTest.java 2008-03-16 17:05:12 UTC (rev 9) +++ trunk/drawbridge/src/test/net/sf/drawbridge/controller/runas/ManageRunAsControllerTest.java 2008-03-16 18:00:51 UTC (rev 10) @@ -25,7 +25,7 @@ target.setDrawbridgeService((DrawbridgeService) mockDrawbridgeService.proxy()); } - public void testShouldReturnViewWithRunAsAndDatabases() throws Exception{ + public void testShouldReturnViewWithRunAsAccounts() throws Exception{ List<RunAsAccount> runAsList=new ArrayList<RunAsAccount>(); Database db = new Database(1,"name","jdbcUrl", new Driver(1,"name","class")); runAsList.add(new RunAsAccount(1,"userName","password",db)); @@ -33,18 +33,13 @@ List<Database> databaseList=new ArrayList<Database>(); databaseList.add(db); - Map<Integer, Database> databaseMap=new HashMap<Integer, Database>(); - databaseMap.put(1,db); - mockDrawbridgeService.expects(once()).method("listRunAsAccounts").will(returnValue(runAsList)); - mockDrawbridgeService.expects(once()).method("listDatabases").will(returnValue(databaseList)); ModelAndView mav=target.handleRequestInternal(null, null); assertEquals("runAs/manage",mav.getViewName()); Map<String,Object> model=new HashMap<String,Object>(); model.put("runAsList", runAsList); - model.put("databaseMap", databaseMap); assertEquals(model,mav.getModel()); } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <bla...@us...> - 2008-03-18 02:15:48
|
Revision: 13 http://drawbridge.svn.sourceforge.net/drawbridge/?rev=13&view=rev Author: blamonica Date: 2008-03-17 19:15:46 -0700 (Mon, 17 Mar 2008) Log Message: ----------- Put all DAOs into spring. Using the DefaultDrawbridgeService now. Wrote an test of the HibernateDriverDao. Modified Paths: -------------- trunk/drawbridge/src/java/drawbridge-core-spring.xml trunk/drawbridge/src/java/net/sf/drawbridge/dao/drawbridge-dao-spring.xml trunk/drawbridge/src/java/net/sf/drawbridge/domain/DefaultDrawbridgeService.java Added Paths: ----------- trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/HibernateDriverDaoImpl.java trunk/drawbridge/src/test/net/sf/drawbridge/dao/DriverDaoTest.java Modified: trunk/drawbridge/src/java/drawbridge-core-spring.xml =================================================================== --- trunk/drawbridge/src/java/drawbridge-core-spring.xml 2008-03-18 01:24:24 UTC (rev 12) +++ trunk/drawbridge/src/java/drawbridge-core-spring.xml 2008-03-18 02:15:46 UTC (rev 13) @@ -4,11 +4,24 @@ <beans> <import resource="net/sf/drawbridge/dao/drawbridge-dao-spring.xml"/> + <!-- <bean id="drawbridgeService" class="net.sf.drawbridge.domain.DummyDrawbridgeService"> <constructor-arg ref="queryParser"/> <constructor-arg ref="jobExecuter"/> </bean> - + --> + + <bean id="drawbridgeService" class="net.sf.drawbridge.domain.DefaultDrawbridgeService"> + <constructor-arg ref="UserDao"/> + <constructor-arg ref="GroupDao"/> + <constructor-arg ref="RunAsAccountDao"/> + <constructor-arg ref="DatabaseDao"/> + <constructor-arg ref="JobDao"/> + <constructor-arg ref="DriverDao"/> + <constructor-arg ref="QueryParser"/> + <constructor-arg ref="JobExecuter"/> + </bean> + <bean id="dummyDatabase" class="net.sf.drawbridge.domain.DummyDatabase"> <property name="dataSource"> <bean class="org.springframework.jdbc.datasource.SingleConnectionDataSource"> @@ -33,9 +46,9 @@ <constructor-arg ref="scheduler"/> </bean> - <bean id="queryParser" class="net.sf.drawbridge.exec.DefaultQueryParser"/> + <bean id="QueryParser" class="net.sf.drawbridge.exec.DefaultQueryParser"/> - <bean id="jobExecuter" class="net.sf.drawbridge.exec.DefaultJobExecuter"/> + <bean id="JobExecuter" class="net.sf.drawbridge.exec.DefaultJobExecuter"/> <bean id="encryptionUtil" class="net.sf.drawbridge.util.AESEncryptionUtil"> <constructor-arg value="1234567890abcdef"/> Modified: trunk/drawbridge/src/java/net/sf/drawbridge/dao/drawbridge-dao-spring.xml =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/dao/drawbridge-dao-spring.xml 2008-03-18 01:24:24 UTC (rev 12) +++ trunk/drawbridge/src/java/net/sf/drawbridge/dao/drawbridge-dao-spring.xml 2008-03-18 02:15:46 UTC (rev 13) @@ -34,5 +34,13 @@ <bean id="DatabaseDao" parent="AbstractDao" class="net.sf.drawbridge.dao.hibernate.HibernateDatabaseDaoImpl"/> <bean id="RunAsAccountDao" parent="AbstractDao" class="net.sf.drawbridge.dao.hibernate.HibernateRunAsAccountDaoImpl"/> + + <bean id="JobDao" parent="AbstractDao" class="net.sf.drawbridge.dao.hibernate.HibernateJobDaoImpl"/> + + <bean id="UserDao" parent="AbstractDao" class="net.sf.drawbridge.dao.hibernate.HibernateUserDaoImpl"/> + + <bean id="GroupDao" parent="AbstractDao" class="net.sf.drawbridge.dao.hibernate.HibernateGroupDaoImpl"/> + + <bean id="DriverDao" parent="AbstractDao" class="net.sf.drawbridge.dao.hibernate.HibernateDriverDaoImpl"/> </beans> Added: trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/HibernateDriverDaoImpl.java =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/HibernateDriverDaoImpl.java (rev 0) +++ trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/HibernateDriverDaoImpl.java 2008-03-18 02:15:46 UTC (rev 13) @@ -0,0 +1,29 @@ +/* + * This file is part of DrawBridge. + * Copyright 2008 Ben La Monica + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation,Inc.,51 Franklin Street,Fifth Floor, Boston, MA 02110-1301, USA. + */ +package net.sf.drawbridge.dao.hibernate; + +import net.sf.drawbridge.dao.DriverDao; +import net.sf.drawbridge.vo.Driver; + +public class HibernateDriverDaoImpl extends AbstractHibernateDao<Driver, Integer> implements DriverDao { + + public HibernateDriverDaoImpl() { + super(Driver.class); + } + +} Modified: trunk/drawbridge/src/java/net/sf/drawbridge/domain/DefaultDrawbridgeService.java =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/domain/DefaultDrawbridgeService.java 2008-03-18 01:24:24 UTC (rev 12) +++ trunk/drawbridge/src/java/net/sf/drawbridge/domain/DefaultDrawbridgeService.java 2008-03-18 02:15:46 UTC (rev 13) @@ -40,36 +40,43 @@ public class DefaultDrawbridgeService implements DrawbridgeService { - private UserDao userDao; - - private GroupDao groupDao; - - private RunAsAccountDao runAsAccountDao; - - private DatabaseDao databaseDao; - - private JobDao jobDao; - - private DriverDao driverDao; - - private QueryParser parser; + private final UserDao userDao; - private JobExecuter executer; - - public DefaultDrawbridgeService(UserDao userDao, GroupDao groupDao, RunAsAccountDao runAsAccountDao) { + private final GroupDao groupDao; + + private final RunAsAccountDao runAsAccountDao; + + private final DatabaseDao databaseDao; + + private final JobDao jobDao; + + private final DriverDao driverDao; + + private final QueryParser parser; + + private final JobExecuter executer; + + public DefaultDrawbridgeService(UserDao userDao, GroupDao groupDao, RunAsAccountDao runAsAccountDao, + DatabaseDao databaseDao, JobDao jobDao, DriverDao driverDao, QueryParser queryParser, + JobExecuter jobExecuter) { this.userDao = userDao; this.groupDao = groupDao; this.runAsAccountDao = runAsAccountDao; + this.databaseDao = databaseDao; + this.jobDao = jobDao; + this.driverDao = driverDao; + this.parser = queryParser; + this.executer = jobExecuter; } - + private void setJobActive(Long jobId, boolean isActive) { Job job = jobDao.get(jobId); if (job != null) { - job.setActive(isActive?"Y":"N"); + job.setActive(isActive ? "Y" : "N"); jobDao.update(job); } } - + public void activateJob(Long jobId) { setJobActive(jobId, true); } @@ -161,13 +168,14 @@ } public List<Map<String, Object>> executeJob(Long jobId, List<QueryParam> params) { - try{ - Job job=getJob(jobId); - RunAsAccount runAsAccount=job.getRunAsAccount(); - Database database=runAsAccount.getDatabase(); - Driver driver=database.getDriver(); - return executer.executeJob(driver, database, runAsAccount, parser.getPreparedStatementQuery(job.getQuery()), params); - } catch(Exception ex){ + try { + Job job = getJob(jobId); + RunAsAccount runAsAccount = job.getRunAsAccount(); + Database database = runAsAccount.getDatabase(); + Driver driver = database.getDriver(); + return executer.executeJob(driver, database, runAsAccount, + parser.getPreparedStatementQuery(job.getQuery()), params); + } catch (Exception ex) { ex.printStackTrace(); return null; } @@ -218,7 +226,7 @@ return jobDao.getJobsForDatabase(databaseId); } - //null parameter means return all + // null parameter means return all public List<RunAsAccount> listRunAsAccounts(Integer databaseId) { if (databaseId == null) { return runAsAccountDao.getAll(); Added: trunk/drawbridge/src/test/net/sf/drawbridge/dao/DriverDaoTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/dao/DriverDaoTest.java (rev 0) +++ trunk/drawbridge/src/test/net/sf/drawbridge/dao/DriverDaoTest.java 2008-03-18 02:15:46 UTC (rev 13) @@ -0,0 +1,100 @@ +/* + * This file is part of DrawBridge. + * Copyright 2008 Ben La Monica + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation,Inc.,51 Franklin Street,Fifth Floor, Boston, MA 02110-1301, USA. + */ +package net.sf.drawbridge.dao; + +import java.util.List; + +import junit.framework.TestCase; +import net.sf.drawbridge.test.TestBeanFactory; +import net.sf.drawbridge.vo.Driver; + +import org.springframework.transaction.TransactionStatus; +import org.springframework.transaction.support.AbstractPlatformTransactionManager; +import org.springframework.transaction.support.DefaultTransactionDefinition; + +public class DriverDaoTest extends TestCase { + + private DriverDao target; + + private AbstractPlatformTransactionManager txManager; + + protected void setUp() { + txManager = (AbstractPlatformTransactionManager) TestBeanFactory.getBean("TxManager"); + target = (DriverDao) TestBeanFactory.getBean("DriverDao"); + } + + public void testShouldGetDriverObject() throws Exception { + Driver result = target.get(0); + assertNotNull("result is null", result); + assertEquals("id", new Integer(0), result.getId()); + assertEquals("class name", "org.hsqldb.jdbcDriver", result.getClassName()); + assertEquals("name", "HSQLDB Driver", result.getName()); + } + + public void testShouldCreateNewDriverObject() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + Driver db = new Driver(null, "name", "class_name"); + target.create(db); + assertNotNull("id is still null", db.getId()); + } finally { + txManager.rollback(tx); + } + } + + public void testShouldSaveChangesToDriverObject() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + Driver existing = target.get(0); + existing.setName("a different name"); + target.update(existing); + + Driver result = target.get(0); + assertEquals("a different name", result.getName()); + } finally { + txManager.rollback(tx); + } + } + + public void testShouldDeleteObjectFromDriver() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + Driver existing = target.get(0); + assertNotNull(existing); + target.delete(existing); + + assertNull("should be deleted", target.get(0)); + } finally { + txManager.rollback(tx); + } + } + + public void testShouldRetrieveAllObjectsFromDriver() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + Driver db = new Driver(null, "name", "class_name"); + target.create(db); + + List<Driver> all = target.getAll(); + assertEquals(2, all.size()); + } finally { + txManager.rollback(tx); + } + + } +} This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <bla...@us...> - 2008-03-20 01:57:51
|
Revision: 19 http://drawbridge.svn.sourceforge.net/drawbridge/?rev=19&view=rev Author: blamonica Date: 2008-03-19 18:57:45 -0700 (Wed, 19 Mar 2008) Log Message: ----------- * Added JobDao Test * Added GroupDao test * Fixed Users and Groups not playing nicely. Updated Drawbridge to use Timestamps for the approval/submitted times instead of Dates. * Fixed getting a list of jobs using the databaseId (BUG Modified Paths: -------------- trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/HibernateGroupDaoImpl.java trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/HibernateJobDaoImpl.java trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/Group.hbm.xml trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/Job.hbm.xml trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/User.hbm.xml trunk/drawbridge/src/java/net/sf/drawbridge/vo/Group.java trunk/drawbridge/src/sql/create_drawbridge_schema.sql trunk/drawbridge/src/test/db.script trunk/drawbridge/src/test/net/sf/drawbridge/dao/DriverDaoTest.java trunk/drawbridge/src/test/net/sf/drawbridge/dao/RunAsAccountDaoTest.java Added Paths: ----------- trunk/drawbridge/src/test/net/sf/drawbridge/dao/GroupDaoTest.java trunk/drawbridge/src/test/net/sf/drawbridge/dao/JobDaoTest.java Modified: trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/HibernateGroupDaoImpl.java =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/HibernateGroupDaoImpl.java 2008-03-19 01:42:39 UTC (rev 18) +++ trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/HibernateGroupDaoImpl.java 2008-03-20 01:57:45 UTC (rev 19) @@ -17,8 +17,6 @@ */ package net.sf.drawbridge.dao.hibernate; -import java.util.List; - import net.sf.drawbridge.dao.GroupDao; import net.sf.drawbridge.vo.Group; Modified: trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/HibernateJobDaoImpl.java =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/HibernateJobDaoImpl.java 2008-03-19 01:42:39 UTC (rev 18) +++ trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/HibernateJobDaoImpl.java 2008-03-20 01:57:45 UTC (rev 19) @@ -35,7 +35,8 @@ @SuppressWarnings("unchecked") public List<Job> getJobsForDatabase(Integer databaseId) { DetachedCriteria criteria = DetachedCriteria.forClass(voClass); - criteria.add(Expression.eq("database.id", databaseId)); + criteria.createAlias("runAsAccount.database", "db"); + criteria.add(Expression.eq("db.id", databaseId)); criteria.addOrder(Order.asc("name")); return getHibernateTemplate().findByCriteria(criteria); } Modified: trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/Group.hbm.xml =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/Group.hbm.xml 2008-03-19 01:42:39 UTC (rev 18) +++ trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/Group.hbm.xml 2008-03-20 01:57:45 UTC (rev 19) @@ -11,9 +11,9 @@ <column name="GROUP_NAME"/> </property> - <set name="users" table="DB_USER_GROUP" fetch="join" inverse="true" lazy="false"> + <set name="users" table="DB_USER_GROUP" inverse="true" lazy="false"> <key column="GROUP_ID"/> - <many-to-many class="net.sf.drawbridge.vo.User" column="USER_ID"/> + <many-to-many class="net.sf.drawbridge.vo.User" unique="true" column="USER_ID"/> </set> </class> </hibernate-mapping> \ No newline at end of file Modified: trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/Job.hbm.xml =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/Job.hbm.xml 2008-03-19 01:42:39 UTC (rev 18) +++ trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/Job.hbm.xml 2008-03-20 01:57:45 UTC (rev 19) @@ -18,6 +18,10 @@ lazy="false" /> + <property name="query" type="string" length="1024" not-null="true"> + <column name="QUERY"/> + </property> + <many-to-one name="submittedBy" not-null="true" column="SUBMITTED_BY" class="net.sf.drawbridge.vo.User" @@ -25,7 +29,7 @@ lazy="false" /> - <property name="submittedOn" type="calendar_date" not-null="true"> + <property name="submittedOn" type="calendar" not-null="true"> <column name="SUBMITTED_ON"/> </property> @@ -36,7 +40,7 @@ lazy="false" /> - <property name="reviewedOn" type="calendar_date"> + <property name="reviewedOn" type="calendar"> <column name="REVIEWED_ON"/> </property> @@ -47,7 +51,7 @@ lazy="false" /> - <property name="approvedOn" type="calendar_date"> + <property name="approvedOn" type="calendar"> <column name="APPROVED_ON"/> </property> Modified: trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/User.hbm.xml =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/User.hbm.xml 2008-03-19 01:42:39 UTC (rev 18) +++ trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/User.hbm.xml 2008-03-20 01:57:45 UTC (rev 19) @@ -23,7 +23,7 @@ <column name="ACTIVE"/> </property> - <set name="groups" table="DB_USER_GROUP" fetch="join" lazy="false"> + <set name="groups" table="DB_USER_GROUP" lazy="false"> <key column="USER_ID"/> <many-to-many class="net.sf.drawbridge.vo.Group" column="GROUP_ID"/> </set> Modified: trunk/drawbridge/src/java/net/sf/drawbridge/vo/Group.java =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/vo/Group.java 2008-03-19 01:42:39 UTC (rev 18) +++ trunk/drawbridge/src/java/net/sf/drawbridge/vo/Group.java 2008-03-20 01:57:45 UTC (rev 19) @@ -60,9 +60,8 @@ @Override public int hashCode() { final int prime = 31; - int result = 1; + int result = super.hashCode(); result = prime * result + ((groupName == null) ? 0 : groupName.hashCode()); - result = prime * result + ((users == null) ? 0 : users.hashCode()); return result; } @@ -70,7 +69,7 @@ public boolean equals(Object obj) { if (this == obj) return true; - if (obj == null) + if (!super.equals(obj)) return false; if (getClass() != obj.getClass()) return false; @@ -80,11 +79,6 @@ return false; } else if (!groupName.equals(other.groupName)) return false; - if (users == null) { - if (other.users != null) - return false; - } else if (!users.equals(other.users)) - return false; return true; } Modified: trunk/drawbridge/src/sql/create_drawbridge_schema.sql =================================================================== --- trunk/drawbridge/src/sql/create_drawbridge_schema.sql 2008-03-19 01:42:39 UTC (rev 18) +++ trunk/drawbridge/src/sql/create_drawbridge_schema.sql 2008-03-20 01:57:45 UTC (rev 19) @@ -69,11 +69,11 @@ run_as_id INTEGER NOT NULL, query varchar(1024) NOT NULL, submitted_by INTEGER NOT NULL, - submitted_on DATE NOT NULL, + submitted_on TIMESTAMP NOT NULL, reviewed_by INTEGER, - reviewed_on DATE, + reviewed_on TIMESTAMP, approved_by INTEGER, - approved_on DATE, + approved_on TIMESTAMP, active varchar(1) NOT NULL, schedule varchar(128), PRIMARY KEY (id), Modified: trunk/drawbridge/src/test/db.script =================================================================== --- trunk/drawbridge/src/test/db.script 2008-03-19 01:42:39 UTC (rev 18) +++ trunk/drawbridge/src/test/db.script 2008-03-20 01:57:45 UTC (rev 19) @@ -1,24 +1,26 @@ +CREATE USER SA PASSWORD "" CREATE SCHEMA PUBLIC AUTHORIZATION DBA +SET SCHEMA PUBLIC CREATE MEMORY TABLE DB_USER(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 2) NOT NULL PRIMARY KEY,USER_NAME VARCHAR(16) NOT NULL,FIRST_NAME VARCHAR(32) NOT NULL,LAST_NAME VARCHAR(32) NOT NULL,ACTIVE VARCHAR(1) DEFAULT 'Y' NOT NULL,CONSTRAINT UNQ_DB_USER UNIQUE(USER_NAME)) CREATE MEMORY TABLE DB_GROUP(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 3) NOT NULL PRIMARY KEY,GROUP_NAME VARCHAR(16) NOT NULL,CONSTRAINT UNQ_DB_GROUP UNIQUE(GROUP_NAME)) -CREATE MEMORY TABLE DB_USER_GROUP(USER_ID INTEGER NOT NULL,GROUP_ID INTEGER NOT NULL,PRIMARY KEY(USER_ID,GROUP_ID),CONSTRAINT FK_DB_USER_GROUP_DB_USER FOREIGN KEY(USER_ID) REFERENCES DB_USER(ID) ON DELETE CASCADE ON UPDATE CASCADE,CONSTRAINT FK_DB_USER_GROUP_DB_GROUP FOREIGN KEY(GROUP_ID) REFERENCES DB_GROUP(ID) ON DELETE CASCADE ON UPDATE CASCADE) +CREATE MEMORY TABLE DB_USER_GROUP(USER_ID INTEGER NOT NULL,GROUP_ID INTEGER NOT NULL,PRIMARY KEY(USER_ID,GROUP_ID),CONSTRAINT FK_DB_USER_GROUP_DB_USER FOREIGN KEY(USER_ID) REFERENCES PUBLIC.DB_USER(ID) ON DELETE CASCADE ON UPDATE CASCADE,CONSTRAINT FK_DB_USER_GROUP_DB_GROUP FOREIGN KEY(GROUP_ID) REFERENCES PUBLIC.DB_GROUP(ID) ON DELETE CASCADE ON UPDATE CASCADE) CREATE MEMORY TABLE DB_DRIVER(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 1) NOT NULL PRIMARY KEY,NAME VARCHAR(32) NOT NULL,CLASS_NAME VARCHAR(128) NOT NULL,CONSTRAINT UNQ_DB_DRIVER UNIQUE(NAME)) -CREATE MEMORY TABLE DB_DATABASE(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 1) NOT NULL PRIMARY KEY,NAME VARCHAR(32) NOT NULL,JDBC_URL VARCHAR(128) NOT NULL,DRIVER_ID INTEGER NOT NULL,CONSTRAINT FK_DB_DATABASE_DB_DRIVER FOREIGN KEY(DRIVER_ID) REFERENCES DB_DRIVER(ID),CONSTRAINT UNQ_DB_DATABASE UNIQUE(NAME)) -CREATE MEMORY TABLE DB_RUN_AS(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 1) NOT NULL PRIMARY KEY,USER_NAME VARCHAR(16) NOT NULL,ENC_PASSWORD VARCHAR(32) NOT NULL,DATABASE_ID INTEGER NOT NULL,CONSTRAINT FK_DB_RUN_AS_DB_DATABASE FOREIGN KEY(DATABASE_ID) REFERENCES DB_DATABASE(ID),CONSTRAINT UNQ_DB_RUN_AS UNIQUE(USER_NAME,DATABASE_ID)) -CREATE MEMORY TABLE DB_JOB(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 0) NOT NULL PRIMARY KEY,NAME VARCHAR(64) NOT NULL,RUN_AS_ID INTEGER NOT NULL,SUBMITTED_BY INTEGER NOT NULL,SUBMITTED_ON DATE NOT NULL,REVIEWED_BY INTEGER,REVIEWED_ON DATE,APPROVED_BY INTEGER,APPROVED_ON DATE,ACTIVE VARCHAR(1) NOT NULL,SCHEDULE VARCHAR(128),CONSTRAINT FK_DB_JOB_DB_RUN_AS FOREIGN KEY(RUN_AS_ID) REFERENCES DB_RUN_AS(ID),CONSTRAINT FK_DB_JOB_SUBMITTED_BY FOREIGN KEY(SUBMITTED_BY) REFERENCES DB_USER(ID),CONSTRAINT FK_DB_JOB_REVIEWED_BY FOREIGN KEY(REVIEWED_BY) REFERENCES DB_USER(ID),CONSTRAINT FK_DB_JOB_APPROVED_BY FOREIGN KEY(APPROVED_BY) REFERENCES DB_USER(ID),CONSTRAINT UNQ_DB_JOB UNIQUE(NAME),CONSTRAINT CHK_DB_JOB_ACTIVE CHECK(DB_JOB.ACTIVE IN ('Y','N'))) -CREATE MEMORY TABLE DB_PERMISSION_LIST(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 30) NOT NULL PRIMARY KEY,NAME VARCHAR(64) NOT NULL,PERMISSION_TYPE VARCHAR(1) NOT NULL,CONSTRAINT UNQ_DB_PERMISSION UNIQUE(NAME,PERMISSION_TYPE),CONSTRAINT CHK_DB_PERMISSION_LIST_PERMISSION_TYPE CHECK(DB_PERMISSION_LIST.PERMISSION_TYPE IN ('S','D','R'))) -CREATE MEMORY TABLE DB_SYSTEM_PERMISSION(GROUP_ID INTEGER NOT NULL,PERMISSION_ID INTEGER NOT NULL,PRIMARY KEY(GROUP_ID,PERMISSION_ID),CONSTRAINT FK_DB_SYSTEM_PERMISSION_DB_GROUP FOREIGN KEY(GROUP_ID) REFERENCES DB_GROUP(ID) ON DELETE CASCADE ON UPDATE CASCADE,CONSTRAINT FK_DB_SYSTEM_PERMISSION_DB_PERMISSION_LIST FOREIGN KEY(PERMISSION_ID) REFERENCES DB_PERMISSION_LIST(ID) ON DELETE CASCADE ON UPDATE CASCADE) -CREATE MEMORY TABLE DB_DATABASE_PERMISSION(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 0) NOT NULL PRIMARY KEY,GROUP_ID INTEGER NOT NULL,DATABASE_ID INTEGER NOT NULL,PERMISSION_ID INTEGER NOT NULL,CONSTRAINT FK_DB_DATABASE_PERMISSION_DB_GROUP FOREIGN KEY(GROUP_ID) REFERENCES DB_GROUP(ID) ON DELETE CASCADE ON UPDATE CASCADE,CONSTRAINT FK_DB_DATABASE_PERMISSION_DB_DATABASE FOREIGN KEY(DATABASE_ID) REFERENCES DB_DATABASE(ID) ON DELETE CASCADE ON UPDATE CASCADE,CONSTRAINT FK_DB_DATABASE_PERMISSION_DB_PERMISSION_LIST FOREIGN KEY(PERMISSION_ID) REFERENCES DB_PERMISSION_LIST(ID) ON DELETE CASCADE ON UPDATE CASCADE,CONSTRAINT UNQ_DB_GRAP UNIQUE(GROUP_ID,DATABASE_ID,PERMISSION_ID)) -CREATE MEMORY TABLE DB_RUN_AS_PERMISSION(GROUP_ID INTEGER NOT NULL,RUN_AS_ID INTEGER NOT NULL,PERMISSION_ID INTEGER NOT NULL,PRIMARY KEY(GROUP_ID,RUN_AS_ID,PERMISSION_ID),CONSTRAINT FK_DB_RUN_AS_PERMISSION_DB_GROUP FOREIGN KEY(GROUP_ID) REFERENCES DB_GROUP(ID) ON DELETE CASCADE ON UPDATE CASCADE,CONSTRAINT FK_DB_RUN_AS_PERMISSION_DB_RUN_AS FOREIGN KEY(RUN_AS_ID) REFERENCES DB_RUN_AS(ID) ON DELETE CASCADE ON UPDATE CASCADE,CONSTRAINT FK_DB_RUN_AS_PERMISSION_DB_PERMISSION_LIST FOREIGN KEY(PERMISSION_ID) REFERENCES DB_PERMISSION_LIST(ID) ON DELETE CASCADE ON UPDATE CASCADE) +CREATE MEMORY TABLE DB_DATABASE(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 1) NOT NULL PRIMARY KEY,NAME VARCHAR(32) NOT NULL,JDBC_URL VARCHAR(128) NOT NULL,DRIVER_ID INTEGER NOT NULL,CONSTRAINT FK_DB_DATABASE_DB_DRIVER FOREIGN KEY(DRIVER_ID) REFERENCES PUBLIC.DB_DRIVER(ID),CONSTRAINT UNQ_DB_DATABASE UNIQUE(NAME)) +CREATE MEMORY TABLE DB_RUN_AS(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 1) NOT NULL PRIMARY KEY,USER_NAME VARCHAR(16) NOT NULL,ENC_PASSWORD VARCHAR(32) NOT NULL,DATABASE_ID INTEGER NOT NULL,CONSTRAINT FK_DB_RUN_AS_DB_DATABASE FOREIGN KEY(DATABASE_ID) REFERENCES PUBLIC.DB_DATABASE(ID),CONSTRAINT UNQ_DB_RUN_AS UNIQUE(USER_NAME,DATABASE_ID)) +CREATE MEMORY TABLE DB_JOB(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 2) NOT NULL PRIMARY KEY,NAME VARCHAR(64) NOT NULL,RUN_AS_ID INTEGER NOT NULL,QUERY VARCHAR(1024) NOT NULL,SUBMITTED_BY INTEGER NOT NULL,SUBMITTED_ON TIMESTAMP NOT NULL,REVIEWED_BY INTEGER,REVIEWED_ON TIMESTAMP,APPROVED_BY INTEGER,APPROVED_ON TIMESTAMP,ACTIVE VARCHAR(1) NOT NULL,SCHEDULE VARCHAR(128),CONSTRAINT FK_DB_JOB_DB_RUN_AS FOREIGN KEY(RUN_AS_ID) REFERENCES PUBLIC.DB_RUN_AS(ID),CONSTRAINT FK_DB_JOB_SUBMITTED_BY FOREIGN KEY(SUBMITTED_BY) REFERENCES PUBLIC.DB_USER(ID),CONSTRAINT FK_DB_JOB_REVIEWED_BY FOREIGN KEY(REVIEWED_BY) REFERENCES PUBLIC.DB_USER(ID),CONSTRAINT FK_DB_JOB_APPROVED_BY FOREIGN KEY(APPROVED_BY) REFERENCES PUBLIC.DB_USER(ID),CONSTRAINT UNQ_DB_JOB UNIQUE(NAME),CONSTRAINT CHK_DB_JOB_ACTIVE CHECK((DB_JOB.ACTIVE) IN (('Y'),('N')))) +CREATE MEMORY TABLE DB_PERMISSION_LIST(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 30) NOT NULL PRIMARY KEY,NAME VARCHAR(64) NOT NULL,PERMISSION_TYPE VARCHAR(1) NOT NULL,CONSTRAINT UNQ_DB_PERMISSION UNIQUE(NAME,PERMISSION_TYPE),CONSTRAINT CHK_DB_PERMISSION_LIST_PERMISSION_TYPE CHECK((DB_PERMISSION_LIST.PERMISSION_TYPE) IN (('S'),('D'),('R')))) +CREATE MEMORY TABLE DB_SYSTEM_PERMISSION(GROUP_ID INTEGER NOT NULL,PERMISSION_ID INTEGER NOT NULL,PRIMARY KEY(GROUP_ID,PERMISSION_ID),CONSTRAINT FK_DB_SYSTEM_PERMISSION_DB_GROUP FOREIGN KEY(GROUP_ID) REFERENCES PUBLIC.DB_GROUP(ID) ON DELETE CASCADE ON UPDATE CASCADE,CONSTRAINT FK_DB_SYSTEM_PERMISSION_DB_PERMISSION_LIST FOREIGN KEY(PERMISSION_ID) REFERENCES PUBLIC.DB_PERMISSION_LIST(ID) ON DELETE CASCADE ON UPDATE CASCADE) +CREATE MEMORY TABLE DB_DATABASE_PERMISSION(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 0) NOT NULL PRIMARY KEY,GROUP_ID INTEGER NOT NULL,DATABASE_ID INTEGER NOT NULL,PERMISSION_ID INTEGER NOT NULL,CONSTRAINT FK_DB_DATABASE_PERMISSION_DB_GROUP FOREIGN KEY(GROUP_ID) REFERENCES PUBLIC.DB_GROUP(ID) ON DELETE CASCADE ON UPDATE CASCADE,CONSTRAINT FK_DB_DATABASE_PERMISSION_DB_DATABASE FOREIGN KEY(DATABASE_ID) REFERENCES PUBLIC.DB_DATABASE(ID) ON DELETE CASCADE ON UPDATE CASCADE,CONSTRAINT FK_DB_DATABASE_PERMISSION_DB_PERMISSION_LIST FOREIGN KEY(PERMISSION_ID) REFERENCES PUBLIC.DB_PERMISSION_LIST(ID) ON DELETE CASCADE ON UPDATE CASCADE,CONSTRAINT UNQ_DB_GRAP UNIQUE(GROUP_ID,DATABASE_ID,PERMISSION_ID)) +CREATE MEMORY TABLE DB_RUN_AS_PERMISSION(GROUP_ID INTEGER NOT NULL,RUN_AS_ID INTEGER NOT NULL,PERMISSION_ID INTEGER NOT NULL,PRIMARY KEY(GROUP_ID,RUN_AS_ID,PERMISSION_ID),CONSTRAINT FK_DB_RUN_AS_PERMISSION_DB_GROUP FOREIGN KEY(GROUP_ID) REFERENCES PUBLIC.DB_GROUP(ID) ON DELETE CASCADE ON UPDATE CASCADE,CONSTRAINT FK_DB_RUN_AS_PERMISSION_DB_RUN_AS FOREIGN KEY(RUN_AS_ID) REFERENCES PUBLIC.DB_RUN_AS(ID) ON DELETE CASCADE ON UPDATE CASCADE,CONSTRAINT FK_DB_RUN_AS_PERMISSION_DB_PERMISSION_LIST FOREIGN KEY(PERMISSION_ID) REFERENCES PUBLIC.DB_PERMISSION_LIST(ID) ON DELETE CASCADE ON UPDATE CASCADE) ALTER TABLE DB_USER ALTER COLUMN ID RESTART WITH 2 ALTER TABLE DB_GROUP ALTER COLUMN ID RESTART WITH 3 ALTER TABLE DB_DRIVER ALTER COLUMN ID RESTART WITH 1 ALTER TABLE DB_DATABASE ALTER COLUMN ID RESTART WITH 1 ALTER TABLE DB_RUN_AS ALTER COLUMN ID RESTART WITH 1 -ALTER TABLE DB_JOB ALTER COLUMN ID RESTART WITH 0 +ALTER TABLE DB_JOB ALTER COLUMN ID RESTART WITH 2 ALTER TABLE DB_PERMISSION_LIST ALTER COLUMN ID RESTART WITH 30 ALTER TABLE DB_DATABASE_PERMISSION ALTER COLUMN ID RESTART WITH 0 -CREATE USER SA PASSWORD "" +SET SCHEMA PUBLIC GRANT DBA TO SA SET WRITE_DELAY 10 SET SCHEMA PUBLIC @@ -34,6 +36,8 @@ INSERT INTO DB_DRIVER VALUES(0,'HSQLDB Driver','org.hsqldb.jdbcDriver') INSERT INTO DB_DATABASE VALUES(0,'HSQLDB In-Memory Database','jdbc:hsqldb:mem:.',0) INSERT INTO DB_RUN_AS VALUES(0,'sa','base64',0) +INSERT INTO DB_JOB VALUES(0,'Job 1',0,'select count(*) from dual',0,'2008-03-19 19:00:00.000000',1,'2008-03-20 18:00:00.000000',1,'2008-03-20 18:00:01.000000','Y','schedule') +INSERT INTO DB_JOB VALUES(1,'Job 2',0,'select count(*) from dual',0,'2008-03-19 19:00:00.000000',1,'2008-03-20 18:00:00.000000',1,'2008-03-20 18:00:01.000000','Y','schedule') INSERT INTO DB_PERMISSION_LIST VALUES(0,'ADD USER','S') INSERT INTO DB_PERMISSION_LIST VALUES(1,'EDIT USER','S') INSERT INTO DB_PERMISSION_LIST VALUES(2,'DELETE USER','S') Modified: trunk/drawbridge/src/test/net/sf/drawbridge/dao/DriverDaoTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/dao/DriverDaoTest.java 2008-03-19 01:42:39 UTC (rev 18) +++ trunk/drawbridge/src/test/net/sf/drawbridge/dao/DriverDaoTest.java 2008-03-20 01:57:45 UTC (rev 19) @@ -49,9 +49,9 @@ public void testShouldCreateNewDriverObject() throws Exception { TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); try { - Driver db = new Driver(null, "name", "class_name"); - target.create(db); - assertNotNull("id is still null", db.getId()); + Driver driver = new Driver(null, "name", "class_name"); + target.create(driver); + assertNotNull("id is still null", driver.getId()); } finally { txManager.rollback(tx); } @@ -87,8 +87,8 @@ public void testShouldRetrieveAllObjectsFromDriver() throws Exception { TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); try { - Driver db = new Driver(null, "name", "class_name"); - target.create(db); + Driver driver = new Driver(null, "name", "class_name"); + target.create(driver); List<Driver> all = target.getAll(); assertEquals(2, all.size()); Added: trunk/drawbridge/src/test/net/sf/drawbridge/dao/GroupDaoTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/dao/GroupDaoTest.java (rev 0) +++ trunk/drawbridge/src/test/net/sf/drawbridge/dao/GroupDaoTest.java 2008-03-20 01:57:45 UTC (rev 19) @@ -0,0 +1,99 @@ +/* + * This file is part of DrawBridge. + * Copyright 2008 Ben La Monica + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation,Inc.,51 Franklin Street,Fifth Floor, Boston, MA 02110-1301, USA. + */ +package net.sf.drawbridge.dao; + +import java.util.List; + +import junit.framework.TestCase; +import net.sf.drawbridge.test.TestBeanFactory; +import net.sf.drawbridge.vo.Group; + +import org.springframework.transaction.TransactionStatus; +import org.springframework.transaction.support.AbstractPlatformTransactionManager; +import org.springframework.transaction.support.DefaultTransactionDefinition; + +public class GroupDaoTest extends TestCase { + + private GroupDao target; + + private AbstractPlatformTransactionManager txManager; + + protected void setUp() { + txManager = (AbstractPlatformTransactionManager) TestBeanFactory.getBean("TxManager"); + target = (GroupDao) TestBeanFactory.getBean("GroupDao"); + } + + public void testShouldGetGroupObject() throws Exception { + Group result = target.get(0); + assertNotNull("result is null", result); + assertEquals("id", new Integer(0), result.getId()); + assertEquals("group name", "Awesome", result.getGroupName()); + } + + public void testShouldCreateNewGroupObject() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + Group group = new Group(null, "a group name"); + target.create(group); + assertNotNull("id is still null", group.getId()); + } finally { + txManager.rollback(tx); + } + } + + public void testShouldSaveChangesToGroupObject() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + Group existing = target.get(0); + existing.setGroupName("a different name"); + target.update(existing); + + Group result = target.get(0); + assertEquals("a different name", result.getGroupName()); + } finally { + txManager.rollback(tx); + } + } + + public void testShouldDeleteObjectFromGroup() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + Group existing = target.get(0); + assertNotNull(existing); + target.delete(existing); + + assertNull("should be deleted", target.get(0)); + } finally { + txManager.rollback(tx); + } + } + + public void testShouldRetrieveAllObjectsFromGroup() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + List<Group> all = target.getAll(); + for (Group group : all) { + System.out.println(group); + } + assertEquals(3, all.size()); + } finally { + txManager.rollback(tx); + } + + } +} Added: trunk/drawbridge/src/test/net/sf/drawbridge/dao/JobDaoTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/dao/JobDaoTest.java (rev 0) +++ trunk/drawbridge/src/test/net/sf/drawbridge/dao/JobDaoTest.java 2008-03-20 01:57:45 UTC (rev 19) @@ -0,0 +1,124 @@ +/* + * This file is part of DrawBridge. + * Copyright 2008 Ben La Monica + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation,Inc.,51 Franklin Street,Fifth Floor, Boston, MA 02110-1301, USA. + */ +package net.sf.drawbridge.dao; + +import java.text.SimpleDateFormat; +import java.util.Calendar; +import java.util.List; + +import junit.framework.TestCase; +import net.sf.drawbridge.test.TestBeanFactory; +import net.sf.drawbridge.vo.Job; +import net.sf.drawbridge.vo.RunAsAccount; +import net.sf.drawbridge.vo.User; + +import org.springframework.transaction.TransactionStatus; +import org.springframework.transaction.support.AbstractPlatformTransactionManager; +import org.springframework.transaction.support.DefaultTransactionDefinition; + +public class JobDaoTest extends TestCase { + + private JobDao target; + + private UserDao userDao; + + private RunAsAccountDao runAsAccountDao; + + private AbstractPlatformTransactionManager txManager; + + protected void setUp() { + txManager = (AbstractPlatformTransactionManager) TestBeanFactory.getBean("TxManager"); + target = (JobDao) TestBeanFactory.getBean("JobDao"); + runAsAccountDao = (RunAsAccountDao) TestBeanFactory.getBean("RunAsAccountDao"); + userDao = (UserDao) TestBeanFactory.getBean("UserDao"); + } + + public void testShouldGetJobObject() throws Exception { + Job result = target.get(0L); + SimpleDateFormat df = new SimpleDateFormat("MM-dd-yyyy HH:mm:ss"); + assertNotNull("result is null", result); + assertEquals("id", new Long(0), result.getId()); + assertEquals("name", "Job 1", result.getName()); + assertEquals("runAsAcount", new Integer(0), result.getRunAsAccount().getId()); + assertEquals("submittedBy", new Integer(0), result.getSubmittedBy().getId()); + assertEquals("submittedOn", "03-19-2008 19:00:00", df.format(result.getSubmittedOn().getTime())); + assertEquals("reviewedBy", new Integer(1), result.getReviewedBy().getId()); + assertEquals("reviewedOn", "03-20-2008 18:00:00", df.format(result.getReviewedOn().getTime())); + assertEquals("approvedBy", new Integer(1), result.getApprovedBy().getId()); + assertEquals("approvedOn", "03-20-2008 18:00:01", df.format(result.getApprovedOn().getTime())); + assertTrue("active", result.isActive()); + assertEquals("schedule", "schedule", result.getSchedule()); + } + + public void testShouldCreateNewJobObject() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + User submitter = userDao.get(0); + RunAsAccount account = runAsAccountDao.get(0); + Job job = new Job(null, "A new job", account, "select count(*) from dual", submitter, Calendar.getInstance(), null, null, null, null, true, "schedule"); + target.create(job); + assertNotNull("id is still null", job.getId()); + } finally { + txManager.rollback(tx); + } + } + + public void testShouldSaveChangesToJobObject() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + Job existing = target.get(0L); + existing.setName("a different name"); + target.update(existing); + + Job result = target.get(0L); + assertEquals("a different name", result.getName()); + } finally { + txManager.rollback(tx); + } + } + + public void testShouldDeleteObjectFromJob() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + Job existing = target.get(0L); + assertNotNull(existing); + target.delete(existing); + + assertNull("should be deleted", target.get(0L)); + } finally { + txManager.rollback(tx); + } + } + + public void testShouldRetrieveAllObjectsFromJob() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + List<Job> all = target.getAll(); + for (Job Job : all) { + System.out.println(Job); + } + assertEquals(2, all.size()); + } finally { + txManager.rollback(tx); + } + } + + public void testShouldRetrieveAllJobsBasedOnDatabaseId() throws Exception { + assertEquals(2, target.getJobsForDatabase(0).size()); + } +} Modified: trunk/drawbridge/src/test/net/sf/drawbridge/dao/RunAsAccountDaoTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/dao/RunAsAccountDaoTest.java 2008-03-19 01:42:39 UTC (rev 18) +++ trunk/drawbridge/src/test/net/sf/drawbridge/dao/RunAsAccountDaoTest.java 2008-03-20 01:57:45 UTC (rev 19) @@ -51,9 +51,9 @@ TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); try { RunAsAccount existing = target.get(0); - RunAsAccount db = new RunAsAccount(null, "temp_user", "temp_password", existing.getDatabase()); - target.create(db); - assertNotNull("id is still null", db.getId()); + RunAsAccount account = new RunAsAccount(null, "temp_user", "temp_password", existing.getDatabase()); + target.create(account); + assertNotNull("id is still null", account.getId()); } finally { txManager.rollback(tx); } @@ -90,8 +90,8 @@ TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); try { RunAsAccount existing = target.get(0); - RunAsAccount db = new RunAsAccount(null, "temp_user", "temp_password", existing.getDatabase()); - target.create(db); + RunAsAccount account = new RunAsAccount(null, "temp_user", "temp_password", existing.getDatabase()); + target.create(account); List<RunAsAccount> all = target.getAll(); assertEquals(2, all.size()); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <ac...@us...> - 2008-03-21 01:11:02
|
Revision: 20 http://drawbridge.svn.sourceforge.net/drawbridge/?rev=20&view=rev Author: acresse Date: 2008-03-20 18:10:45 -0700 (Thu, 20 Mar 2008) Log Message: ----------- example data and fix adding jobs Modified Paths: -------------- trunk/drawbridge/src/java/net/sf/drawbridge/controller/job/AddOrEditJobSubmitController.java trunk/drawbridge/src/java/net/sf/drawbridge/controller/job/RunJobController.java Added Paths: ----------- trunk/drawbridge/src/sql/example_data.sql Modified: trunk/drawbridge/src/java/net/sf/drawbridge/controller/job/AddOrEditJobSubmitController.java =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/controller/job/AddOrEditJobSubmitController.java 2008-03-20 01:57:45 UTC (rev 19) +++ trunk/drawbridge/src/java/net/sf/drawbridge/controller/job/AddOrEditJobSubmitController.java 2008-03-21 01:10:45 UTC (rev 20) @@ -67,7 +67,7 @@ try{ RunAsAccount account = drawbridgeService.getRunAsAccount(new Integer(request.getParameter("runAsId"))); // TODO: get real user - User user = drawbridgeService.getUser(0); + User user = drawbridgeService.getUser(-1); job=new Job(null, name, account, @@ -92,7 +92,7 @@ try{ RunAsAccount account = drawbridgeService.getRunAsAccount(new Integer(request.getParameter("runAsId"))); // TODO: get real user - User user = drawbridgeService.getUser(0); + User user = drawbridgeService.getUser(-1); job=new Job(new Long(jobIdStr), name, account, Modified: trunk/drawbridge/src/java/net/sf/drawbridge/controller/job/RunJobController.java =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/controller/job/RunJobController.java 2008-03-20 01:57:45 UTC (rev 19) +++ trunk/drawbridge/src/java/net/sf/drawbridge/controller/job/RunJobController.java 2008-03-21 01:10:45 UTC (rev 20) @@ -29,15 +29,19 @@ protected ModelAndView handleRequestInternal(HttpServletRequest request, HttpServletResponse response) throws Exception { ModelAndView mav = new ModelAndView("job/run"); - String jobIdStr=request.getParameter("jobId"); - Long jobId = new Long(jobIdStr); - mav.addObject("jobId",jobIdStr); - Job job = drawbridgeService.getJob(jobId); - RunAsAccount runAsAccount = job.getRunAsAccount(); - mav.addObject("runAs", runAsAccount); - mav.addObject("database", runAsAccount.getDatabase()); - mav.addObject("job", job); - mav.addObject("queryParams", drawbridgeService.getQueryParams(job.getQuery(),false)); + try{ + String jobIdStr=request.getParameter("jobId"); + Long jobId = new Long(jobIdStr); + mav.addObject("jobId",jobIdStr); + Job job = drawbridgeService.getJob(jobId); + RunAsAccount runAsAccount = job.getRunAsAccount(); + mav.addObject("runAs", runAsAccount); + mav.addObject("database", runAsAccount.getDatabase()); + mav.addObject("job", job); + mav.addObject("queryParams", drawbridgeService.getQueryParams(job.getQuery(),false)); + } catch(Exception ex){ + ex.printStackTrace(); + } return mav; } Added: trunk/drawbridge/src/sql/example_data.sql =================================================================== --- trunk/drawbridge/src/sql/example_data.sql (rev 0) +++ trunk/drawbridge/src/sql/example_data.sql 2008-03-21 01:10:45 UTC (rev 20) @@ -0,0 +1,17 @@ +INSERT INTO db_driver (id,name,class_name) VALUES (-1,'Hsqldb','org.hsqldb.jdbcDriver'); +INSERT INTO db_driver (id,name,class_name) VALUES (-2,'MySQL','com.mysql.jdbc.Driver'); + +INSERT INTO db_database (id,name,jdbc_url,driver_id) VALUES (-1,'In memory','jdbc:hsqldb:.',-1); +INSERT INTO db_database (id,name,jdbc_url,driver_id) VALUES (-2,'local mysql','jdbc:mysql://localhost:3306/drawbridge',-2); + +INSERT INTO db_run_as (id,user_name,enc_password,database_id) VALUES (-1,'sa','',-1); +INSERT INTO db_run_as (id,user_name,enc_password,database_id) VALUES (-2,'drawbridge_user','drawbridge',-2); + +INSERT INTO db_user (id,user_name,first_name,last_name,active) VALUES (-1,'adam','Adam','Cresse','Y'); +INSERT INTO db_user (id,user_name,first_name,last_name,active) VALUES (-2,'ben','Ben','La Monica','Y'); + +INSERT INTO db_group (id,group_name) VALUES (-1,'devs'); + +INSERT INTO db_user_group (user_id,group_id) VALUES (-1,-1); + +INSERT INTO db_job (id,name,run_as_id,query,submitted_by,submitted_on,reviewed_by,reviewed_on,approved_by,approved_on,active,schedule) VALUES (-1,'all jobs',-2,'select * from db_job',-1,{d '2008-03-19'},null,null,null,null,'Y',null); \ No newline at end of file This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <bla...@us...> - 2008-04-01 02:43:36
|
Revision: 33 http://drawbridge.svn.sourceforge.net/drawbridge/?rev=33&view=rev Author: blamonica Date: 2008-03-31 19:43:34 -0700 (Mon, 31 Mar 2008) Log Message: ----------- [ 1917705 ] Need unique DBs on Edit RunAs Page - Remove join="fetch" from our collections. Performing a cartesian product and not doing what it seems to have done in the past. Modified Paths: -------------- trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/Database.hbm.xml trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/RunAsAccount.hbm.xml trunk/drawbridge/src/test/db.script trunk/drawbridge/src/test/net/sf/drawbridge/dao/DatabaseDaoTest.java trunk/drawbridge/src/test/net/sf/drawbridge/dao/RunAsAccountDaoTest.java Modified: trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/Database.hbm.xml =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/Database.hbm.xml 2008-04-01 00:45:06 UTC (rev 32) +++ trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/Database.hbm.xml 2008-04-01 02:43:34 UTC (rev 33) @@ -21,7 +21,7 @@ fetch="join" lazy="false"/> - <set name="accounts" table="DB_RUN_AS" fetch="join" inverse="true" lazy="false"> + <set name="accounts" table="DB_RUN_AS" inverse="true" lazy="false"> <key column="DATABASE_ID"/> <one-to-many class="net.sf.drawbridge.vo.RunAsAccount"/> </set> Modified: trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/RunAsAccount.hbm.xml =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/RunAsAccount.hbm.xml 2008-04-01 00:45:06 UTC (rev 32) +++ trunk/drawbridge/src/java/net/sf/drawbridge/dao/hibernate/hbm/RunAsAccount.hbm.xml 2008-04-01 02:43:34 UTC (rev 33) @@ -18,7 +18,6 @@ <many-to-one name="database" column="DATABASE_ID" class="net.sf.drawbridge.vo.Database" - fetch="join" lazy="false" /> </class> Modified: trunk/drawbridge/src/test/db.script =================================================================== --- trunk/drawbridge/src/test/db.script 2008-04-01 00:45:06 UTC (rev 32) +++ trunk/drawbridge/src/test/db.script 2008-04-01 02:43:34 UTC (rev 33) @@ -6,7 +6,7 @@ CREATE MEMORY TABLE DB_USER_GROUP(USER_ID INTEGER NOT NULL,GROUP_ID INTEGER NOT NULL,PRIMARY KEY(USER_ID,GROUP_ID),CONSTRAINT FK_DB_USER_GROUP_DB_USER FOREIGN KEY(USER_ID) REFERENCES PUBLIC.DB_USER(ID) ON DELETE CASCADE ON UPDATE CASCADE,CONSTRAINT FK_DB_USER_GROUP_DB_GROUP FOREIGN KEY(GROUP_ID) REFERENCES PUBLIC.DB_GROUP(ID) ON DELETE CASCADE ON UPDATE CASCADE) CREATE MEMORY TABLE DB_DRIVER(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 1) NOT NULL PRIMARY KEY,NAME VARCHAR(32) NOT NULL,CLASS_NAME VARCHAR(128) NOT NULL,CONSTRAINT UNQ_DB_DRIVER UNIQUE(NAME)) CREATE MEMORY TABLE DB_DATABASE(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 1) NOT NULL PRIMARY KEY,NAME VARCHAR(32) NOT NULL,JDBC_URL VARCHAR(128) NOT NULL,DRIVER_ID INTEGER NOT NULL,CONSTRAINT FK_DB_DATABASE_DB_DRIVER FOREIGN KEY(DRIVER_ID) REFERENCES PUBLIC.DB_DRIVER(ID),CONSTRAINT UNQ_DB_DATABASE UNIQUE(NAME)) -CREATE MEMORY TABLE DB_RUN_AS(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 1) NOT NULL PRIMARY KEY,USER_NAME VARCHAR(16) NOT NULL,ENC_PASSWORD VARCHAR(32) NOT NULL,DATABASE_ID INTEGER NOT NULL,CONSTRAINT FK_DB_RUN_AS_DB_DATABASE FOREIGN KEY(DATABASE_ID) REFERENCES PUBLIC.DB_DATABASE(ID),CONSTRAINT UNQ_DB_RUN_AS UNIQUE(USER_NAME,DATABASE_ID)) +CREATE MEMORY TABLE DB_RUN_AS(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 2) NOT NULL PRIMARY KEY,USER_NAME VARCHAR(16) NOT NULL,ENC_PASSWORD VARCHAR(32) NOT NULL,DATABASE_ID INTEGER NOT NULL,CONSTRAINT FK_DB_RUN_AS_DB_DATABASE FOREIGN KEY(DATABASE_ID) REFERENCES PUBLIC.DB_DATABASE(ID),CONSTRAINT UNQ_DB_RUN_AS UNIQUE(USER_NAME,DATABASE_ID)) CREATE MEMORY TABLE DB_JOB(ID INTEGER GENERATED BY DEFAULT AS IDENTITY(START WITH 2) NOT NULL PRIMARY KEY,NAME VARCHAR(64) NOT NULL,RUN_AS_ID INTEGER NOT NULL,QUERY VARCHAR(1024) NOT NULL,SUBMITTED_BY INTEGER NOT NULL,SUBMITTED_ON TIMESTAMP NOT NULL,REVIEWED_BY INTEGER,REVIEWED_ON TIMESTAMP,APPROVED_BY INTEGER,APPROVED_ON TIMESTAMP,ACTIVE VARCHAR(1) NOT NULL,SCHEDULE VARCHAR(128),CONSTRAINT FK_DB_JOB_DB_RUN_AS FOREIGN KEY(RUN_AS_ID) REFERENCES PUBLIC.DB_RUN_AS(ID),CONSTRAINT FK_DB_JOB_SUBMITTED_BY FOREIGN KEY(SUBMITTED_BY) REFERENCES PUBLIC.DB_USER(ID),CONSTRAINT FK_DB_JOB_REVIEWED_BY FOREIGN KEY(REVIEWED_BY) REFERENCES PUBLIC.DB_USER(ID),CONSTRAINT FK_DB_JOB_APPROVED_BY FOREIGN KEY(APPROVED_BY) REFERENCES PUBLIC.DB_USER(ID),CONSTRAINT UNQ_DB_JOB UNIQUE(NAME),CONSTRAINT CHK_DB_JOB_ACTIVE CHECK((DB_JOB.ACTIVE) IN (('Y'),('N')))) CREATE MEMORY TABLE DB_PERMISSION_LIST(ID INTEGER NOT NULL PRIMARY KEY,NAME VARCHAR(64) NOT NULL,PERMISSION_TYPE VARCHAR(1) NOT NULL,CONSTRAINT UNQ_DB_PERMISSION UNIQUE(NAME,PERMISSION_TYPE),CONSTRAINT CHK_DB_PERMISSION_LIST_PERMISSION_TYPE CHECK((DB_PERMISSION_LIST.PERMISSION_TYPE) IN (('S'),('D'),('R')))) CREATE MEMORY TABLE DB_SYSTEM_PERMISSION(GROUP_ID INTEGER NOT NULL,PERMISSION_ID INTEGER NOT NULL,PRIMARY KEY(GROUP_ID,PERMISSION_ID),CONSTRAINT FK_DB_SYSTEM_PERMISSION_DB_GROUP FOREIGN KEY(GROUP_ID) REFERENCES PUBLIC.DB_GROUP(ID) ON DELETE CASCADE ON UPDATE CASCADE,CONSTRAINT FK_DB_SYSTEM_PERMISSION_DB_PERMISSION_LIST FOREIGN KEY(PERMISSION_ID) REFERENCES PUBLIC.DB_PERMISSION_LIST(ID) ON DELETE CASCADE ON UPDATE CASCADE) @@ -16,7 +16,7 @@ ALTER TABLE DB_GROUP ALTER COLUMN ID RESTART WITH 3 ALTER TABLE DB_DRIVER ALTER COLUMN ID RESTART WITH 1 ALTER TABLE DB_DATABASE ALTER COLUMN ID RESTART WITH 1 -ALTER TABLE DB_RUN_AS ALTER COLUMN ID RESTART WITH 1 +ALTER TABLE DB_RUN_AS ALTER COLUMN ID RESTART WITH 2 ALTER TABLE DB_JOB ALTER COLUMN ID RESTART WITH 2 ALTER TABLE DB_DATABASE_PERMISSION ALTER COLUMN ID RESTART WITH 0 SET SCHEMA PUBLIC @@ -35,6 +35,7 @@ INSERT INTO DB_DRIVER VALUES(0,'HSQLDB Driver','org.hsqldb.jdbcDriver') INSERT INTO DB_DATABASE VALUES(0,'HSQLDB In-Memory Database','jdbc:hsqldb:mem:.',0) INSERT INTO DB_RUN_AS VALUES(0,'sa','base64',0) +INSERT INTO DB_RUN_AS VALUES(1,'dev','base64',0) INSERT INTO DB_JOB VALUES(0,'Job 1',0,'select count(*) from dual',0,'2008-03-19 19:00:00.000000',1,'2008-03-20 18:00:00.000000',1,'2008-03-20 18:00:01.000000','Y','schedule') INSERT INTO DB_JOB VALUES(1,'Job 2',0,'select count(*) from dual',0,'2008-03-19 19:00:00.000000',1,'2008-03-20 18:00:00.000000',1,'2008-03-20 18:00:01.000000','Y','schedule') INSERT INTO DB_PERMISSION_LIST VALUES(1,'ADD USER','S') Modified: trunk/drawbridge/src/test/net/sf/drawbridge/dao/DatabaseDaoTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/dao/DatabaseDaoTest.java 2008-04-01 00:45:06 UTC (rev 32) +++ trunk/drawbridge/src/test/net/sf/drawbridge/dao/DatabaseDaoTest.java 2008-04-01 02:43:34 UTC (rev 33) @@ -45,7 +45,7 @@ assertEquals("name", "HSQLDB In-Memory Database", result.getName()); assertEquals("jdbcUrl", "jdbc:hsqldb:mem:.", result.getJdbcUrl()); assertNotNull("driver", result.getDriver()); - assertEquals("accounts", 1, result.getAccounts().size()); + assertEquals("accounts", 2, result.getAccounts().size()); } public void testShouldCreateNewDatabaseObject() throws Exception { @@ -99,6 +99,20 @@ } finally { txManager.rollback(tx); } - } + + public void testShouldNotHaveDuplicateDatabasesIfThereIsMoreThanOneRunAsAccountForTheDatabase() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + Database existing = target.get(0); + Database db = new Database(null, "temporary db", "jdbc:temp", existing.getDriver()); + target.create(db); + + List<Database> all = target.getAll(); + assertEquals(2, all.size()); + } finally { + txManager.rollback(tx); + } + } + } Modified: trunk/drawbridge/src/test/net/sf/drawbridge/dao/RunAsAccountDaoTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/dao/RunAsAccountDaoTest.java 2008-04-01 00:45:06 UTC (rev 32) +++ trunk/drawbridge/src/test/net/sf/drawbridge/dao/RunAsAccountDaoTest.java 2008-04-01 02:43:34 UTC (rev 33) @@ -94,10 +94,24 @@ target.create(account); List<RunAsAccount> all = target.getAll(); - assertEquals(2, all.size()); + assertEquals(3, all.size()); } finally { txManager.rollback(tx); } - } + + public void testShouldRetrieveOnlyDistinctRunAsAccountsWhenSpecifyingADatabaseId() throws Exception { + TransactionStatus tx = txManager.getTransaction(new DefaultTransactionDefinition()); + try { + RunAsAccount existing = target.get(0); + RunAsAccount account = new RunAsAccount(null, "temp_user", "temp_password", existing.getDatabase()); + target.create(account); + + List<RunAsAccount> all = target.getAccountsForDatabase(account.getDatabase().getId()); + assertEquals(3, all.size()); + } finally { + txManager.rollback(tx); + } + } + } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <bla...@us...> - 2008-04-16 02:30:08
|
Revision: 37 http://drawbridge.svn.sourceforge.net/drawbridge/?rev=37&view=rev Author: blamonica Date: 2008-04-15 19:30:04 -0700 (Tue, 15 Apr 2008) Log Message: ----------- Check in cruise-control build files and configuration. Not done yet. Added Paths: ----------- trunk/drawbridge/src/cruise/ trunk/drawbridge/src/cruise/config.xml trunk/drawbridge/src/cruise/cruise-build.xml trunk/drawbridge/src/cruise/db.properties Added: trunk/drawbridge/src/cruise/config.xml =================================================================== --- trunk/drawbridge/src/cruise/config.xml (rev 0) +++ trunk/drawbridge/src/cruise/config.xml 2008-04-16 02:30:04 UTC (rev 37) @@ -0,0 +1,3 @@ +<cruisecontrol> + +</cruisecontrol> Added: trunk/drawbridge/src/cruise/cruise-build.xml =================================================================== --- trunk/drawbridge/src/cruise/cruise-build.xml (rev 0) +++ trunk/drawbridge/src/cruise/cruise-build.xml 2008-04-16 02:30:04 UTC (rev 37) @@ -0,0 +1,33 @@ +<project name="drawbridge" default="all" basedir="."> + <property file="./db.properties"/> + + <target name="all" depends="sync,build,reset.database,deploy"/> + + <target name="sync"> + <exec executable="svn"> + <arg value="co"/> + <arg value="https://drawbridge.svn.sourceforge.net/svnroot/drawbridge/trunk/drawbridge"/> + <arg value="checkout/drawbridge"/> + </exec> + </target> + + <target name="build"> + <exec dir="checkout/drawbridge" executable="ant"/> + </target> + + <target name="reset.database"> + <exec dir="/bin" executable="bash"> + <arg value="-c"/> + <arg value="cat ${basedir}/checkout/drawbridge/src/sql/create_drawbridge_schema.sql | /usr/local/mysql/bin/mysql -u${db.user} -p${db.password} drawbridge"/> + </exec> + + <exec dir="/bin" executable="bash"> + <arg value="-c"/> + <arg value="cat ${basedir}/checkout/drawbridge/src/sql/example_data.sql | /usr/local/mysql/bin/mysql -u${db.user} -p${db.password} drawbridge"/> + </exec> + </target> + + <target name="deploy"> + <copy tofile="/opt/tomcat6/webapps/drawbridge.war" file="checkout/drawbridge/target/drawbridge.war"/> + </target> +</project> Added: trunk/drawbridge/src/cruise/db.properties =================================================================== --- trunk/drawbridge/src/cruise/db.properties (rev 0) +++ trunk/drawbridge/src/cruise/db.properties 2008-04-16 02:30:04 UTC (rev 37) @@ -0,0 +1,2 @@ +db.user=drawbridge_user +db.password=drawbridge This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <bla...@us...> - 2008-04-20 01:03:58
|
Revision: 40 http://drawbridge.svn.sourceforge.net/drawbridge/?rev=40&view=rev Author: blamonica Date: 2008-04-19 18:03:45 -0700 (Sat, 19 Apr 2008) Log Message: ----------- Got e-mail working for the build loop. Fixed an errant } in the canoo ant script. Modified Paths: -------------- trunk/drawbridge/src/canoo/build.xml trunk/drawbridge/src/cruise/config.xml Added Paths: ----------- trunk/drawbridge/src/cruise/email.properties Modified: trunk/drawbridge/src/canoo/build.xml =================================================================== --- trunk/drawbridge/src/canoo/build.xml 2008-04-19 23:16:00 UTC (rev 39) +++ trunk/drawbridge/src/canoo/build.xml 2008-04-20 01:03:45 UTC (rev 40) @@ -13,7 +13,7 @@ <import file="definitions.xml" description="Import custom definitions (if any)"/> <import file="${webtest.home}/webtest.xml" description="Import all functionalities for a full build"/> - <property name="wt.testInWork" value="${basedir}}/tests/allTests.xml"/> + <property name="wt.testInWork" value="${basedir}/tests/allTests.xml"/> <!-- run in headless mode --> <property name="wt.headless" value="true"/> Modified: trunk/drawbridge/src/cruise/config.xml =================================================================== --- trunk/drawbridge/src/cruise/config.xml 2008-04-19 23:16:00 UTC (rev 39) +++ trunk/drawbridge/src/cruise/config.xml 2008-04-20 01:03:45 UTC (rev 40) @@ -14,7 +14,7 @@ </modificationset> <!-- Configures the actual build loop, how often and which build file/target --> - <schedule interval="60"> + <schedule interval="360"> <ant antscript="/usr/bin/ant" buildfile="cruise-build.xml" target="all" @@ -31,10 +31,9 @@ <email mailhost="${email.host}" mailport="${email.port}" returnaddress="${email.returnaddress}" username="${email.username}" password="${email.password}" usessl="${email.ssl}" - buildresultsurl="http://pojo.is-a-geek.net:8751/cc/buildresults/drawbridge" - skipusers="true" spamwhilebroken="false"> - <always address="ben...@gm..."/> - <!--always address="dra...@li..."/--> + buildresultsurl="http://pojo.is-a-geek.net:8751/buildresults/drawbridge" + skipusers="false" spamwhilebroken="false"> + <failure address="dra...@li..." reportWhenFixed="true"/> </email> </publishers> Added: trunk/drawbridge/src/cruise/email.properties =================================================================== --- trunk/drawbridge/src/cruise/email.properties (rev 0) +++ trunk/drawbridge/src/cruise/email.properties 2008-04-20 01:03:45 UTC (rev 40) @@ -0,0 +1,6 @@ +email.host=mail.pojo.us +email.port=587 +email.ssl=false +email.username=cruisecontrol +email.password=<removed for security> +email.returnaddress=dra...@li... This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <bla...@us...> - 2008-04-20 01:26:24
|
Revision: 42 http://drawbridge.svn.sourceforge.net/drawbridge/?rev=42&view=rev Author: blamonica Date: 2008-04-19 18:26:21 -0700 (Sat, 19 Apr 2008) Log Message: ----------- Fix build to see if it sends e-mail. Modified Paths: -------------- trunk/drawbridge/src/cruise/config.xml trunk/drawbridge/src/java/net/sf/drawbridge/dao/Dao.java Modified: trunk/drawbridge/src/cruise/config.xml =================================================================== --- trunk/drawbridge/src/cruise/config.xml 2008-04-20 01:11:31 UTC (rev 41) +++ trunk/drawbridge/src/cruise/config.xml 2008-04-20 01:26:21 UTC (rev 42) @@ -32,7 +32,7 @@ returnaddress="${email.returnaddress}" username="${email.username}" password="${email.password}" usessl="${email.ssl}" buildresultsurl="http://pojo.is-a-geek.net:8751/buildresults/drawbridge" - skipusers="false" spamwhilebroken="false"> + skipusers="true" spamwhilebroken="false"> <failure address="dra...@li..." reportWhenFixed="true"/> </email> </publishers> Modified: trunk/drawbridge/src/java/net/sf/drawbridge/dao/Dao.java =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/dao/Dao.java 2008-04-20 01:11:31 UTC (rev 41) +++ trunk/drawbridge/src/java/net/sf/drawbridge/dao/Dao.java 2008-04-20 01:26:21 UTC (rev 42) @@ -19,8 +19,6 @@ import java.util.List; -blah - public interface Dao<T, I> { void create(T vo); T get(I id); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <ac...@us...> - 2008-04-22 02:06:46
|
Revision: 46 http://drawbridge.svn.sourceforge.net/drawbridge/?rev=46&view=rev Author: acresse Date: 2008-04-21 19:06:41 -0700 (Mon, 21 Apr 2008) Log Message: ----------- I shoulda remembered the unit tests Modified Paths: -------------- trunk/drawbridge/src/java/net/sf/drawbridge/controller/AbstractDrawbridgeController.java trunk/drawbridge/src/java/net/sf/drawbridge/controller/MainMenuController.java trunk/drawbridge/src/test/net/sf/drawbridge/controller/database/AddOrEditDatabaseSubmitControllerTest.java trunk/drawbridge/src/test/net/sf/drawbridge/controller/database/DeleteDatabaseSubmitControllerTest.java trunk/drawbridge/src/test/net/sf/drawbridge/controller/driver/AddOrEditDriverSubmitControllerTest.java trunk/drawbridge/src/test/net/sf/drawbridge/controller/driver/DeleteDriverSubmitControllerTest.java trunk/drawbridge/src/test/net/sf/drawbridge/controller/group/AddOrEditGroupSubmitControllerTest.java trunk/drawbridge/src/test/net/sf/drawbridge/controller/group/DeleteGroupSubmitControllerTest.java trunk/drawbridge/src/test/net/sf/drawbridge/controller/job/AddOrEditJobSubmitControllerTest.java trunk/drawbridge/src/test/net/sf/drawbridge/controller/job/DeleteJobSubmitControllerTest.java trunk/drawbridge/src/test/net/sf/drawbridge/controller/runas/AddOrEditRunAsSubmitControllerTest.java trunk/drawbridge/src/test/net/sf/drawbridge/controller/runas/DeleteRunAsSubmitControllerTest.java trunk/drawbridge/src/test/net/sf/drawbridge/controller/user/AddOrEditUserSubmitControllerTest.java trunk/drawbridge/src/test/net/sf/drawbridge/controller/user/DeleteUserSubmitControllerTest.java Modified: trunk/drawbridge/src/java/net/sf/drawbridge/controller/AbstractDrawbridgeController.java =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/controller/AbstractDrawbridgeController.java 2008-04-22 01:45:33 UTC (rev 45) +++ trunk/drawbridge/src/java/net/sf/drawbridge/controller/AbstractDrawbridgeController.java 2008-04-22 02:06:41 UTC (rev 46) @@ -32,6 +32,10 @@ @Autowired protected DrawbridgeService drawbridgeService; + + public void setDrawbridgeService(DrawbridgeService drawbridgeService) { + this.drawbridgeService=drawbridgeService; + } protected String getValueFromRequestOrSession(String name, HttpServletRequest request){ return getValueFromRequestOrSession(name, request, true); Modified: trunk/drawbridge/src/java/net/sf/drawbridge/controller/MainMenuController.java =================================================================== --- trunk/drawbridge/src/java/net/sf/drawbridge/controller/MainMenuController.java 2008-04-22 01:45:33 UTC (rev 45) +++ trunk/drawbridge/src/java/net/sf/drawbridge/controller/MainMenuController.java 2008-04-22 02:06:41 UTC (rev 46) @@ -20,6 +20,8 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; +import net.sf.drawbridge.domain.DrawbridgeService; + import org.springframework.stereotype.Controller; import org.springframework.web.bind.annotation.RequestMapping; import org.springframework.web.servlet.ModelAndView; Modified: trunk/drawbridge/src/test/net/sf/drawbridge/controller/database/AddOrEditDatabaseSubmitControllerTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/controller/database/AddOrEditDatabaseSubmitControllerTest.java 2008-04-22 01:45:33 UTC (rev 45) +++ trunk/drawbridge/src/test/net/sf/drawbridge/controller/database/AddOrEditDatabaseSubmitControllerTest.java 2008-04-22 02:06:41 UTC (rev 46) @@ -58,7 +58,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageDatabasesRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageDatabases.do",mav.getViewName()); assertEquals(new HashMap<String, Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -81,7 +81,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageDatabasesRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageDatabases.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -105,7 +105,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageDatabasesRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageDatabases.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -129,7 +129,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageDatabasesRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageDatabases.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); Modified: trunk/drawbridge/src/test/net/sf/drawbridge/controller/database/DeleteDatabaseSubmitControllerTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/controller/database/DeleteDatabaseSubmitControllerTest.java 2008-04-22 01:45:33 UTC (rev 45) +++ trunk/drawbridge/src/test/net/sf/drawbridge/controller/database/DeleteDatabaseSubmitControllerTest.java 2008-04-22 02:06:41 UTC (rev 46) @@ -51,7 +51,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageDatabasesRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageDatabases.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -70,7 +70,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageDatabasesRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageDatabases.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); Modified: trunk/drawbridge/src/test/net/sf/drawbridge/controller/driver/AddOrEditDriverSubmitControllerTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/controller/driver/AddOrEditDriverSubmitControllerTest.java 2008-04-22 01:45:33 UTC (rev 45) +++ trunk/drawbridge/src/test/net/sf/drawbridge/controller/driver/AddOrEditDriverSubmitControllerTest.java 2008-04-22 02:06:41 UTC (rev 46) @@ -55,7 +55,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageDriversRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageDrivers.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -76,7 +76,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageDriversRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageDrivers.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -98,7 +98,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageDriversRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageDrivers.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -120,7 +120,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageDriversRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageDrivers.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); Modified: trunk/drawbridge/src/test/net/sf/drawbridge/controller/driver/DeleteDriverSubmitControllerTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/controller/driver/DeleteDriverSubmitControllerTest.java 2008-04-22 01:45:33 UTC (rev 45) +++ trunk/drawbridge/src/test/net/sf/drawbridge/controller/driver/DeleteDriverSubmitControllerTest.java 2008-04-22 02:06:41 UTC (rev 46) @@ -51,7 +51,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageDriversRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageDrivers.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -70,7 +70,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageDriversRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageDrivers.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); Modified: trunk/drawbridge/src/test/net/sf/drawbridge/controller/group/AddOrEditGroupSubmitControllerTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/controller/group/AddOrEditGroupSubmitControllerTest.java 2008-04-22 01:45:33 UTC (rev 45) +++ trunk/drawbridge/src/test/net/sf/drawbridge/controller/group/AddOrEditGroupSubmitControllerTest.java 2008-04-22 02:06:41 UTC (rev 46) @@ -60,7 +60,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageGroupsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageGroups.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -86,7 +86,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageGroupsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageGroups.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -109,7 +109,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageGroupsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageGroups.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -132,7 +132,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageGroupsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageGroups.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); Modified: trunk/drawbridge/src/test/net/sf/drawbridge/controller/group/DeleteGroupSubmitControllerTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/controller/group/DeleteGroupSubmitControllerTest.java 2008-04-22 01:45:33 UTC (rev 45) +++ trunk/drawbridge/src/test/net/sf/drawbridge/controller/group/DeleteGroupSubmitControllerTest.java 2008-04-22 02:06:41 UTC (rev 46) @@ -51,7 +51,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageGroupsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageGroups.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -70,7 +70,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageGroupsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageGroups.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); Modified: trunk/drawbridge/src/test/net/sf/drawbridge/controller/job/AddOrEditJobSubmitControllerTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/controller/job/AddOrEditJobSubmitControllerTest.java 2008-04-22 01:45:33 UTC (rev 45) +++ trunk/drawbridge/src/test/net/sf/drawbridge/controller/job/AddOrEditJobSubmitControllerTest.java 2008-04-22 02:06:41 UTC (rev 46) @@ -66,7 +66,7 @@ mockRequest.setParameter("schedule", "schedule"); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageJobsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageJobs.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -91,7 +91,7 @@ mockRequest.setParameter("schedule", "schedule"); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageJobsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageJobs.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -118,7 +118,7 @@ mockRequest.setParameter("schedule", "schedule"); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageJobsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageJobs.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> expected=new ArrayList<StatusMessage>(); @@ -150,7 +150,7 @@ mockRequest.setParameter("schedule", "schedule"); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageJobsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageJobs.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> expected=new ArrayList<StatusMessage>(); Modified: trunk/drawbridge/src/test/net/sf/drawbridge/controller/job/DeleteJobSubmitControllerTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/controller/job/DeleteJobSubmitControllerTest.java 2008-04-22 01:45:33 UTC (rev 45) +++ trunk/drawbridge/src/test/net/sf/drawbridge/controller/job/DeleteJobSubmitControllerTest.java 2008-04-22 02:06:41 UTC (rev 46) @@ -58,7 +58,7 @@ mockRequest.setParameter("jobId", "1"); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageJobsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageJobs.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -76,7 +76,7 @@ mockRequest.setParameter("jobId", "1"); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageJobsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageJobs.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); Modified: trunk/drawbridge/src/test/net/sf/drawbridge/controller/runas/AddOrEditRunAsSubmitControllerTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/controller/runas/AddOrEditRunAsSubmitControllerTest.java 2008-04-22 01:45:33 UTC (rev 45) +++ trunk/drawbridge/src/test/net/sf/drawbridge/controller/runas/AddOrEditRunAsSubmitControllerTest.java 2008-04-22 02:06:41 UTC (rev 46) @@ -56,7 +56,7 @@ mockRequest.setParameter("databaseId", "1"); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageRunAsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageRunAsAccounts.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -77,7 +77,7 @@ mockRequest.setParameter("databaseId", "1"); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageRunAsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageRunAsAccounts.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -99,7 +99,7 @@ mockRequest.setParameter("databaseId", "1"); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageRunAsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageRunAsAccounts.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -121,7 +121,7 @@ mockRequest.setParameter("databaseId", "1"); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageRunAsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageRunAsAccounts.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); Modified: trunk/drawbridge/src/test/net/sf/drawbridge/controller/runas/DeleteRunAsSubmitControllerTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/controller/runas/DeleteRunAsSubmitControllerTest.java 2008-04-22 01:45:33 UTC (rev 45) +++ trunk/drawbridge/src/test/net/sf/drawbridge/controller/runas/DeleteRunAsSubmitControllerTest.java 2008-04-22 02:06:41 UTC (rev 46) @@ -49,7 +49,7 @@ mockRequest.setParameter("runAsId", "1"); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageRunAsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageRunAsAccounts.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -66,7 +66,7 @@ mockRequest.setParameter("runAsId", "1"); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageRunAsRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageRunAsAccounts.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); Modified: trunk/drawbridge/src/test/net/sf/drawbridge/controller/user/AddOrEditUserSubmitControllerTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/controller/user/AddOrEditUserSubmitControllerTest.java 2008-04-22 01:45:33 UTC (rev 45) +++ trunk/drawbridge/src/test/net/sf/drawbridge/controller/user/AddOrEditUserSubmitControllerTest.java 2008-04-22 02:06:41 UTC (rev 46) @@ -66,7 +66,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageUsersRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageUsers.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -95,7 +95,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageUsersRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageUsers.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -121,7 +121,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageUsersRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageUsers.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -147,7 +147,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageUsersRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageUsers.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); Modified: trunk/drawbridge/src/test/net/sf/drawbridge/controller/user/DeleteUserSubmitControllerTest.java =================================================================== --- trunk/drawbridge/src/test/net/sf/drawbridge/controller/user/DeleteUserSubmitControllerTest.java 2008-04-22 01:45:33 UTC (rev 45) +++ trunk/drawbridge/src/test/net/sf/drawbridge/controller/user/DeleteUserSubmitControllerTest.java 2008-04-22 02:06:41 UTC (rev 46) @@ -52,7 +52,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageUsersRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageUsers.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); @@ -71,7 +71,7 @@ login(mockRequest); ModelAndView mav=target.handleRequestInternal(mockRequest, null); - assertEquals("manageUsersRedirectView",mav.getViewName()); + assertEquals("redirect:/ManageUsers.do",mav.getViewName()); assertEquals(new HashMap<String,Object>(),mav.getModel()); List<StatusMessage> messageList=new ArrayList<StatusMessage>(); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |