Menu

#17 GetRLogCommand() builds incorrect parameter string

open
nobody
2
2004-08-21
2004-02-21
Anonymous
No

bmitchell<remove_to_send>@mobitrac.com

the following is the output of GetRLogCommand that

By running this command against cvs on the command
line it generates a parameter exception.

C:\Program Files\Draco.NET Service\bin>cvs -
d:sspi:cvsserver:/ourRoot -q rlog -N -b -
d>2004-02-21T13:16:34-0600 ourProjectName

Seems like the problem is in cvsRepository.CS ->

private string GetRLogCommand(DateTime sinceDate) {
string command = "rlog";
command += " -N "; // Do not list tags
command += GetRLogBranchOptions();
command += " -d>" + sinceDate.ToString
("yyyy'-'MM'-'dd'T'HH':'mm':'sszz'00'");
command += " " + module;
return command;
}

Per the cvs rlog docs, I think the > is only supposed to
be used with ranges (ie DateA>DateB). For all changes
after a given date you are supposed to leave the
greater than out.

Additional Info:
Using CVSNT 2.0.11
Draco.Net running on WinServer2003
CVS Client 2.0.4 (client shipped with tortoiseCVS)

CVS RLOG DOC SNIPPET
cvs rlog [-lRhtSNb] [-r[revisions]] [-d dates] [-s states]
[-w[logins]] [files...]
.......
-d dates Specify dates (D1<D2 for range, D for latest
before).
.......

Discussion

  • Michael Ferrante

    • priority: 5 --> 2
     
  • Michael Ferrante

    Logged In: YES
    user_id=956382

    Does anyone know if this is still an outstanding issue?

     
  • John Kugelman

    John Kugelman - 2004-10-01

    Logged In: YES
    user_id=544325

    I'm having trouble with this, yes. I'm a new user, trying to
    set up Draco for the first time. I'm having trouble with
    Draco not reporting any changes, and not building my
    project. I tracked it down to this code even before I found
    this bug.

    When I enter the command Draco is executing on the command
    line, I get the message "The parameter is incorrect." If I
    then add quotes around the -d>... parameter, cvs.exe then
    returns the correct list of changes.

    I get this with both the CVSNT and TortoiseCVS cvs.exe
    client executables.

    C:\temp\cvs\FormFaces-20040930T230842Z>"cvs.exe"
    -d:pserver:jkugelman:<<<password>>>@cvs.progeny.net:/usr/local/cvsroot
    -q rlog -N -b -d>2004-10-01T10:39:23-0400 FormFaces
    The parameter is incorrect.

    C:\temp\cvs\FormFaces-20040930T230842Z>"cvs.exe"
    -d:pserver:jkugelman:<<<password>>>@cvs.progeny.net:/usr/local/cvsroot
    -q rlog -N -b "-d>2004-10-01T10:39:23-0400" FormFaces

    RCS file:
    /usr/local/cvsroot/FormFaces/Design/Platforms/DotNet/Class
    diagram.vsd,v
    head: 1.1
    branch:
    locks: strict
    access list:
    keyword substitution: b
    total revisions: 1; selected revisions: 0
    description:
    =============================================================================
    ... and so on, with additional log entries ...

     

Log in to post a comment.