[DPP-Robot] [dpp:bugs] #898 IntelliJ FileSystem implementation needs to be reimplemented from scratch

[tobous <to...@us...>]

- **status**: open --> open-accepted
- **assigned_to**: tobous
- **Comment**:

The new handling of the filesystem through the IntelliJ OpenAPI is implemented and integrated through the changes 3397 (https://saros-build.imp.fu-berlin.de/gerrit/#/c/3397/) to 3430 (https://saros-build.imp.fu-berlin.de/gerrit/#/c/3430/). This integration is not completed yet as the classes FileSystemChangedListener and SharedResourceManager still have to be adjusted.



---

** [bugs:#898] IntelliJ FileSystem implementation needs to be reimplemented from scratch**

**Status:** open-accepted
**Group:** IntelliJ 0.1
**Labels:** Intellij 
**Created:** Wed Mar 29, 2017 12:16 PM UTC by Stefan Rossbach
**Last Updated:** Wed Mar 29, 2017 12:16 PM UTC
**Owner:** tobous


After taking a closer look at the current API that IntelliJ provides, the current implementation is beyond broken, full of unnecessary custom self made stuff that is not needed at all.

Issues:

Accessing datastructures (e.g #members()) without requiring the read lock.

Self made maps of files to replaced already provided API functionality like: https://github.com/JetBrains/intellij-community/blob/master/platform/core-api/src/com/intellij/openapi/vfs/VirtualFile.java#L347 (see IProject#findMember()).

The requirement of IntelliJ project instances, although IntelliJ modules should be shared (which are already unique by their names, even among multiple projects).

Ignoring the fact the modules may contain submodules and therefore have to be filtered out for #members() and #findMember() invokations.

The lack of converting VirtualFiles to IFiles along with their corresponding modules.

Ignoring the fact the IntelliJ modules may have multiple content roots, etc. pp.


---

Sent from sourceforge.net because dpp...@li... is subscribed to https://sourceforge.net/p/dpp/bugs/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/dpp/admin/bugs/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.