Re: [Dpp-devel] Review Request: [Improved] Invitation now longer reads files into memory

[Stefan R. <ros...@in...>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://saros-build.imp.fu-berlin.de/reviews/r/160/
-----------------------------------------------------------

(Updated Sept. 1, 2011, 3:11 p.m.)


Review request for Saros and SWTP.


Changes
-------

-fix projects with empty files should now be handled correctly


Summary
-------

The files of the project are now streamed instead of compressed and then send via an archive (they are compressed on the fly).

Known bugs:

Progress monitors display the wrong status

I know this is quite a big patch, because i was refactoring some files

Should work with multiple projects and users.

Yes i know that there was a streaming solution, but i do not use them because the StreamServiceManager can freeze Eclipse. I had no 
lust to browse through 2000 Lines of weird code, so i implemented this feature from scratch.


This addresses bug 3390825.
    http://sourceforge.net/support/tracker.php?aid=3390825


Diffs (updated)
-----

  /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/SarosContext.java 3547 
  /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/ArchiveStreamService.java 3547 
  /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/IncomingProjectNegotiation.java 3547 
  /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/InvitationProcess.java 3547 
  /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/OutgoingProjectNegotiation.java 3547 
  /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/ProjectNegotiation.java 3547 
  /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/ITransmitter.java 3547 
  /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/DataTransferManager.java 3547 
  /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/TransferDescription.java 3547 
  /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/net/internal/XMPPTransmitter.java 3547 
  /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/SarosSessionManager.java 3547 
  /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/wizards/AddProjectToSessionWizard.java 3547 
  /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/util/FileZipper.java 3547 

Diff: http://saros-build.imp.fu-berlin.de/reviews/r/160/diff


Testing
-------

manual and STF self test, also i got some failures. I am just investigate the problems.


Thanks,

Stefan