Menu
▾
▴
Re: [Dpp-devel] Review Request: Part III: A little extra for the new UI code
|
From: Karl B. <kar...@fu...> - 2010-10-26 08:26:10
|
> On 2010-10-26 03:42:51.264366, bjornson wrote: > > ./src/de/fu_berlin/inf/dpp/ui/SessionView.java, line 467 > > <http://saros-build.imp.fu-berlin.de/reviews/r/113/diff/1/?file=1237#file1237line467> > > > > I would name the class SessionViewExplanation or SessionViewExplanationWidget. > > A "View" is an already defined concept in the Eclipse Rich Client Platform. Fair enough. > On 2010-10-26 03:42:51.264366, bjornson wrote: > > ./src/de/fu_berlin/inf/dpp/ui/SessionView.java, line 613 > > <http://saros-build.imp.fu-berlin.de/reviews/r/113/diff/1/?file=1237#file1237line613> > > > > That's a lot of copied code from class VideoSharingHowTo just to enable the bullet point like explanation layout. > > > > I would prefer a new BulletExplanationView class or something like that with 2 parameters: > > String text: introductory text > > String[] points: texts to be preceded by an incrementing number > > > > If you think that this makes sense I'd offer myself to implement the stuff. Sounds good. Be my guest! - Karl ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://saros-build.imp.fu-berlin.de/reviews/r/113/#review260 ----------------------------------------------------------- On 2010-10-25 12:40:11.463562, Karl Beecher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://saros-build.imp.fu-berlin.de/reviews/r/113/ > ----------------------------------------------------------- > > (Updated 2010-10-25 12:40:11.463562) > > > Review request for All Saros. > > > Summary > ------- > > A cheeky little addition that builds on Björn's previous two patches. It merely adds an explanation on how to start a session when no session exists. > > (Naturally, this required Parts I and II) > > > Diffs > ----- > > ./src/de/fu_berlin/inf/dpp/ui/SessionView.java 2621 > > Diff: http://saros-build.imp.fu-berlin.de/reviews/r/113/diff > > > Testing > ------- > > > Thanks, > > Karl > > |