Re: [Dpp-devel] Review Request: Automatically checkout from SVN

[Andreas H. <haf...@in...>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://saros-build.imp.fu-berlin.de/reviews/r/48/
-----------------------------------------------------------

(Updated 2010-07-27 14:05:38.208213)


Review request for All Saros.


Summary
-------

[FEATURE] Peers automatically checkout from SVN if the host shares a project under version control. Both need to have Subclipse 1.6.12 or later installed for this to work. Falls back to the old synchronization mechanism if a checkout isn't possible.

Note: Other SVN operations like Switch or Update are still not supported.
Not sure if 1.6.12 is really necessary; this can be changed in the manifest.mf (under Dependencies).

I only tested this locally. I don't know what happens if the peer can't access the repository (bad/missing credentials).

The point of "Saros_Bob no Subclipse.launch" is to simulate a peer who doesn't have Subclipse installed. I don't know if that's gonna work for everyone; I simply unchecked the subclipse related items in the Plug-ins tab.

A review before we open up the release branch would be nice. ^_^


Diffs (updated)
-----

  /META-INF/MANIFEST.MF 2300 
  /Saros_Bob no Subclipse.launch PRE-CREATION 
  /plugin.xml 2300 
  /src/de/fu_berlin/inf/dpp/FileList.java 2300 
  /src/de/fu_berlin/inf/dpp/FileListDiff.java 2300 
  /src/de/fu_berlin/inf/dpp/invitation/IncomingInvitationProcess.java 2300 
  /src/de/fu_berlin/inf/dpp/invitation/OutgoingInvitationProcess.java 2300 
  /src/de/fu_berlin/inf/dpp/project/ISessionManager.java 2300 
  /src/de/fu_berlin/inf/dpp/project/ISharedProject.java 2300 
  /src/de/fu_berlin/inf/dpp/project/SessionManager.java 2300 
  /src/de/fu_berlin/inf/dpp/project/internal/SharedProject.java 2300 
  /src/de/fu_berlin/inf/dpp/ui/actions/GeneralNewSessionAction.java 2300 
  /src/de/fu_berlin/inf/dpp/ui/actions/NewSessionAction.java 2300 
  /src/de/fu_berlin/inf/dpp/ui/actions/NewSessionActionWithoutVC.java PRE-CREATION 
  /src/de/fu_berlin/inf/dpp/ui/actions/PartialNewSessionAction.java 2300 
  /src/de/fu_berlin/inf/dpp/ui/wizards/JoinSessionWizard.java 2300 
  /src/de/fu_berlin/inf/dpp/vcs/SubclipseAdapter.java PRE-CREATION 
  /src/de/fu_berlin/inf/dpp/vcs/VCSAdapter.java PRE-CREATION 
  /src/de/fu_berlin/inf/dpp/vcs/VCSAdapterFactory.java PRE-CREATION 
  /src/de/fu_berlin/inf/dpp/vcs/VCSProjectInformation.java PRE-CREATION 
  /test/src/de/fu_berlin/inf/dpp/net/FileListTest.java 2300 

Diff: http://saros-build.imp.fu-berlin.de/reviews/r/48/diff


Testing
-------


Thanks,

Andreas