dpp-devel

[Dpp-devel] [Patch] fix renaming folders in project root

[Henning S. <hen...@fu...>]

Hi,

found a bug if you try to rename a folder in the project root.

[FIX] renaming of folders in project root

On the client side Saros tries to create the parent folder of the  
renamed one but if there is no parent an IllegalArgumentException is  
thrown.
Worked around by checking if there is a parent folder before creation.

I also added the testcase in TestLink as described by Christopher.

Regards,
   Henning

Re: [Dpp-devel] [Patch] fix renaming folders in project root

[Marc 'B. R. <ma...@ri...>]

Henning Staib wrote:
> Hi,
> 
> found a bug if you try to rename a folder in the project root.
> 
> [FIX] renaming of folders in project root
> 
> On the client side Saros tries to create the parent folder of the
> renamed one but if there is no parent an IllegalArgumentException is
> thrown.
> Worked around by checking if there is a parent folder before creation.

As we don't really know when and why this happens I think this should be
logged.  Then +1 from me.

Ciao,
	Marc 'BlackJack' Rintsch

Re: [Dpp-devel] [Patch] fix renaming folders in project root

[<la...@mi...>]

ok.... 0
to solve this TODO, a meaningful logmessage would be appropriate... then
+1 ;)

> Hi,
>
> found a bug if you try to rename a folder in the project root.
>
> [FIX] renaming of folders in project root
>
> On the client side Saros tries to create the parent folder of the
> renamed one but if there is no parent an IllegalArgumentException is
> thrown.
> Worked around by checking if there is a parent folder before creation.
>
> I also added the testcase in TestLink as described by Christopher.
>
> Regards,
>    Henning
>
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008
> 30-Day
> trial. Simplify your report design, integration and deployment - and focus
> on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now.
> http://p.sf.net/sfu/bobj-july_______________________________________________
> Dpp-devel mailing list
> Dpp...@li...
> https://lists.sourceforge.net/lists/listinfo/dpp-devel
>

Re: [Dpp-devel] [Patch] fix renaming folders in project root

[Henning S. <hen...@fu...>]

Hi,

there is no need for a log message because if #create() is called it  
already logs if the folder that should be created already exists.
the only case where the parent folder is null is if the parent folder  
is the project root.

I changed the comment in this patch to make clear why #create() is  
called recursively.

#create is also used by #mkdirs() and thats why it may have to create  
parent folders.

Regards,
   Henning

Re: [Dpp-devel] [Patch] fix renaming folders in project root

[Christopher O. <chr...@fu...>]

Hi,
   just by giving it a quick look:

Could the recursion be put inside the workspace runnable please? By  
calling #create() recursively another WorkspaceRunnable needs to be  
created and dispatched with the IWorkspace.

IWorkspaceRunnable createFolderProcedure = new IWorkspaceRunnable() {

   public void createRecursive(IFolder toCreate){
     if (toCreate == null || toCreate.exists())
       return; // End of recursion
     createRecursive(getParentFolder(folder));
     folder.create(IResource.NONE, true, monitor);
   }

   public void run(IProgressMonitor monitor) throws CoreException {
     createRecursive(folder);
     if (monitor.isCanceled()) {
       log.warn("Creating folder failed: " + folder);
     }
   }
};

Cheers,
   Christopher

On Tue, 01 Dec 2009 13:05:13 +0100, Henning Staib  
<hen...@fu...> wrote:

> Hi,
>
> there is no need for a log message because if #create() is called it
> already logs if the folder that should be created already exists.
> the only case where the parent folder is null is if the parent folder
> is the project root.
>
> I changed the comment in this patch to make clear why #create() is
> called recursively.
>
> #create is also used by #mkdirs() and thats why it may have to create
> parent folders.
>
> Regards,
>    Henning
>


-- 
Christopher Oezbek | Freie Universität Berlin | Takustr. 9, 14195 Berlin
http://www.inf.fu-berlin.de/~oezbek/ | +49 30 838 75242 | Raum 008