From: Philipp C. <> - 2011-07-10 12:02:39
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://saros-build.imp.fu-berlin.de/reviews/r/102/ ----------------------------------------------------------- Review request for Saros. Summary ------- With this patch I only want to reduce the number of required parameters for creating a ProjectNegotiation or a SessionNegotiation. The change is very simple. All Managers, Listeners or Observables which already the SarosContext contains will now be injected via the already used call of SarosContext.initComponent. Diffs ----- /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/IncomingProjectNegotiation.java 3450 /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/IncomingSessionNegotiation.java 3450 /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/InvitationProcess.java 3450 /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/OutgoingProjectNegotiation.java 3450 /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/OutgoingSessionNegotiation.java 3450 /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/ProjectNegotiation.java 3450 /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/SarosSessionManager.java 3450 Diff: http://saros-build.imp.fu-berlin.de/reviews/r/102/diff Testing ------- Manually tested an invitation between 2 test-instances Thanks, Philipp |
From: Karl B. <be...@in...> - 2011-07-11 09:29:53
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://saros-build.imp.fu-berlin.de/reviews/r/102/#review236 ----------------------------------------------------------- Are your code layout settings correct? Much of the patch seems to be changing the existing layout. - Karl On July 10, 2011, 2:02 p.m., Philipp Cordes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://saros-build.imp.fu-berlin.de/reviews/r/102/ > ----------------------------------------------------------- > > (Updated July 10, 2011, 2:02 p.m.) > > > Review request for Saros. > > > Summary > ------- > > With this patch I only want to reduce the number of required parameters for creating a ProjectNegotiation or a SessionNegotiation. > The change is very simple. All Managers, Listeners or Observables which already the SarosContext contains will now be injected via the already used call of SarosContext.initComponent. > > > Diffs > ----- > > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/IncomingProjectNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/IncomingSessionNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/InvitationProcess.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/OutgoingProjectNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/OutgoingSessionNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/ProjectNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/SarosSessionManager.java 3450 > > Diff: http://saros-build.imp.fu-berlin.de/reviews/r/102/diff > > > Testing > ------- > > Manually tested an invitation between 2 test-instances > > > Thanks, > > Philipp > > |
From: Philipp C. <> - 2011-07-13 05:24:44
|
> On July 11, 2011, 11:29 a.m., Karl Beecher wrote: > > Are your code layout settings correct? Much of the patch seems to be changing the existing layout. Oh sorry. I don't recognize this. But it's also possible that the file was not already formatted. Patches of other participants also changing line-breaks etc... - Philipp ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://saros-build.imp.fu-berlin.de/reviews/r/102/#review236 ----------------------------------------------------------- On July 10, 2011, 2:02 p.m., Philipp Cordes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://saros-build.imp.fu-berlin.de/reviews/r/102/ > ----------------------------------------------------------- > > (Updated July 10, 2011, 2:02 p.m.) > > > Review request for Saros. > > > Summary > ------- > > With this patch I only want to reduce the number of required parameters for creating a ProjectNegotiation or a SessionNegotiation. > The change is very simple. All Managers, Listeners or Observables which already the SarosContext contains will now be injected via the already used call of SarosContext.initComponent. > > > Diffs > ----- > > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/IncomingProjectNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/IncomingSessionNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/InvitationProcess.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/OutgoingProjectNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/OutgoingSessionNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/ProjectNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/SarosSessionManager.java 3450 > > Diff: http://saros-build.imp.fu-berlin.de/reviews/r/102/diff > > > Testing > ------- > > Manually tested an invitation between 2 test-instances > > > Thanks, > > Philipp > > |
From: Karl B. <be...@in...> - 2011-07-25 15:16:16
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://saros-build.imp.fu-berlin.de/reviews/r/102/#review272 ----------------------------------------------------------- Ship it! - Karl On July 10, 2011, 2:02 p.m., Philipp Cordes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://saros-build.imp.fu-berlin.de/reviews/r/102/ > ----------------------------------------------------------- > > (Updated July 10, 2011, 2:02 p.m.) > > > Review request for Saros. > > > Summary > ------- > > With this patch I only want to reduce the number of required parameters for creating a ProjectNegotiation or a SessionNegotiation. > The change is very simple. All Managers, Listeners or Observables which already the SarosContext contains will now be injected via the already used call of SarosContext.initComponent. > > > Diffs > ----- > > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/IncomingProjectNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/IncomingSessionNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/InvitationProcess.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/OutgoingProjectNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/OutgoingSessionNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/ProjectNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/SarosSessionManager.java 3450 > > Diff: http://saros-build.imp.fu-berlin.de/reviews/r/102/diff > > > Testing > ------- > > Manually tested an invitation between 2 test-instances > > > Thanks, > > Philipp > > |
From: Stefan R. <ros...@in...> - 2011-08-30 13:31:53
|
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://saros-build.imp.fu-berlin.de/reviews/r/102/#review463 ----------------------------------------------------------- Ship it! - Stefan On July 10, 2011, 2:02 p.m., Philipp Cordes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://saros-build.imp.fu-berlin.de/reviews/r/102/ > ----------------------------------------------------------- > > (Updated July 10, 2011, 2:02 p.m.) > > > Review request for Saros. > > > Summary > ------- > > With this patch I only want to reduce the number of required parameters for creating a ProjectNegotiation or a SessionNegotiation. > The change is very simple. All Managers, Listeners or Observables which already the SarosContext contains will now be injected via the already used call of SarosContext.initComponent. > > > Diffs > ----- > > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/IncomingProjectNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/IncomingSessionNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/InvitationProcess.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/OutgoingProjectNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/OutgoingSessionNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/invitation/ProjectNegotiation.java 3450 > /trunk/dpp/de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/project/SarosSessionManager.java 3450 > > Diff: http://saros-build.imp.fu-berlin.de/reviews/r/102/diff > > > Testing > ------- > > Manually tested an invitation between 2 test-instances > > > Thanks, > > Philipp > > |