Menu ▾ ▴

#875 Session startup does not prevent invitation requests

Core 1.0
closed-fixed
Stefan Rossbach
Core (3)
5
2019-12-02
2016-09-21
Alexander Jakobi
No

Description

A certain sequence of commands can lead to a state in which both parties (inviter and invitee) of a session initiation see an invitation dialog. As a consequence, a working session can not be established.

Reproduction Steps

Insert a Thread.sleep into SessionManager#StartSession() for the affected client. Start the session and meanwhile invite this client.

The invitation can be accepted, there are NO error log messages in the log file.

Expected Behaviour

When a session is initiated, only the invitee should see an invitation dialog and the wizard to choose the project location. As soon as an invitation is sent/received, incoming invitation should be automatically declined.

1 Attachments
invitation_error.png

Discussion

  • Stefan Rossbach

    Stefan Rossbach - 2016-09-21
    • status: open --> closed-invalid
     

  • Stefan Rossbach

    Stefan Rossbach - 2016-09-22

    I cannot reproduce this with Saros/E.

    It is also impossible to receive 2 invitations. This is handled in the core.

     

    • Franz Zieris

      Franz Zieris - 2016-09-23

      It is also impossible to receive 2 invitations.

      See point 14: It's not one developer receiving two invitations, but two developers both receiving an invitation from each other.

       

  • Franz Zieris

    Franz Zieris - 2016-09-23
    • labels: --> Intellij
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -7,18 +7,18 @@

 This could not be reliably reproduced. The following is a test protocol with steps during which the faulty behaviour occured repeatedly, but not always.

-1. Bob invites Alice
-2. Alice accepts
-3. Alice is asked where to save the files, chooses a place and clicks ok
-4. Bob's network connection is interrupted (e.g. switched off WIFI)
-5. Alice sees a message box: _Wizard cancelled locally, no response from..._
-6. Alice clicks ok, the message box and wizard disappear; a progress bar remains blocking further actions
+1. Alice invites Bob
+2. Bob accepts
+3. Bob is asked where to save the files, chooses a place and clicks ok
+4. Alice's network connection is interrupted (e.g. switched off WIFI)
+5. Bob sees a message box: _Wizard cancelled locally, no response from..._
+6. Bob clicks ok, the message box and wizard disappear; a progress bar remains blocking further actions
 7. Approx. 30 seconds later, the progressbar disappears and an error message is shown: _Project could not be shared._
-8. Alice is in no session
-9. Bob's Saros panel still shows him being connected (See #870, #873)
-10. Bob clicks disconnect, then reconnects
-11. Bob invites Alice
-12. Alice accepts
+8. Bob is in no session
+9. Alice's Saros panel still shows her being connected (See [#870], [#873])
+10. Alice clicks disconnect, then reconnects
+11. Alice invites Bob
+12. Bob accepts
 13. They both are shown to be in a session
 14. **Both see a the wizard to choose the project location**
    • status: closed-invalid --> unread
     

    Related

    Bugs: #870
    Bugs: #873

  • Franz Zieris

    Franz Zieris - 2016-09-23

    Switched names of Alice and Bob. Alice is always the one starting the session first.

     

  • Stefan Rossbach

    Stefan Rossbach - 2016-09-23
    • labels: Intellij --> Core
    • summary: Inviter Gets Invitation Dialog from Invitee --> Session startup does not prevent invitation requests
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -5,22 +5,9 @@

 **Reproduction Steps**

-This could not be reliably reproduced. The following is a test protocol with steps during which the faulty behaviour occured repeatedly, but not always.
+Insert a Thread.sleep into SessionManager#StartSession() for the affected client. Start the session and meanwhile invite this client.

-1. Alice invites Bob
-2. Bob accepts
-3. Bob is asked where to save the files, chooses a place and clicks ok
-4. Alice's network connection is interrupted (e.g. switched off WIFI)
-5. Bob sees a message box: _Wizard cancelled locally, no response from..._
-6. Bob clicks ok, the message box and wizard disappear; a progress bar remains blocking further actions
-7. Approx. 30 seconds later, the progressbar disappears and an error message is shown: _Project could not be shared._
-8. Bob is in no session
-9. Alice's Saros panel still shows her being connected (See [#870], [#873])
-10. Alice clicks disconnect, then reconnects
-11. Alice invites Bob
-12. Bob accepts
-13. They both are shown to be in a session
-14. **Both see a the wizard to choose the project location**
+The invitation can be accepted, there are NO error log messages in the log file.

 **Expected Behaviour**
    • status: unread --> open-accepted
    • Attachments has changed:

    Diff:

    --- old
+++ new
@@ -0,0 +1 @@
+invitation_error.png (175.5 kB; image/png)
     

    Related

    Bugs: #870
    Bugs: #873

  • Stefan Rossbach

    Stefan Rossbach - 2017-04-17
    • status: open-accepted --> open-fixed
    • assigned_to: Stefan Rossbach
    • Group: OTHER --> Core 1.0
     

  • tobous

    tobous - 2018-03-15
    • status: open-fixed --> pending-fixed
     

  • tobous

    tobous - 2019-12-02
    • Status: pending-fixed --> closed-fixed
     

Log in to post a comment.