Saros - Distributed Party Programming / Bugs / #870 Saros view is not reflecting the current internal status

Alexander Jakobi - 2016-09-07

Group: 14.10.31 --> OTHER
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Stefan Rossbach - 2016-09-07

Why is this specific to the connection state presentation. Reading your reproduction steps the first think that comes into my mind is that this issue may affect the whole Saros GUI in IntelliJ.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alexander Jakobi - 2016-09-07

I'm not sure I fully understand you. Are you aiming at that I should broaden the scope of this bug?
This is what I observed, I don't know whether other parts of the GUI are affected/involved and if so, in which way.
Could you elaborate, please?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Stefan Rossbach - 2016-09-07

What happens if you close the project during a session ? If the session is terminated than it seems that only the connection part of GUI is broken. If the session remains it may also affect other GUI parts.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Alexander Jakobi - 2016-09-07
  
  Ah ok. The session is not terminated. I edited the ticket. Feel free to do the same if you see room for improvement.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

summary: Saros view shows not connected when in fact it is --> Saros view shows not reflecting the current internal status
Description has changed:

Diff:

--- old
+++ new
@@ -1,6 +1,6 @@
 **Description**

-The saros view only shows "not connected" but in fact there is a connection and an invitation can be sent using the "Share with" button in the project view.
+The saros view only shows "not connected" but in fact there is a connection and an invitation can be sent using the "Share with" button in the project view. It's also possible to be in a session without having it shown in the GUI. So the GUI is not showing the current internal state.

 **Reproduction**
@@ -12,7 +12,17 @@
 * Note the saros view showing "not connected"
 * Try to initiate a session via the "Share with" button which should work unless there is not contact online

+or
+
+* Have a project opened
+* In the saros view, connect to the XMPP server
+* Initiate a session with a contact
+* Have the contact cancel the invitation, you're now in an "empty" session
+* File > Close Project
+* Choose to open the same or another (or a new) project
+* Note the saros view not indicating that you're in a session, but internally you still are (to test this have a contact send an invitation which gets automatically rejected with the message that you're already in a session)
+

 **Expected Behaviour**

-The saros view should reflect the correct current status, even after closing and (re)opening a project.
+The saros view should reflect the correct current internal status, even after closing and (re)opening a project.

Stefan Rossbach - 2016-09-07

I can provide you a simple solution to the problem. If it is possible to hook into the closing opening mechanism of a project you can just call ConnectionHandler#disconnect(). This will bring you back to a stable state. It is more like a hack/workaround but it fulfill its needs.

And I am the wrong person to ask for anything in the IntelliJ part of Saros.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Franz Zieris - 2016-09-23

Labels: IntelliJ --> IntelliJ, Intellij
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Franz Zieris - 2016-09-23

labels: IntelliJ, Intellij --> Intellij
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Alexander Jakobi - 2016-10-12

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Stefan Rossbach - 2016-10-12

status: closed-fixed --> open-fixed

assigned_to: Alexander Jakobi
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Stefan Rossbach - 2016-10-12

e287343433d920f6589bcb05da863a372931972b

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Stefan Rossbach - 2017-04-17

Group: OTHER --> IntelliJ 0.1
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

tobous - 2018-03-15

status: open-fixed --> pending-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

tobous - 2018-03-22

Labels: Intellij --> Intellij, IntelliJ
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

tobous - 2018-03-22

labels: Intellij, IntelliJ --> IntelliJ
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

tobous - 2019-12-02

Status: pending-fixed --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Saros view is not reflecting the current internal status

Group

Searches

Help

#870 Saros view is not reflecting the current internal status

Related

Discussion