#869 Host in session despite session creation failed

[Alexander Jakobi]

Description
When initiating a session fails (invitation rejected, partner already in session, network failures, timeouts) the host still shows to be in a session in the saros view (host in in session section, leave session button available).
Also when a partner tries to invite the host to a session, he/she gets rejected because of the invitee being in a session.

Reproduction

• As contact A Invite a contact B to a session
• Have the contact B reject the invitation
• Note that contact A's GUI indicates contact A is in a session
• Let contact B invite contact A to a session
• Note that contact B's invitation gets rejected because of contact A already being in a session

Expected Behaviour
When a session initiation fails (for whatever reason), the host is not in a session (internally & visually) but in the normal "ready to invite / get invited" mode.

[Stefan Rossbach]

Not a "bug". See: http://saros-build.imp.fu-berlin.de/gerrit/#/c/3029/

This behavior is also needed in the server part.

[Alexander Jakobi]

I see. Seems a little rough from a user's perspective in my opinion. With this behaviour I'd be missing some sort of "pre-stage", to have a flow like this:

• Create a session - no contact or module selected yet
• Add module/resource and contact
• Start by sending invitation
• Stop
• Leave session

I wouldn't expect to be in a session when explicitly initiating one with a preselected contact and resource and after failing/rejection because I don't get any feed back that there was a session created.

[Stefan Rossbach]

In Eclipse you can start a session without even inviting anyone. And in Eclipse this is displayed. During an invitation the session is already started. Just take a look at the Saros view.

[Alexander Jakobi]

Should I create a feature request to have the same in IntellJ?

[Stefan Rossbach]

What feature ? Starting a session only on the remote side ? It is a "hidden" feature, so just let it by hidden because I do not think the majority off users have even found it yet.

And by the way. You can share more than one project in Eclipse. So auto canceling the session will result in finishing the Wizard for the session again (because in this scenerio it is not a simple right click on the user name).

[Alexander Jakobi]

I meant to have the same kind of functionality in IntelliJ that Eclipse already has. If it's possible to start a session without inviting a contact in Eclipse and have this displayed, then why not in IntelliJ?

As I said, to me it seems a little counterintuitive to be left in a session when I get the impression the session creation did not work due to invitiation rejection etc.

But that's just my 2 cents, I'm happy to leave it as is.

[Franz Zieris]

From how understand the problem description, the behavior is the same as in Saros/Eclipse. If the invitee cancels the invitation, the host can just re-invite the same user again. Is that possible in Saros/I?

[Bernd Sahre]

No, because its not possible to add any additional ressources to a Saros/Intellij Session, neither Users nor Files (so the Share with / Work Togehter Buttons didnt work).

[Alexander Jakobi]

When in an "empty" session it is possible to re-invite.

[Stefan Rossbach]

It is actually possible or does only the option appear ? I looked at the code and have my doubts.

[Stefan Rossbach]

Seems I looked at the menu entry code and not the popup code. Neverless the code starts to try another session (which is ignored). Mabye not the best pratice.

[Bernd Sahre]

My bad, its actually possible to use the Work/Together Button in a session. So it works to invite somebody, altough it fails if there are already two members in the session. Its pretty buggy there, for short timeperiods on PC shows 3 members in a session (then an Remote error occurs: Invitation not acccepted and this User is then alone), but you can also create Scenarios with one User in a session with two instances, as host and as member.

[Stefan Rossbach]

Even if IntelliJ does not allow (for what reason ever) to add more resources (mainly modules) to a session, adding more USERS is a requirement!

So congratulation, you found the real issue. Can you please change the description and content of this bug entry ?

[Franz Zieris]

OK, as this seems to be a bit confusing under the hood, I'd be satisfied with the following intermediate solutions for Saros/I:

1. It's ok to only allow sessions with max. two participants. Either the invitee accepts the invitation and the session and project negotiation run smoothly, or he declines or there is an error in which case the host should be able to reinvite him.
2. If, from a technical point of view, a re-invitation is too complicated starting from the state the host is already alone in a session, then stopping the session altogether to get a clean slate is tolerable. This depends on the Saros/I code base which I'm not familiar with.

Either way, Bernd and Alex, please reflect your new understanding and any insights in the ticket description.

[Franz Zieris]

What's the status of this bug? The expected behavior was:

When a session initiation fails (for whatever reason), the host is not in a session (internally & visually) but in the normal "ready to invite / get invited" mode.

Are we there yet?