Menu
▾
▴
#854 Jabber ID is correct but does not validate
I work in a company where we have our own jabber server. Our Jabber IDs are made out of our e-mail addresses with @ substituted by #.
When I try to add my account (user#company.de@xmpp.company.org) the wizard says "Your XMPP/Jabber ID must be in the format user@domain", and I cannot add any account. This is linked to the "#" in username, at least the message disappears when removing the # out of the username.
Please allow # in Jabber/XMPP ID and enable us (200+ users) to evaluate your great plugin.
Patch is under review: http://saros-build.imp.fu-berlin.de/gerrit/2741
Very fast. Excellent. Thank you very much for your time fixing this.
If this means anything to you, I will evaluate and promote this plugin for peer programming and code-review in my company as soon as our jabber ids can be used.
Franz you could either re-release the current version with your fix or just provide the patched JID.class file for download until we correctly resolved the issue with JID verification.
I was indeed thinking of a patched re-release.
There will be a "hotfix" release Saros 13.12.6.1 -- the two necessary patches for that still need to be formally approved (see http://saros-build.imp.fu-berlin.de/gerrit/2742, http://saros-build.imp.fu-berlin.de/gerrit/2743). As soon as this is done, I'll refresh the update site and you should be able to install the patched version of Saros.
For the (embarrassingly-long-delayed) release 14.10.31, there will also be such a "hotfix" (see http://saros-build.imp.fu-berlin.de/gerrit/2744).
The original patch (i.e. http://saros-build.imp.fu-berlin.de/gerrit/2741) will be rededicated for dealing with the validation issue in a proper way (instead of just adding more and more exceptions to our regex).
The update-site http://dpp.sourceforge.net/update/ now provides the patched Saros version.
This ticket remains open until http://saros-build.imp.fu-berlin.de/gerrit/2741 is merged into the master.
cf36d4d646136239a427da6531a20d671eef38f5