Menu

#836 Eclipse hangs after class field rename

None
closed-migrated
nobody
UndoManager (1)
8
2018-03-27
2014-10-01
No
  1. Saros session started by sharing one of the source folders in a project.
  2. Invited person goes to a class file and uses Alt+Shift+R to rename a field in the class. The inviting person has the same file open.
  3. Eclipse of the invited person freezes! The renamed field on the inviting persons's side is change back to the old name.

Reproduced two times in a row.
Attached jstack results.

1 Attachments

Discussion

  • Stefan Rossbach

    Stefan Rossbach - 2014-10-01
    • status: open --> open-accepted
     

    Last edit: tobous 2018-03-23
  • Stefan Rossbach

    Stefan Rossbach - 2014-10-01

    Please disable the ConcurrentUndo feature as "workaround" to prevent the Eclipse stall.

     
  • Stefan Rossbach

    Stefan Rossbach - 2014-10-01
    DEBUG 18:42:51,093 [main] (UndoManager.java:196) new Typing : Typing (org.eclipse.core.internal.commands.operations.GlobalUndoContext@3eb4dd4a)
    TRACE 18:42:51,093 [dpp-activity-sender] (ActivitySequencer.java:493) send (001) jenkins_alice_stf@saros-con.imp.fu-berlin.de/Saros -> [ViewportActivity(path: SPath [path=src/rossbach/A.java, project=A], range: (0,9))]
    DEBUG 18:42:51,093 [main] (UndoManager.java:196) new Typing: Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    DEBUG 18:42:51,094 [main] (UndoManager.java:205) undoing operation Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    DEBUG 18:42:51,094 [main] (UndoManager.java:492) calculated undo: Noop(0,'')
    TRACE 18:42:51,094 [dpp-activity-sender] (DataTransferManager.java:213) send TransferDescription [elementName=ados, namespace=de.fu_berlin.inf.dpp, recipient=jenkins_alice_stf@saros-con.imp.fu-berlin.de/Saros, sender=jenkins_bob_stf@saros-con.imp.fu-berlin.de/Saros, compress=true], data len=267 byte(s), connection=[mode=SOCKS5 (D), id=saros-main-session] jenkins_alice_stf@saros-con.imp.fu-berlin.de/Saros
    DEBUG 18:42:51,094 [main] (UndoManager.java:496) nothing to undo in SPath [path=src/rossbach/A.java, project=A]
    TRACE 18:42:51,094 [dpp-activity-sender] (NetworkManipulatorImpl.java:134) intercepting outgoing packet to: jenkins_alice_stf@saros-con.imp.fu-berlin.de/Saros
    DEBUG 18:42:51,094 [main] (UndoManager.java:196) new Typing : Typing (org.eclipse.core.internal.commands.operations.GlobalUndoContext@3eb4dd4a)
    TRACE 18:42:51,095 [dpp-activity-sender] (BinaryChannelConnection.java:533) sending transfer description: id=0
    DEBUG 18:42:51,095 [main] (UndoManager.java:196) new Typing: Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    TRACE 18:42:51,095 [dpp-activity-sender] (BinaryChannelConnection.java:517) sending data: id=0, len=212 bytes
    DEBUG 18:42:51,095 [main] (UndoManager.java:205) undoing operation Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    DEBUG 18:42:51,095 [main] (UndoManager.java:492) calculated undo: Noop(0,'')
    DEBUG 18:42:51,095 [main] (UndoManager.java:496) nothing to undo in SPath [path=src/rossbach/A.java, project=A]
    DEBUG 18:42:51,096 [main] (UndoManager.java:196) new Typing : Typing (org.eclipse.core.internal.commands.operations.GlobalUndoContext@3eb4dd4a)
    DEBUG 18:42:51,096 [main] (UndoManager.java:196) new Typing: Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    DEBUG 18:42:51,096 [main] (UndoManager.java:205) undoing operation Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    DEBUG 18:42:51,096 [main] (UndoManager.java:492) calculated undo: Noop(0,'')
    DEBUG 18:42:51,096 [main] (UndoManager.java:496) nothing to undo in SPath [path=src/rossbach/A.java, project=A]
    DEBUG 18:42:51,097 [main] (UndoManager.java:196) new Typing : Typing (org.eclipse.core.internal.commands.operations.GlobalUndoContext@3eb4dd4a)
    DEBUG 18:42:51,097 [main] (UndoManager.java:196) new Typing: Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    DEBUG 18:42:51,097 [main] (UndoManager.java:205) undoing operation Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    DEBUG 18:42:51,097 [main] (UndoManager.java:492) calculated undo: Noop(0,'')
    DEBUG 18:42:51,098 [main] (UndoManager.java:496) nothing to undo in SPath [path=src/rossbach/A.java, project=A]
    DEBUG 18:42:51,098 [main] (UndoManager.java:196) new Typing : Typing (org.eclipse.core.internal.commands.operations.GlobalUndoContext@3eb4dd4a)
    DEBUG 18:42:51,098 [main] (UndoManager.java:196) new Typing: Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    DEBUG 18:42:51,099 [main] (UndoManager.java:205) undoing operation Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    DEBUG 18:42:51,099 [main] (UndoManager.java:492) calculated undo: Noop(0,'')
    DEBUG 18:42:51,099 [main] (UndoManager.java:496) nothing to undo in SPath [path=src/rossbach/A.java, project=A]
    DEBUG 18:42:51,099 [main] (UndoManager.java:196) new Typing : Typing (org.eclipse.core.internal.commands.operations.GlobalUndoContext@3eb4dd4a)
    DEBUG 18:42:51,099 [main] (UndoManager.java:196) new Typing: Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    DEBUG 18:42:51,100 [main] (UndoManager.java:205) undoing operation Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    DEBUG 18:42:51,100 [main] (UndoManager.java:492) calculated undo: Noop(0,'')
    DEBUG 18:42:51,100 [main] (UndoManager.java:496) nothing to undo in SPath [path=src/rossbach/A.java, project=A]
    DEBUG 18:42:51,100 [main] (UndoManager.java:196) new Typing : Typing (org.eclipse.core.internal.commands.operations.GlobalUndoContext@3eb4dd4a)
    DEBUG 18:42:51,101 [main] (UndoManager.java:196) new Typing: Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    DEBUG 18:42:51,101 [main] (UndoManager.java:205) undoing operation Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    DEBUG 18:42:51,101 [main] (UndoManager.java:492) calculated undo: Noop(0,'')
    DEBUG 18:42:51,101 [main] (UndoManager.java:496) nothing to undo in SPath [path=src/rossbach/A.java, project=A]
    TRACE 18:42:51,101 [BinaryChannel-jenkins_alice_stf] (BinaryChannelConnection.java:363) processing opcode 0xFA [TFD]: id=0, chunks=1
    DEBUG 18:42:51,101 [main] (UndoManager.java:196) new Typing : Typing (org.eclipse.core.internal.commands.operations.GlobalUndoContext@3eb4dd4a)
    TRACE 18:42:51,102 [BinaryChannel-jenkins_alice_stf] (BinaryChannelConnection.java:409) processing opcode 0xFB [DATA]: id=0, DATA len=213 bytes
    DEBUG 18:42:51,102 [main] (UndoManager.java:196) new Typing: Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    TRACE 18:42:51,102 [BinaryChannel-jenkins_alice_stf] (NetworkManipulatorImpl.java:98) intercepting incoming packet from: jenkins_alice_stf@saros-con.imp.fu-berlin.de/Saros
    DEBUG 18:42:51,102 [main] (UndoManager.java:205) undoing operation Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    TRACE 18:42:51,102 [BinaryChannel-jenkins_alice_stf] (DataTransferManager.java:98) received binary XMPP extension: TransferDescription [elementName=ados, namespace=de.fu_berlin.inf.dpp, recipient=jenkins_bob_stf@saros-con.imp.fu-berlin.de/Saros, sender=jenkins_alice_stf@saros-con.imp.fu-berlin.de/Saros, compress=true], size: 213, RX time: 0 ms [SOCKS5 (D)]
    DEBUG 18:42:51,102 [main] (UndoManager.java:492) calculated undo: Noop(0,'')
    DEBUG 18:42:51,103 [main] (UndoManager.java:496) nothing to undo in SPath [path=src/rossbach/A.java, project=A]
    DEBUG 18:42:51,103 [main] (UndoManager.java:196) new Typing : Typing (org.eclipse.core.internal.commands.operations.GlobalUndoContext@3eb4dd4a)
    DEBUG 18:42:51,104 [main] (UndoManager.java:196) new Typing: Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    DEBUG 18:42:51,104 [main] (UndoManager.java:205) undoing operation Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    DEBUG 18:42:51,104 [main] (UndoManager.java:492) calculated undo: Noop(0,'')
    DEBUG 18:42:51,104 [main] (UndoManager.java:496) nothing to undo in SPath [path=src/rossbach/A.java, project=A]
    TRACE 18:42:51,104 [DispatchContext] (ActivitySequencer.java:543) rcvd (001) jenkins_alice_stf@saros-con.imp.fu-berlin.de/Saros -> [ViewportActivity(path: SPath [path=src/rossbach/A.java, project=A], range: (0,9))]
    DEBUG 18:42:51,105 [main] (UndoManager.java:196) new Typing : Typing (org.eclipse.core.internal.commands.operations.GlobalUndoContext@3eb4dd4a)
    TRACE 18:42:51,105 [dpp-activity-dispatcher] (ActivityHandler.java:389) dispatching [#1] optimized activities [mode = 0] : [ViewportActivity(path: SPath [path=src/rossbach/A.java, project=A], range: (0,9))]
    DEBUG 18:42:51,105 [main] (UndoManager.java:196) new Typing: Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    DEBUG 18:42:51,105 [main] (UndoManager.java:205) undoing operation Typing(org.eclipse.core.internal.filebuffers.SynchronizableDocument@2d1d61c4)
    org.eclipse.text.undo.DocumentUndoManager$UndoableTextChange undo modification stamp: 562789 redo modification stamp: 562790 start: 39, end: 50, text: '', preservedText: ' private '
    DEBUG 18:42:51,105 [main] (UndoManager.java:492) calculated undo: Noop(0,'')
    
    ...
    

    This never stops. Just noticed this endless loop as my CPU cooler starts spinning up.

     

    Related

    Bugs: #1


    Last edit: tobous 2018-03-22
  • Franz Zieris

    Franz Zieris - 2014-11-03

    Feature disabled in [1cb32e], bugfix yet to come.

     

    Related

    Commit: [1cb32e]

  • tobous

    tobous - 2018-03-20
    • status: open-accepted --> open
     
  • tobous

    tobous - 2018-03-27
    • Status: open --> closed-migrated
     

Log in to post a comment.