After sharing parts of the project Alice shares the full project with Bob leading to inconsistencies. Sharing is entirely broken -> Bob remains in inconsistent state without being able to recover. Bob does not get any file, only the folders
An easy fix is to forbid sharing the full project after it was shared part, ( one line fix). Upgrading a partial sharing to a full sharing may require much more analysis.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Is there a good way to reproduce this? I tried the following without any problems:
* Session with ALICE and BOB
* ALICE has one project (JUnit 4.8.2), BOB has an empty workspace
* ALICE shares package org.junit.runner with BOB
* BOB accepts as a new project
* ALICE right-clicks on her project and select "Add to Saros Session"
* BOB accepts as an existing project (re-using the previously created JUnit project)
* ALICE and BOB both have a consistent, full-shared project
I used the current master (Git 0b7b758), so maybe this issue got fixed meanwhile and nobody noticed. If nobody can provide a way to reproduce the described failure, I will close this ticket as out-dated.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I think there are still problems. As least I remember, every partial share will treated as a new project (new project id). In reality you do not have upgraded your partial shared project, instead you now have two shared projects.
See: SarosSessionManager#addResourcesToSession
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
An easy fix is to forbid sharing the full project after it was shared part, ( one line fix). Upgrading a partial sharing to a full sharing may require much more analysis.
Is there a good way to reproduce this? I tried the following without any problems:
* Session with ALICE and BOB
* ALICE has one project (JUnit 4.8.2), BOB has an empty workspace
* ALICE shares package org.junit.runner with BOB
* BOB accepts as a new project
* ALICE right-clicks on her project and select "Add to Saros Session"
* BOB accepts as an existing project (re-using the previously created JUnit project)
* ALICE and BOB both have a consistent, full-shared project
I used the current master (Git 0b7b758), so maybe this issue got fixed meanwhile and nobody noticed. If nobody can provide a way to reproduce the described failure, I will close this ticket as out-dated.
I think there are still problems. As least I remember, every partial share will treated as a new project (new project id). In reality you do not have upgraded your partial shared project, instead you now have two shared projects.
See: SarosSessionManager#addResourcesToSession
Should be reanalysed after patch http://saros-build.imp.fu-berlin.de/gerrit/#/c/393/ is applied to the master branch.
I cannot reproduce this in the current master. Even Franz said that he could not reproduce this behavior on a much older master branch.