#639 Adding new files as readonly possible

[Alexander Waldmann]

It should not be possible to create new files as a read only user in a shared project.
I don't know if it is possible to prevent the file creation operation entirely by hooking into the eclipse events.

The same goes for moving files as a readonly user which should be prevented too.

[Alexander Waldmann]

The watchdog does not react when i add a PNG file via drag and drop to the shared project.

it is not shared to the host of the session too, but the watchdog should still react to this...

[Alexander Waldmann]

Or maybe the watchdog does not have to react since the added file is not part of the sharing, if saros does not explicitly KNOW about "full project sharing" and "partial project sharing", but always uses a filelist.
i.e. if a full project sharing is the same as "partially sharing all files in a project". In this case the newly added file is existant in a shared project but not part of the shared file list, thus the watchdog does not react.

[Alexander Waldmann]

Now i am confused - when adding a new file from within eclipse, the watchdog reacts, so i guess the problem is that there is no listener for file drag&drop actions.

[Alexander Waldmann]

Deleting files locally as readonly user does not trigger the watchdog.
I know, there is a dialog warning that i should not delete the file, but the watchdog should still react to deleted files...

Imagine a file that gets deleted locally on the readonly participants machine (outside eclipse!) and the user refreshes his project. The file is removed but he is not notified that there is an inconsistency.
Only when following the host, and the host opens the locally deleted file, the watchdog reacts.

[Alexander Waldmann]

Please also note, that the follow mode does not recover from this problem - after resolving the inconsistencies, the followmode participant does not get an editor for the file, even though the followed host has the file opened...

[Karl Beecher]

For some reason, the ResourceChangeValidator is not alerted to the creation of new files by read-only users, therefore no warning pops-up at all.

[Karl Beecher]

Here's why the ResourceChangeValidator isn't alerted for new file creation (it's apparently by design):

http://www.eclipse.org/forums/index.php/t/210409/

[Stefan Rossbach]

Watchdog only tracks opened editors. There exists no "text editor" for files with binary content that cannot be displayed as text (images, music, etc ...)

[Stefan Rossbach]

The Feature was not working with Eclipse 3.X.

It works again with Eclipse 4.X

You will get a warning if you try to modify resources while you are only have read permission rights.