#56 nice if BruteForcePropertyDescriptor didn\'t rewrite == value

closed
None
5
2006-09-02
2006-05-03
Matt Benson
No

Dozer maps to an existing property value object, but
then still tries to write it. So if I have getters for
a property that is guaranteed always to return a value
I don't need to use setters in these cases. To
accomplish this I added a block of code to
BruteForcePropertyDescriptor.setPropertyValue(Object,
Object, Hint, ClassMap). I will attach as a unified
diff patch. Existing tests pass with no apparent
negative performance impact.

Discussion

  • Matt Benson

    Matt Benson - 2006-05-12

    Logged In: YES
    user_id=120761

    patch works against 21XIndexBranch

     
  • Franz Garsombke

    Franz Garsombke - 2006-05-15

    Logged In: YES
    user_id=550744

    Should I patch this to v21XBranch? The v21XIndexBranch was
    for the original index contributor to add some bug fixes. I
    will be merging that branch into the v21XBranch. Confused
    yet? :)

     
  • Matt Benson

    Matt Benson - 2006-05-19
    • assigned_to: nobody --> orangeherbert
     
  • Matt Benson

    Matt Benson - 2006-05-30

    Logged In: YES
    user_id=120761

    first patch would only have handled shallow properties;
    reworked slightly to catch deep properties as well.

     
  • Matt Benson

    Matt Benson - 2006-05-31

    Logged In: YES
    user_id=120761

    back to original patch; the second one did weird things I
    didn't like...

     
  • Matt Benson

    Matt Benson - 2006-05-31

    updated patch to 21XBranch

     
  • Matt Tierney

    Matt Tierney - 2006-08-13
    • assigned_to: orangeherbert --> mhtierney
     
  • Matt Tierney

    Matt Tierney - 2006-08-13
    • status: open --> pending
     
  • Matt Tierney

    Matt Tierney - 2006-08-13

    Logged In: YES
    user_id=1236069

    I applied the patch to the v21XBranch and the unit tests
    are 100% green, so I will check in. I also ran the perf
    tests after applying the patch and didn't notice any
    difference. Thanks for submitting the patch.

     
  • Matt Tierney

    Matt Tierney - 2006-09-02
    • summary: nice if BruteForcePropertyDescriptor didn't rewrite == value --> nice if BruteForcePropertyDescriptor didn\'t rewrite == value
    • status: pending --> closed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks