#147 orphan should call remove()

Dozer v.4.3
closed-fixed
5
2008-11-19
2008-08-12
No

In MappingProcessor.addOrUpdateToList(), if orphan exists the list is resetted by calling:

1. clear()
2. addAll()

Instead, the code should check for orphan and call remove() (as stated in the documentation!).

Since "mappedElement" is a HashSet, result does not have the correct ordering after the mapping is done.

Discussion

  • dmitry (lv)

    dmitry (lv) - 2008-10-12

    A HashSet is not guaranteed to maintain its ordering. It varies between JDK Versions and vendors.

     
  • dmitry (lv)

    dmitry (lv) - 2008-10-18
    • milestone: --> Dozer v.4.3
    • assigned_to: nobody --> sterala
     
  • dmitry (lv)

    dmitry (lv) - 2008-11-19
    • labels: --> Mapping Issue
    • assigned_to: sterala --> buzdin
    • status: open --> closed-fixed
     
  • dmitry (lv)

    dmitry (lv) - 2008-11-19

    Sorry for misunderstanding. This was actually a bug. And the good news that it is now fixed and will be shipped in next release pretty soon.

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks