#14 incorrect set mapping for existing destination set

closed
None
5
2005-10-13
2005-10-11
Anonymous
No

private Set mapSetToSet(...) {
...
Object field = doesFieldExist(fieldMap, destObj);
Set result = null;
if (field == null) {
...
} else {
result = new LinkedHashSet((Collection)
sourceCollectionValue);

-----------------------------------------------
This creates the destination set from the source
without mapping which causes errors when the classes
being mapped aren't comparable (I'm using a custom
converter).

Wouldn't it be better for result to just be the
destination set? ie.

result = (Set) field;

Discussion

  • Franz Garsombke

    Franz Garsombke - 2005-10-11
    • assigned_to: nobody --> fgarsombke
     
  • Franz Garsombke

    Franz Garsombke - 2005-10-11

    Logged In: YES
    user_id=550744

    Let me look into this one.

     
  • Franz Garsombke

    Franz Garsombke - 2005-10-12

    Logged In: YES
    user_id=550744

    This is fixed for 1.5.5.

    Thanks for the bug!

     
  • Franz Garsombke

    Franz Garsombke - 2005-10-12

    Logged In: YES
    user_id=550744

    Can you send me your test case so I can add this to our unit
    tests?

    Thanks.

    Franz

    fgarsombke@yahoo.com

     
  • Franz Garsombke

    Franz Garsombke - 2005-10-12
    • status: open --> pending
     
  • Nobody/Anonymous

    Logged In: NO

    Sorry, this is closed source code.

    Rohan

     
  • Franz Garsombke

    Franz Garsombke - 2005-10-13
    • status: pending --> closed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks