Re: [Doxygen-develop] Build error for Ninja Generator

[Albert <alb...@gm...>]

Dear Masaru,

Thanks for the notification.

Albert

On Thu, May 3, 2018 at 9:53 AM, masaru tsuchiyama <m.t...@gm...>
wrote:

> Sorry, it worked.
>
>
> 2018年5月3日(木) 16:51 Albert <alb...@gm...>:
>
>> Dear Masaru,
>>
>> I saw the comment n github and commented on it. More important for me is
>> does the solution work.
>>
>> Albert
>>
>>
>> <http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> Virus-free.
>> www.avg.com
>> <http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
>> <#m_-7810229674902884587_m_-1732287477614699547_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>>
>> On Thu, May 3, 2018 at 12:50 AM, masaru tsuchiyama <m.t...@gm...>
>> wrote:
>>
>>> Hi
>>>
>>> I commented to the pull request.
>>>
>>>
>>> 2018年5月3日(木) 1:32 Albert <alb...@gm...>:
>>>
>>>> I've just pushed a proposed patch to github (pull request 712,
>>>> https://github.com/doxygen/doxygen/pull/712).
>>>>
>>>> Albert
>>>>
>>>> On Wed, May 2, 2018 at 4:03 PM, Albert <alb...@gm...> wrote:
>>>>
>>>>> Dear Masaru,
>>>>>
>>>>> A bit strange. The construct as used for TEST_FLAGS is the same
>>>>> construct as used for e.g. LEX_FLAGS ad BISON_FLAGS
>>>>> Do you have an idea why it is working for LEX_FLAGS / YACC_FLAGS and
>>>>> not for TEST_FLAGS.
>>>>>
>>>>> I tried to create a Ninja version under Windows but I fail due to the
>>>>> fact that cmake cannot find bison, looks like here are some quotes missing
>>>>> around the YACC_FLAGS. Will have to do some further testing here.
>>>>> When replacing the $(TEST_FLAGS) in the build.ninja by $$(TEST_FLAGS)
>>>>> it looks like to start compiling, also some more tests required.
>>>>>
>>>>> Albert
>>>>>
>>>>>
>>>>>
>>>>> On Wed, May 2, 2018 at 3:09 PM, masaru tsuchiyama <m.t...@gm...>
>>>>> wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> I found a bug that doxygen can't compile for Ninja generator.
>>>>>> It works for 'Unix Makefiles' generator
>>>>>>
>>>>>> This is the error message.
>>>>>>
>>>>>> ninja: warning: multiple rules generate generated_src/configvalues.h.
>>>>>> builds involving this target will not be correct; continuing anyway [-w
>>>>>> dupbuild=warn]
>>>>>> ninja: error: build.ninja:2384: bad $-escape (literal $ must be
>>>>>> written as $$)
>>>>>>
>>>>>> This is the diff of build.ninja between good revision ( ok_
>>>>>> b6f01ff09b17e5c2288f2418ef0a8f074456c357)
>>>>>> and bad revision (c78c338fffbdbb9b2379b1896e647f7cc697da57)
>>>>>>
>>>>>> $ diff build/build.ninja ok_b6f01ff09b17e5c2288f2418ef0a8f074456c357
>>>>>> 2384c2384
>>>>>> <   COMMAND = cd /home/user/gitwork/doxygen/build/testing &&
>>>>>> /usr/bin/python /home/user/gitwork/doxygen/testing/runtests.py
>>>>>> $(TEST_FLAGS) --doxygen /home/user/gitwork/doxygen/build/bin/doxygen
>>>>>> --inputdir /home/user/gitwork/doxygen/testing --outputdir
>>>>>> /home/user/gitwork/doxygen/build/testing
>>>>>> ---
>>>>>> >   COMMAND = cd /home/user/gitwork/doxygen/build/testing &&
>>>>>> /usr/bin/python /home/user/gitwork/doxygen/testing/runtests.py --all
>>>>>> --doxygen /home/user/gitwork/doxygen/build/bin/doxygen --inputdir
>>>>>> /home/user/gitwork/doxygen/testing --outputdir
>>>>>> /home/user/gitwork/doxygen/build/testing
>>>>>>
>>>>>> By tweaking  $(TEST_FLAGS) to  --all, the build succeeded.
>>>>>>
>>>>>> This is a script to reproduce.
>>>>>> ------------------------------------------------------------
>>>>>> -------------------
>>>>>> #!/bin/sh
>>>>>>
>>>>>> if [ -e build ]; then
>>>>>>   rm -rf build
>>>>>> fi
>>>>>> mkdir build
>>>>>> cd build
>>>>>>
>>>>>> cmake -G Ninja -D CMAKE_BUILD_TYPE=Release ..
>>>>>> cmake --build . -- -j 3 -v || echo error && cd .. && exit 1
>>>>>>
>>>>>> cd ..
>>>>>> ------------------------------------------------------------
>>>>>> -------------------
>>>>>>
>>>>>>
>>>>>>
>>>>>> ------------------------------------------------------------
>>>>>> ------------------
>>>>>> Check out the vibrant tech community on one of the world's most
>>>>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>>>>> _______________________________________________
>>>>>> Doxygen-develop mailing list
>>>>>> Dox...@li...
>>>>>> https://lists.sourceforge.net/lists/listinfo/doxygen-develop
>>>>>>
>>>>>>
>>>>>
>>>>
>>