[Doxygen-develop] Re: [PATCH] ftv icons made lynx/accessible-compatible

[Vassilii K. <vas...@ta...>]

I've slightly misleaded you in my comments with the patch.
(actual code that works is OK). Please tell if you'd like me
to re-submit this one, doing either (1) or (2) below.

...
> Last thing, it abstracts the filenames management - right now
> it is sufficient to rename the file in just the image_info[]
> initializer and the new macros will take care of it in the
> rest of the code.

That is slightly wrong, the FTV_ICON_FILE macro
would also need to be modified. Right now it always assumes
that the files are named ftv2*.png ; in case of the naming convention
change, it should be changed accordingly.

If the files are never going to be renamed, just take back
my original ease of file rename comment.

Alternatively, to make it really transparent as I said, the macro
should just pick up the name from the corresponding
_INFO(nym).name; this can come in one of the 2 flavours
1) /* Like IMG_PREAMBLE, relying on the outer << ... << context */
#define FTV_ICON_FILE(nym) << _INFO(nym).name <<

2) /* would require framing the uses of FTV_ICON_FILE() with << ... <<
at the call level - slightly longer calling code, but maybe a bit more
readable */
#define FTV_ICON_FILE(nym) _INFO(nym).name
and replace all the uses of FTV_ICON_FILE(), like
-    t << "      var vl = \"" FTV_ICON_FILE(vertline) "\";\n";
+    t << "      var vl = \"" << FTV_ICON_FILE(vertline) << "\";\n";

> Index: ftvhelp.cpp
> ===================================================================
> RCS file: /u/kp3softd/cvsroot/src/ftvhelp.cpp,v
> retrieving revision 1.18
> diff -u -p -r1.18 ftvhelp.cpp
> --- ftvhelp.cpp	2003/04/30 19:40:08	1.18
> +++ ftvhelp.cpp	2003/05/02 17:51:41

[other chunks snipped]

> @@ -639,6 +666,8 @@ void FTVHelp::generateTreeView()
>        t << cssfi.fileName();
>      }
>      t << "\">" << endl;
> +	/// @todo provide alt for images so that lynx shows it all right
> +	/// and for disabled readers that use it via Braille or TTS
>      t << "    <title>TreeView</title>\n";
>      t << "    <style type=\"text/css\">\n";
>      t << "    <!--\n";

The above chunk inserts a bogus comment - it was there for me
in my private repository as a reminder to implement this thing,
but now that it is implemented, it is no longer relevant.
If you need me to re-submit to do (1) or (2), I'll no
longer include this chunk; otherwise, just delete it yourself
before applying the patch.

Vassilii