[Doxygen-develop] doxygen-1.8.5:doxygen.cpp:3572: possible bad if test ?

[David B. <dc...@ho...>]

Hello there,

I just ran the static analyser "cppcheck" over the source
code of doxygen-1.8.5. It said many things, including

[doxygen.cpp:3572]: (warning) Logical conjunction always evaluates to false: EXPR != -1 && EXPR == -1.

Source code is

if (md->getStartBodyLine()!=-1 && md->getStartBodyLine()==-1)

Suggest code rework.

The analyser also said

[fortranscanner.cpp:1307]: (style) Array index 'i' is used before limits check.
[markdown.cpp:541]: (style) Array index 'i' is used before limits check.
[markdown.cpp:1317]: (style) Array index 'i' is used before limits check.
[markdown.cpp:1323]: (style) Array index 'i' is used before limits check.

which may also be worth fixing.

Regards

David Binderman