DoubleCommand 1.6.6b3: Remapping Enter broken

[Michael Guntsche]

Hi,

As Brian wrote here http://sourceforge.net/forum/message.php?msg_id=4863005 remapping enter to another key no longer works in B3.

I traced this regression down to the change between r219 and r220 in Substitute.cpp

Index: kext/Substitute.cpp

--- kext/Substitute.cpp    (revision 219)
+++ kext/Substitute.cpp    (revision 220)
@@ -54,6 +54,8 @@
     AbsoluteTime * ts)
{
int return_value = kContinue;
+addFlags = 0;
+removeFlags = 0;

#ifdef MB_DEBUG
     printf("caught  hid event type %d flags 0x%x key %d ", *eventType, *flags, *key);

Reverting this changes makes mapping the Enter key possible again.
Checking with the Keyboard viewer I noticed the following.

Pressing ENTER itself correctly remaps to the desired key (Option in my case).
As soon as you hit another key, the remapping disappears and only the second keycode is triggered.
I could verify this with the "Key Codes" application as well.

I know that this change went in to take care of stuck keys, but it completely messes up the enter remapping functionality in my case.

Kind regards,
Michael

[Tim Harper]

I just verified this problem.  I use DoubleCommand to remap the 'enter' key to control.  However, the latest b3 breaks that.  Reverting to the latest stable release fixed the issue.

Thanks!

Tim