Core module prep for helpdesk update

Brought to you by: ajdonnison, kchisholm

#267 Core module prep for helpdesk update

Milestone: Stable

Status: pending

Owner: Ivan Peevski

Labels: General (114)

Priority: 5

Updated: 2011-06-21

Created: 2011-06-20

Creator: HaTaX

Private: No

These updates are in preparation for the helpdesk module updates. They will allow the file system to properly integrate with the helpdesk.

Discussion

HaTaX - 2011-06-20

diff patch for changes to core files module

files_module_change_for_helpdesk.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

HaTaX - 2011-06-20

assigned_to: nobody --> cyberhorse
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

HaTaX - 2011-06-20

diff patch for changes core public module for selector.php

public_module_change_for_helpdesk.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

HaTaX - 2011-06-20

added both diff files, one is for the files module, the other is for the selector. (selector is used in the permissions selection screen, without it you cannot change permissions on an individual helpdesk item)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

HaTaX - 2011-06-20

I posted additional updates on the dP forums as well. There were changes to how the project and projectdesigner modules interact, and some changes to the main index.php file to lay the groundwork for RSS functionality.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ivan Peevski - 2011-06-21

Added the necessary changes to core. Will add the helpdesk as a new module download once a couple of issues have been addressed:
- Deadline date picker doesn't work
- Upgrade (from whatever version I had) didn't work - the SQL for adding a column to the files table is missing:
"ALTER TABLE `files` ADD `file_helpdesk_item` int(11) NOT NULL default '0' AFTER `file_task`"
Regarding altering core file tables, it would be better if you can accommodate this in the helpdesk module's tables instead (create a new helpdesk_files table if needed). The less modifications to core, the better (and more stable) result overall as a general rule of thumb.

You should also amend the uninstall procedure to drop the created column in the files table (similar to how it's done for task_logs)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ivan Peevski - 2011-06-21

Thanks for your suggestion. This has merit and has been accepted
into the CVS.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ivan Peevski - 2011-06-21

status: open --> pending
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

HaTaX - 2011-06-27

diff patch for updated changes to files module addedit.php

UPDATED_files_module_change_for_helpdesk.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

HaTaX - 2011-06-27

Attached patch file for updated changes to addedit.php to allow pre-selection of folder in picker. If the folder_id is passed as a negative value, this will disable the picker and lock it to the folder_id passed. Removed getHelpdeskFolder function as it is no longer needed with the ability to pass it via post.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ivan Peevski - 2011-06-27

Last patch (to addedit.php) applied (with minor changes)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

HaTaX - 2011-07-01

There was a small omission in the patch applied, the negative value is used to select the folder ID and it ends up reverting to the root folder.

Line 189 reads:
(($folder_sel ? $folder_sel

To select the correct folder it should be:
(($folder_sel ? abs($folder_sel)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ivan Peevski - 2011-07-02

Fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.