Re: [dotNetRDF-Develop] CORE-445

[Max - M. <ma...@mi...>]

Hi Rob,

I finally could solve my branching issue so I finally sent a separate pull
request for the new SparqlParameterizedString implementation.

Max.


2015-05-04 10:46 GMT+02:00 Max - Micrologiciel <ma...@mi...>:

> Hi Rob,
>
> Well, my first try at branching and I think I messed up my repo... (too
> old for this s** ;) )
> Bitbucket won't let me create a new branch in my repository and I don't
> have time to address this now. So I'll let you handle this,
>
> I join the new implementation of the SparqlParametrizedString along with a
> basic test suite.
>
> You'll see that I abandoned the Regex approach within ToString and
> replaced it with lightweight string processing on command text updates.
> This also allows not to capture any constant SPARQL parameter- or
> variable-like patterns (in-text language tags, @ or ? patterns in string
> literals and Iris...) should they occur.
>
> You may want to check the _invalidIRICharacters and quote handling are
> correct.
>
> After some tries, I dropped the cache idea since look-ups were too
> consuming.
> That surely came from the way I handled this but caching is not my forte
> so I'll leave this part to anybody willing to handle this.
> The performance boost is however already consequent since a ~170kB command
> with 3k variables was processed by the original implementation in ~20s on
> my machine. The test suite drops down to <10ms on average.
>
>
> Cheers,
> Max.
>
>
>
>