Menu
▾
▴
Re: [dotNetRDF-Develop] Store manager improvements
|
From: Rob V. <rv...@do...> - 2013-12-11 12:09:32
|
Eugen Generally I like the changes, I have a few suggestions for improvements. Firstly since the tabs act mainly as buttons to quickly focus on a specific connection I'd suggest using FlatButtons Appearance for the tabs. I've already made this change in the main repository, note that I've moved the changes onto the TOOLS-390 branch in the main repository, if you can pull my changes to your fork and then make any further changes in that branch instead of default that would be much appreciated. Currently the query results overwrite each other, so if I run subsequent queries the previous query results are hidden. It might be a nice idea to have a tab control within the results area and have each new query add a tab preferably with some way to view in each result tab what query produced the results, this would also need the ability to close result tabs that are no longer needed. Another nice feature to have would be the ability to detach results into a separate window when desired though I'm less fussed about this. I'm not really sure what the entities feature is doing since it didn't seem to do much in my testing, I'd like to understand exactly what this is attempting to do. Wrt to the code for this it would be better to use the SparqlParameterizedString class for constructing the queries rather than String.Format() and string concatenation. See the Representing Queries section at https://bitbucket.org/dotnetrdf/dotnetrdf/wiki/UserGuide/Querying%20with%20S PARQL for an example of using this class. Note that you can get the namespaces associated with the existing query by using the NamespaceMap property and the Base URI using the BaseUri property, you can then simply copy these to your SparqlParameterizedString instance avoiding the need to do this by string extraction. (Actually it doesn't have a BaseUri property, I'll add that soon) In general I'm wondering that if you are looking to give a more entity centric view of the data in a store whether it wouldn't be better to add this functionality as a new entities tab and develop entity viewer controls and associated tasks specifically for this rather than reusing the Query Tab? Cheers, Rob From: Rob Vesse <rv...@do...> Reply-To: dotNetRDF Developer Discussion and Feature Request <dot...@li...> Date: Tuesday, 10 December 2013 16:12 To: dotNetRDF Developer Discussion and Feature Request <dot...@li...> Subject: Re: [dotNetRDF-Develop] Store manager improvements > Thanks for that, I've pulled your changes locally and will try and take a > proper look at them tomorrow. I've glanced over the code changes and > everything looks OK but I haven't got as far as running the revised UI yet. > > When I do review properly I'll try and look at the entities query stuff and > see if there is any way to make it more efficient. > > Thanks for spotting the bug in BaseEndpoint, I introduced this by accident > with a recent commit and it should now be fixed again with my most recent > commits > > Cheers, > > Rob > > From: Eugen F <feu...@ya...> > Reply-To: Eugen F <feu...@ya...> > Date: Tuesday, 10 December 2013 09:46 > To: Rob Vesse <rv...@do...> > Cc: dotNetRDF Developer Discussion and Feature Request > <dot...@li...> > Subject: Re: [dotNetRDF-Develop] Store manager improvements > >> I've updated the repository, so maybe you can check the changes. >> >> Note that there is a change in BaseEnpoint "throw new ArgumentException("HTTP >> Mode can only be GET/POST, derived implementations should override this >> property if they wish to support more methods");" that I had to comment in >> order to make the version from repository connect to an endpoint. (no >> relation to my changes). >> >> Also I tried to make an external endpoint work with that entities change, but >> i only get timeouts...because of the complex query i think. >> >> >> >> >> >> >> >> >> >> On Monday, December 9, 2013 2:50 PM, Rob Vesse <rv...@do...> >> wrote: >> >> >> Eugen >> >> Forking a Mercurial repository copies all branches, however if you could >> commit your changes to the default branch that would be best >> >> Thanks, >> >> Rob >> >> From: Eugen F <feu...@ya...> >> Reply-To: Eugen F <feu...@ya...> >> Date: Monday, 9 December 2013 12:20 >> To: Rob Vesse <rv...@do...> >> Subject: Re: [dotNetRDF-Develop] Store manager improvements >> >>> I have made the changes so it's now both MDI and tabs, forked repository at >>> https://bitbucket.org/feugen24/storemanager_tabs. Still I'm not sure it's >>> the correct version because there were lots of tags when creating the fork, >>> so i picked the "dynamic" that was selected by default. I assumed dynamic >>> means (latest). >>> If it's ok i'll update this one. >>> >>> >>> >>> >>> >>> On Sunday, December 8, 2013 5:33 PM, Rob Vesse <rv...@do...> >>> wrote: >>> >>> >>> Hi Eugen >>> >>> Thanks for the detailed email, yes there are advantages to a tabbed >>> interface though I suspect some users (like myself) may prefer to have the >>> MDI interface still. >>> >>> What would be ideal from my perspective would be to integrate this such that >>> users can switch between the modes as desired, so users who prefer the >>> current interface can continue to use it and those that like the new >>> interface can use that instead. Or even to have it such that you can dock >>> connections into a tabbed interface as and when desired. >>> >>> The changes all sound useful but I haven't previewed them at all because I'm >>> afraid I'm not going to run a compiled executable from someone who's >>> emailing me for the very first time even if it does pass the virus checker. >>> If you can provide either a link to the git repository, a patch against >>> latest trunk or ideally a mercurial fork that would be fantastic. We use >>> Mercurial for our development with our main repository hosted on BitBucket >>> at http://bitbucket.org/dotnetrdf/dotnetrdf if you can fork the code on >>> BitBucket, transfer your changes to there and then open a pull request that >>> would be the best way for us to see and review your changes. >>> >>> Btw this is a subscription list, your email was moderated through and you've >>> been CC'd on this initial reply but if you could subscribe at >>> https://lists.sourceforge.net/lists/listinfo/dotnetrdf-develop so you can >>> participate in this discussion going forward without us having to manually >>> CC you each time that would be much appreciated. >>> >>> Thanks, >>> >>> Rob >>> >>> From: Eugen F <feu...@ya...> >>> Reply-To: Eugen F <feu...@ya...>, dotNetRDF Developer Discussion and >>> Feature Request <dot...@li...> >>> Date: Saturday, 7 December 2013 11:42 >>> To: "dot...@li..." >>> <dot...@li...> >>> Subject: [dotNetRDF-Develop] Store manager improvements >>> >>>> Hi, >>>> >>>> I'm working with store manager and because of the midi interface it's >>>> difficult to interact with it, meaning each time i create a connection a >>>> new window is created, then when I run a query another window, rerun a >>>> query...new window, then close the one of the first query run and so on. >>>> >>>> So i think the approach in sql server management studio or brightstardb >>>> polaris tool is much better. Both have tabs for each new connection, and >>>> when i rerun a query only results change (no new window). >>>> So i made the following changes: >>>> - when a connection is opened a new tab page is created and I add >>>> StoreManagerForm as a child to it >>>> - each tab has a close btn >>>> The rest of the functionality is the same except for query tab where: >>>> - i added a splitter control where panel 1 has query window , panel 2 has >>>> query results (both for graph and resultset) >>>> - i added a new button for orientation ( --| ) so we can change the >>>> orientation of the splitter ( vertical mode is v helpful on wide screens >>>> with few columns on results) >>>> - i removed "query" word from all buttons to occupy less space (i think >>>> it's obvious since we are in query window tab) >>>> - i changed AutoSizeColumnsMode to AllCells (previous was DisplayedCells >>>> but i had problems with it when large uri's where not in current view) >>>> >>>> I also added a feature (in query tab) to expand a query for some subjects >>>> so i can see all the properties and values of those subjects. This allows a >>>> user to see similar results as sql server in case he has entities. For >>>> example if a user is using Entityframework api from brightstardb he can the >>>> select entities of rdf:type "Car" and see all car entities with values, in >>>> a table. >>>> - i added a new checkbox "AsEntities" that allows this feature when checked >>>> (it takes first variable from the current query as entity id/subject) >>>> It transforms user query to get all properties and the dynamically creates >>>> a query to get the entities. >>>> - i also added a numeric control next to the checkbox with default value of >>>> 1. This was necessary because in may case I have some predicates that are >>>> entities themselves and i need to filter those out. (a group by is used to >>>> filter predicates using that default value of 1) >>>> >>>> I've attached the working version so you can play with it. I worked on a >>>> local git source control using latest 102 source code. >>>> Let me know what you think of the changes, and if it's ok, how to >>>> send/publish the source code. I've not really worked on any open source >>>> project so i don't know the flow. >>>> --------------------------------------------------------------------------- >>>> --- Sponsored by Intel(R) XDK Develop, test and display web and hybrid apps >>>> with a single code base. Download it for free now! >>>> http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktr >>>> k_______________________________________________ dotNetRDF-develop mailing >>>> list >>>> dot...@li...https://lists.sourceforge.net/lists/ >>>> listinfo/dotnetrdf-develop >>> >>> >>> >>> >>> >>> >> >> >> >> >> >> > ------------------------------------------------------------------------------ > Rapidly troubleshoot problems before they affect your business. Most IT > organizations don't have a clear picture of how application performance > affects their revenue. With AppDynamics, you get 100% visibility into your > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! > http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk___ > ____________________________________________ dotNetRDF-develop mailing list > dot...@li... > https://lists.sourceforge.net/lists/listinfo/dotnetrdf-develop |
