[dotNetRDF-Develop] Issue CORE-332 has a new comment

[<tr...@do...>]

<p>A new comment has been added to the following issue.</p>
<table border="0">
  <tr>
    <td width="90px" valign="top"><b>Title:</b></td>
    <td>Evaluate whether any of the BrightstarDB patches should be incorporated into the code base</td>
  </tr>
  <tr>
    <td><b>Project:</b></td>
    <td>Core Library (dotNetRDF.dll)</td>
  </tr>
  <tr>
    <td><b>Created By:</b></td>
    <td>Kal</td>
  </tr>
  <tr>
    <td><b>Date:</b></td>
    <td>2013-03-05 09:20 AM</td>
  </tr>
  <tr>
    <td><b>Comment:</b></td>
  </tr>
  <tr>
    <td colspan="2"><p>
	You can almost certainly ignore the patches in the obsolete subdirectory. Take a look at patchlog.txt to see our notes on each patch. The last time we reviewed these against the dotNetRDF code base was some time around the 0.9 release of dotNetRDF.</p>
<p>
	My take on the patches:</p>
<p>
	2029_20120125_libraries_core_query_SPARQLExpressionParser.cs.patch : this is required to allow the use of long integer data types as RDF literals. The impact on other code seems pretty low.</p>
<p>
	2156_20120320_libraries_core_query_algebra_Set.cs.patch : this has almost certainly been obsoleted by work done since then. I dont&#39; think this is a critical patch</p>
<p>
	2181_20120516_libraries_core_core.patch : this is a useful API extension that we made use of to enable &nbsp;BrightstarDB to make better use of the dotNetRDF parsers (I forget the exact context now, but I think it was to allow us to not use buffered token queues on the mobile build). It has a low impact on other code and I would recommend it.</p>
<p>
	2369_20120813_libraries_core.silverlight_compatibility_SilverlightCompatability.cs.patch : this may have been done by now in the core dotNetRDF code, but it is a required patch to get the Silverlight build to work properly.</p>
<p>
	2371_20120912_libraries_core_query_algebra_LazyBgp.cs.patch : Can&#39;t comment on this one, perhaps Graham can shed some light, but I think Graham and Rob had a bit of discussion around this when we first hit the issue.</p>
<p>
	&nbsp;</p></td>
  </tr>
</table>
<p>
            More information on this issue can be found at
            <a href="http://www.dotnetrdf.org/tracker/Issues/IssueDetail.aspx?id=332" target="_blank">http://www.dotnetrdf.org/tracker/Issues/IssueDetail.aspx?id=332</a></p>
<p style="text-align:center;font-size:8pt;padding:5px;">
            If you no longer wish to receive notifications, please visit <a href="http://www.dotnetrdf.org/tracker/Account/UserProfile.aspx" target="_blank">your profile</a> and change your notifications options.
        </p>