From: Rob V. <rv...@do...> - 2012-10-22 20:40:47
|
On 10/22/12 1:38 PM, "Rob Vesse" <rv...@do...> wrote: >Ok > >Can you send me a pull request for the IIS Express related changes? > >Then I'll look at getting those projects fixed up as necessary > >Rob > >On 10/22/12 11:32 AM, "Tomasz Pluskiewicz" <tom...@gm...> >wrote: > >>Thanks Rob, looks like vsmdi file was the cause. >> >>I still got quite a few tests failing for various reasons. One more >>frequent reason comes from the WebDemos app, where ConfigurationLoader >>calls Type.GetType("VDS.RDF.Configuration.AdoObjectFactory, >>dotNetRDF.Data.Sql") but AdoObjectFactory is apparently not there >>anymore and the config.ttl needs updating. There is the same issue >>with BSBM and sp2b web apps. >> >>Speaking of the web applications. Have a look at my latest commit [1]. >>I have changed the projects to use the IIS Express I have mentioned >>some time ago so you can see how it works for you. I have also updated >>the test config template and the IIS servers should start on the same >>port for everyone. If you have Visual Studio with SP1 installed IIS >>Express you should be prompted to install IIS Express the first time >>using Web Platform installer. It is an advantage over using full IIS, >>which for one may be absent on developer machines and doesn't require >>running VS with admin rights (actually is it currently necessary for >>running the WebDemos and others?). Also to address your concerns you >>have expressed the other time, IIS Express 7.5 is fully compatible >>with IIS 7. I have used it for several projects during development and >>there were never any issues. >> >>Regards, >>Tom >> >>[1] >>https://bitbucket.org/romanticweb/dotnetrdf/changeset/95a6fee1fd093ea49f9 >>f >>c62c35c45df2634e0997 >> >>On Mon, Oct 22, 2012 at 6:50 PM, Rob Vesse <rv...@do...> wrote: >>> This sounds like your test environment may not be correct, looks like >>>this >>> is because I have the Tests.testrunconfig checked in but not the >>> dotNetRDF.vsmdi which would be required for that testrunconfig file to >>>be >>> respected, should be corrected in the repo now. Please pull the latest >>> from Trunk >>> >>> Other comments inline: >>> >>> >>> On 10/22/12 2:36 AM, "Tomasz Pluskiewicz" >>><tom...@gm...> >>> wrote: >>> >>>>Hi Rob >>>> >>>>I wanted to make sure my working on the fluant API didn't intruduce >>>>any regressions I ran the unit tests and many of them have failed on >>>>opening the test files. Namely 436 tests have failed and most seem to >>>>fail for simmilar reasons. It seems that in most of the test methods >>>>you load files simmilarily to >>>> >>>>OntologyGraph g = new OntologyGraph(); >>>>FileLoader.Load(g, "InferenceTest.ttl"); >>>> >>>>This tries to load the file from the bin/Debug folder but the testing >>>>files reside inside bin\Debug\resources. Do you or anyone else also >>>>get all those failed? It seem there is a need to fix that... >>> >>> The MSTest runner in Visual Studio does not run tests from the >>>bin/Debug >>> directory, rather it copies the DLL (and dependencies) to a new >>>directory >>> called TestResults/somedir usually created at the solution level. >>>somedir >>> is a generated name consisting usually of your machine name and a >>> timestamp concatenated. >>> >>> It does not explicitly copy any Content resources for the project, >>>this >>>is >>> done explicitly by configuring the Tests.testrunconfig file which can >>>be >>> found at the top level of the repository (or under Solution Items in >>> Visual Studio). This is where it specifies that the resources >>>directory >>> be copied into the test directory, this copying copies directory >>>contents >>> rather than directories as-is hence the lack of "resources" in the >>>paths >>> in the actual tests. >>> >>> The missing vsdmi file meant the test config wasn't respected and so >>>the >>> resources weren't copied hence the errors you saw. >>> >>> >>>> >>>>Also taking VDS.RDF.Test.Ontology.OntologyTests as an example, you >>>>load the file in every test method. You are but aware of the >>>>[TestInitialize] attribute for method which runs before every test >>>>method and can be used for preparing test environment? >>> >>> Yes but often the act of loading the model is part of the test not a >>>setup >>> activity. >>> >>> >>>>Also having >>>>looked at the aforementioned test class, why are there no Asserts in >>>>the test methods? >>> >>> For some tests the test is simply that the code not thrown an exception >>> (which would by definition cause a test failure) >>> >>> Rob >>> >>>> >>>>Thanks >>>>Tom >>> >>> >>> |