Menu

#46 deactivateRevision button is unexpected behavior

open
Web UI (10)
6
2010-10-24
2010-10-24
georgefx
No

All input forms should have a single submit button:
If the user is presented a form with inputs, the expected behavior is to submit inputs made in the form. A second submit button with a different set of functionality (i.e. the changed form entries are ignored) is unexpected. This is also reflected by the cluttered if/else statements in the controller code.
The deactivate button in the edit should really be check box and handled as such in the controller code.
There may be a deactivate button elsewhere in the UI, but then functionality must not be mixed. That is, deactivate should then be handled as a single request.

Discussion